risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794787601
##
File path:
solr/modules/hdfs/src/test/org/apache/solr/store/blockcache/BlockCacheTest.java
##
@@ -257,7 +259,7 @@ public void testCacheConcurrent() throws
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794786304
##
File path:
solr/modules/hdfs/src/test/org/apache/solr/store/blockcache/BlockCacheTest.java
##
@@ -257,7 +259,7 @@ public void testCacheConcurrent() throws
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794687908
##
File path: solr/modules/hdfs/README.md
##
@@ -0,0 +1,31 @@
+Apache Solr HDFS Module
+===
+
+Introduction
+
+This mod
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794661450
##
File path: solr/core/src/java/org/apache/solr/update/UpdateHandler.java
##
@@ -115,12 +115,12 @@ public UpdateHandler(SolrCore core, UpdateLog updateLog)
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794672231
##
File path: gradle/documentation/render-javadoc.gradle
##
@@ -151,8 +151,25 @@ configure(project(":solr:test-framework")) {
"org.apache.solr.analysi
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794671450
##
File path: solr/contrib/README.md
##
@@ -0,0 +1,31 @@
+Apache Solr HDFS Contrib module
+===
+
+Introduction
+
+This
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794669642
##
File path: solr/test-framework/src/java/org/apache/solr/handler/package.html
##
@@ -0,0 +1,24 @@
+
+
+
Review comment:
I think this should be handle
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794667891
##
File path: gradle/documentation/render-javadoc.gradle
##
@@ -151,8 +151,25 @@ configure(project(":solr:test-framework")) {
"org.apache.solr.analysi
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794661450
##
File path: solr/core/src/java/org/apache/solr/update/UpdateHandler.java
##
@@ -115,12 +115,12 @@ public UpdateHandler(SolrCore core, UpdateLog updateLog)
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794644433
##
File path: solr/solr-ref-guide/src/solr-on-hdfs.adoc
##
@@ -16,11 +16,12 @@
// specific language governing permissions and limitations
// under the Licens
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794644098
##
File path: gradle/validation/validate-source-patterns.gradle
##
@@ -108,6 +108,11 @@ allprojects {
configure(project(':solr:core')) {
project.tasks.with
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794633440
##
File path: gradle/validation/validate-source-patterns.gradle
##
@@ -108,6 +108,11 @@ allprojects {
configure(project(':solr:core')) {
project.tasks.with
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r794033698
##
File path: solr/test-framework/build.gradle
##
@@ -31,5 +31,16 @@ dependencies {
implementation 'io.dropwizard.metrics:metrics-jetty9'
implementatio
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r793724999
##
File path: solr/modules/hdfs/build.gradle
##
@@ -0,0 +1,81 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor lic
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r792962631
##
File path: solr/contrib/hdfs/build.gradle
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor lic
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r792131123
##
File path: solr/contrib/hdfs/src/java/org/apache/solr/update/HdfsUpdateLog.java
##
@@ -44,9 +44,7 @@
/**
* @lucene.experimental
Review comment:
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r792131051
##
File path:
solr/contrib/hdfs/src/java/org/apache/solr/store/hdfs/HdfsFileWriter.java
##
@@ -30,9 +30,7 @@
/**
* @lucene.experimental
Review comment:
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r792130743
##
File path:
solr/contrib/hdfs/src/java/org/apache/solr/store/hdfs/HdfsFileWriter.java
##
@@ -30,9 +30,7 @@
/**
* @lucene.experimental
Review comment:
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r792127370
##
File path:
solr/contrib/hdfs/src/java/org/apache/solr/core/backup/repository/HdfsBackupRepository.java
##
@@ -46,10 +46,6 @@
import org.slf4j.Logger;
imp
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r792126945
##
File path:
solr/test-framework/src/java/org/apache/solr/cloud/api/collections/AbstractCollectionsAPIDistributedZkTestBase.java
##
@@ -0,0 +1,645 @@
+/*
+ *
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r789009008
##
File path: solr/contrib/hdfs/build.gradle
##
@@ -0,0 +1,56 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor lic
risdenk commented on a change in pull request #324:
URL: https://github.com/apache/solr/pull/324#discussion_r789003197
##
File path:
solr/core/src/test/org/apache/solr/core/TestBackupRepositoryFactory.java
##
@@ -132,13 +131,7 @@ public void testRepositoryConfig() {
att
22 matches
Mail list logo
