[GitHub] [solr] stillalex commented on a diff in pull request #1898: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-09-08 Thread via GitHub
stillalex commented on code in PR #1898: URL: https://github.com/apache/solr/pull/1898#discussion_r1319873973 ## solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc: ## @@ -25,6 +25,17 @@ A sampled distributed tracing query request displayed in Jaeger UI

[GitHub] [solr] stillalex commented on a diff in pull request #1898: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-09-08 Thread via GitHub
stillalex commented on code in PR #1898: URL: https://github.com/apache/solr/pull/1898#discussion_r1319811898 ## solr/solr-ref-guide/modules/deployment-guide/pages/distributed-tracing.adoc: ## @@ -25,6 +25,17 @@ A sampled distributed tracing query request displayed in Jaeger UI

[GitHub] [solr] stillalex commented on a diff in pull request #1898: SOLR-15367 Convert "rid" functionality into a default Tracer

2023-09-08 Thread via GitHub
stillalex commented on code in PR #1898: URL: https://github.com/apache/solr/pull/1898#discussion_r1319810929 ## solr/solrj/src/java/org/apache/solr/common/params/CommonParams.java: ## @@ -277,9 +279,23 @@ public static EchoParamStyle get(String v) { * Defaults to 'false' if