[GitHub] [solr] stillalex commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

stillalex commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1341988276 ## solr/core/src/java/org/apache/solr/cli/DeleteTool.java: ## @@ -102,13 +110,18 @@ public void runImpl(CommandLine cli) throws Exception { } protected void dele

[GitHub] [solr] stillalex commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

stillalex commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1341988216 ## solr/core/src/java/org/apache/solr/cli/ExportTool.java: ## @@ -202,7 +209,16 @@ DocsSink getSink() { abstract void exportDocs() throws Exception; void fet

[GitHub] [solr] stillalex commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

stillalex commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1341987768 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -1311,6 +1311,22 @@ public Builder withProxyConfiguration( this.proxyIsSecure

[GitHub] [solr] stillalex commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

stillalex commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1341987768 ## solr/solrj/src/java/org/apache/solr/client/solrj/impl/Http2SolrClient.java: ## @@ -1311,6 +1311,22 @@ public Builder withProxyConfiguration( this.proxyIsSecure

[GitHub] [solr] stillalex commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

stillalex commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1341986862 ## solr/core/src/java/org/apache/solr/cli/ApiTool.java: ## @@ -57,27 +57,28 @@ public List getOptions() { .hasArg() .required(true)

[GitHub] [solr] stillalex commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

stillalex commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1341987057 ## solr/core/src/java/org/apache/solr/cli/PackageTool.java: ## @@ -342,6 +341,14 @@ public List getOptions() { .required(false) .desc("Don't pr

[GitHub] [solr] stillalex commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

stillalex commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1341987000 ## solr/core/src/java/org/apache/solr/cli/AssertTool.java: ## @@ -123,6 +123,14 @@ public List getOptions() { Option.builder("e") .desc("Return an

[GitHub] [solr] stillalex commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

stillalex commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1341986862 ## solr/core/src/java/org/apache/solr/cli/ApiTool.java: ## @@ -57,27 +57,28 @@ public List getOptions() { .hasArg() .required(true)

[GitHub] [solr] stillalex commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

stillalex commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1336351310 ## solr/core/src/java/org/apache/solr/cli/DeleteTool.java: ## @@ -102,13 +110,18 @@ public void runImpl(CommandLine cli) throws Exception { } protected void dele

[GitHub] [solr] stillalex commented on a diff in pull request #1954: SOLR-14496: Add Basic Auth support to SolrCLI

stillalex commented on code in PR #1954: URL: https://github.com/apache/solr/pull/1954#discussion_r1336349434 ## solr/core/src/java/org/apache/solr/cli/DeleteTool.java: ## @@ -92,7 +94,13 @@ public void runImpl(CommandLine cli) throws Exception { SolrCLI.raiseLogLevelUnless