[GitHub] [solr] stillalex commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

stillalex commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336243193 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Soft

[GitHub] [solr] stillalex commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

stillalex commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336235696 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Soft

[GitHub] [solr] stillalex commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

stillalex commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336232221 ## solr/prometheus-exporter/src/test-files/solr/security.json: ## Review Comment: I see a `metrics-read` permission here. is this what you were hinting to? like ma

[GitHub] [solr] stillalex commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

stillalex commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336232221 ## solr/prometheus-exporter/src/test-files/solr/security.json: ## Review Comment: I see a `metrics-read` here. is this what you were hinting to? -- This is an a

[GitHub] [solr] stillalex commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

stillalex commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336221018 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Soft

[GitHub] [solr] stillalex commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

stillalex commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336216692 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java: ## @@ -96,6 +96,20 @@ public class SolrExporter { + ARG_NUM_THREAD

[GitHub] [solr] stillalex commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

stillalex commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336215717 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Soft

[GitHub] [solr] stillalex commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

stillalex commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336130056 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrClientFactory.java: ## Review Comment: it wires the existing builders with params passe

[GitHub] [solr] stillalex commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

stillalex commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336129061 ## solr/prometheus-exporter/src/java/org/apache/solr/prometheus/exporter/SolrExporter.java: ## @@ -242,6 +256,22 @@ public static void main(String[] args) { .se

[GitHub] [solr] stillalex commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

stillalex commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336128385 ## solr/prometheus-exporter/src/test-files/solr/security.json: ## Review Comment: similar to the kubernetes setup (I think)? sounds like a good idea -- This is

[GitHub] [solr] stillalex commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

stillalex commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336127313 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Soft

[GitHub] [solr] stillalex commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

stillalex commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336126560 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperBasicAuthTest.java: ## @@ -0,0 +1,112 @@ +/* + * Licensed to the Apache Soft

[GitHub] [solr] stillalex commented on a diff in pull request #1957: SOLR-16980 Connect to SOLR standalone with basic authentication

stillalex commented on code in PR #1957: URL: https://github.com/apache/solr/pull/1957#discussion_r1336125777 ## solr/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrStandaloneScraperTest.java: ## @@ -47,42 +54,45 @@ public class SolrStandaloneScraperTest ext