[GitHub] [solr] stillalex commented on pull request #1779: SOLR-16859 Missing Proxy support for Http2SolrClient

2023-08-16 Thread via GitHub
stillalex commented on PR #1779: URL: https://github.com/apache/solr/pull/1779#issuecomment-1681033327 re. SSL testing. it is very difficult to setup the exiting proxy server for this test, I think it does not actually support SSL. I've sent an email to dev list to ask for more help. @risde

[GitHub] [solr] stillalex commented on pull request #1779: SOLR-16859 Missing Proxy support for Http2SolrClient

2023-08-11 Thread via GitHub
stillalex commented on PR #1779: URL: https://github.com/apache/solr/pull/1779#issuecomment-1675378877 minor update. test is failing when the SSL context is enabled, which I did not know it can happen. I spent a bit of time on this and I can not figure out how to get the Solr SocketProxy to

[GitHub] [solr] stillalex commented on pull request #1779: SOLR-16859 Missing Proxy support for Http2SolrClient

2023-08-10 Thread via GitHub
stillalex commented on PR #1779: URL: https://github.com/apache/solr/pull/1779#issuecomment-1673926139 > I noticed that we have a test_ssl.bats test that exercises Solr. I wonder if extending those tests would help validate this fix? no, we'd need a proxy server for testing ...unless

[GitHub] [solr] stillalex commented on pull request #1779: SOLR-16859 Missing Proxy support for Http2SolrClient

2023-07-13 Thread via GitHub
stillalex commented on PR #1779: URL: https://github.com/apache/solr/pull/1779#issuecomment-1634549487 @epugh would you mind adding a bit more detail? how would a bats test help -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub