stillalex commented on PR #1780:
URL: https://github.com/apache/solr/pull/1780#issuecomment-1642390259
@dsmiley please let me know your thoughts on the latest version
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
stillalex commented on PR #1780:
URL: https://github.com/apache/solr/pull/1780#issuecomment-1640156939
as suggested, I moved the resource cleanup to `doFilter`. I also removed
another layer of try/catch blocks.
please review carefully, I did my best to not introduce any bugs but I might
stillalex commented on PR #1780:
URL: https://github.com/apache/solr/pull/1780#issuecomment-1639347134
Pushing a deeper refactoring. the cleanup will happen only once on a finally
block inside the main entry method. I think the null tracer codepath is dead
code, I don't see anywhere it coul
