stillalex commented on PR #1780: URL: https://github.com/apache/solr/pull/1780#issuecomment-1639347134
Pushing a deeper refactoring. the cleanup will happen only once on a finally block inside the main entry method. I think the null tracer codepath is dead code, I don't see anywhere it could be null unless there is a bad test setup (so test must be fixed instead). in some sense this is needing a major split to servlet filters (rate limiting, tracing), but until that happens at least the code is clearer wrt. resource cleanup. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org For additional commands, e-mail: issues-h...@solr.apache.org
