[GitHub] [solr] uschindler commented on pull request #449: SOLR-15838: Update Solr to use released Lucene 9.0.0

2021-12-08 Thread GitBox
uschindler commented on pull request #449: URL: https://github.com/apache/solr/pull/449#issuecomment-988640991 > Related question - Solr still uses Lucene's `Version` class several places. It's probably right when determining index compatibility, analysis components etc, but other places s

[GitHub] [solr] uschindler commented on pull request #449: SOLR-15838: Update Solr to use released Lucene 9.0.0

2021-12-07 Thread GitBox
uschindler commented on pull request #449: URL: https://github.com/apache/solr/pull/449#issuecomment-988168639 I also did some quick checks, Admin UI shows correct versions: ![image](https://user-images.githubusercontent.com/1005388/145085746-df8d3e4c-4739-4976-8e5f-d886609245de.png)

[GitHub] [solr] uschindler commented on pull request #449: SOLR-15838: Update Solr to use released Lucene 9.0.0

2021-12-07 Thread GitBox
uschindler commented on pull request #449: URL: https://github.com/apache/solr/pull/449#issuecomment-988113020 > Basically the NOTICE.txt file in the root folder of Lucene seems obsolete. I did not touch, it may be a separate issue. not fully obsolete, but all third party text can be

[GitHub] [solr] uschindler commented on pull request #449: SOLR-15838: Update Solr to use released Lucene 9.0.0

2021-12-07 Thread GitBox
uschindler commented on pull request #449: URL: https://github.com/apache/solr/pull/449#issuecomment-98887 In the PR I added checksums and License/Notice. Basically the NOTICE.txt file in the root folder of Lucene seems obsolete. I did not touch, it may be a separate issue. --

[GitHub] [solr] uschindler commented on pull request #449: SOLR-15838: Update Solr to use released Lucene 9.0.0

2021-12-07 Thread GitBox
uschindler commented on pull request #449: URL: https://github.com/apache/solr/pull/449#issuecomment-988090081 I am not 100% sure, but it looks like we do not add checksums and Licenses for Lucene's JAR files. IMHO we should now also add them to make sure all files are sane. Also Lucene is

[GitHub] [solr] uschindler commented on pull request #449: SOLR-15838: Update Solr to use released Lucene 9.0.0

2021-12-07 Thread GitBox
uschindler commented on pull request #449: URL: https://github.com/apache/solr/pull/449#issuecomment-988083616 Adding @jpountz as reviewer, because he did the Lucene 9.0 release to Maven central. To me it looks like all Maven artifacts resolve correctly from Maven central. -- This

[GitHub] [solr] uschindler commented on pull request #449: SOLR-15838: Update Solr to use released Lucene 9.0.0

2021-12-07 Thread GitBox
uschindler commented on pull request #449: URL: https://github.com/apache/solr/pull/449#issuecomment-988082656 I left the nightlies repository code commented out, so we can use the mechanism again in the future. -- This is an automated message from the Apache Git Service. To respond to t