[GitHub] [solr-operator] thelabdude commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690688351 ## File path: controllers/controller_utils_test.go ## @@ -190,14 +190,6 @@ func verifyUserSuppliedTLSConfig(t *testing.T, tls *solr.SolrTLSOptions

[GitHub] [solr-operator] thelabdude commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690705380 ## File path: controllers/util/prometheus_exporter_util.go ## @@ -46,17 +45,9 @@ type SolrConnectionInfo struct { StandaloneAddress st

[GitHub] [solr-operator] thelabdude commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690704848 ## File path: controllers/solrprometheusexporter_controller.go ## @@ -197,28 +197,30 @@ func (r *SolrPrometheusExporterReconciler) Reconcile(req c

[GitHub] [solr-operator] thelabdude commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690703569 ## File path: controllers/solrcloud_controller.go ## @@ -364,51 +364,57 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request) (ctrl.Result,

[GitHub] [solr-operator] thelabdude commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690697734 ## File path: controllers/util/solr_util.go ## @@ -601,6 +552,11 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud, solrCloudStatus *solr.Solr

[GitHub] [solr-operator] thelabdude commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690689552 ## File path: controllers/solrcloud_controller_tls_test.go ## @@ -126,7 +126,6 @@ func TestMountedTLSDir(t *testing.T) { mountedDir := &sol

[GitHub] [solr-operator] thelabdude commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690688691 ## File path: controllers/solrcloud_controller.go ## @@ -215,15 +215,15 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request) (ctrl.Result,

[GitHub] [solr-operator] thelabdude commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690688351 ## File path: controllers/controller_utils_test.go ## @@ -190,14 +190,6 @@ func verifyUserSuppliedTLSConfig(t *testing.T, tls *solr.SolrTLSOptions