Re: [PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension [solr]

2024-03-23 Thread via GitHub
mkhludnev commented on PR #2315: URL: https://github.com/apache/solr/pull/2315#issuecomment-2016431220 backporting #2369 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To

Re: [PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension [solr]

2024-03-23 Thread via GitHub
mkhludnev merged PR #2315: URL: https://github.com/apache/solr/pull/2315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

Re: [PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension [solr]

2024-03-22 Thread via GitHub
dsmiley commented on PR #2315: URL: https://github.com/apache/solr/pull/2315#issuecomment-2016352747 I think small internal refactors like this don't need a CHANGES.txt entry; I don't want contributors to feel there is an extra burden on them to do more digital paperwork. -- This is an a

Re: [PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension [solr]

2024-03-06 Thread via GitHub
mkhludnev commented on PR #2315: URL: https://github.com/apache/solr/pull/2315#issuecomment-1980348868 @tboeghk please add CHANGES or merge https://github.com/otto-de/solr/pull/1 Thanks for your contribution. -- This is an automated message from the Apache Git Service. To respond to t

Re: [PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension [solr]

2024-02-28 Thread via GitHub
tboeghk commented on code in PR #2315: URL: https://github.com/apache/solr/pull/2315#discussion_r1505675887 ## solr/core/src/java/org/apache/solr/response/transform/ValueAugmenterFactory.java: ## @@ -72,7 +72,7 @@ public DocTransformer create(String field, SolrParams params, So

Re: [PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension [solr]

2024-02-28 Thread via GitHub
cpoerschke commented on code in PR #2315: URL: https://github.com/apache/solr/pull/2315#discussion_r1505661209 ## solr/core/src/java/org/apache/solr/response/transform/ValueAugmenterFactory.java: ## @@ -72,7 +72,7 @@ public DocTransformer create(String field, SolrParams params,

Re: [PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension [solr]

2024-02-28 Thread via GitHub
mkhludnev commented on PR #2315: URL: https://github.com/apache/solr/pull/2315#issuecomment-1968545878 Usually we add some _just compile_ test to make sure public won't go in future. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to G

Re: [PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension [solr]

2024-02-27 Thread via GitHub
tboeghk closed pull request #2310: [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension URL: https://github.com/apache/solr/pull/2310 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension [solr]

2024-02-27 Thread via GitHub
tboeghk commented on PR #2310: URL: https://github.com/apache/solr/pull/2310#issuecomment-1968408049 Wrong feature branch, superseeded by #2315 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension [solr]

2024-02-27 Thread via GitHub
tboeghk opened a new pull request, #2315: URL: https://github.com/apache/solr/pull/2315 https://issues.apache.org/jira/browse/SOLR-17185 # Description Opening up the class `ValueAugmenter` in the `ValueAugmenterFactory` to `public` access level eases the creation of custom docu

[PR] [SOLR-17185] Open ValueAugmenter in ValueAugmenterFactory for extension [solr]

2024-02-27 Thread via GitHub
tboeghk opened a new pull request, #2310: URL: https://github.com/apache/solr/pull/2310 https://issues.apache.org/jira/browse/SOLR-17185 # Description Opening up the class `ValueAugmenter` in the `ValueAugmenterFactory` to `public` access level eases the creation of custom docu