epugh commented on PR #2381:
URL: https://github.com/apache/solr/pull/2381#issuecomment-2282233785
Okay, pending all the tests passing, I think this is ready for review and
potentially merging!!!
--
This is an automated message from the Apache Git Service.
To respond to the message, pleas
epugh commented on PR #2381:
URL: https://github.com/apache/solr/pull/2381#issuecomment-2282214655
> Should we update documentation too and add any missing information, or
should this be handled in a separate ticket instead?
>
> Looking forward to the HDFS related tests, since I am al
epugh commented on code in PR #2381:
URL: https://github.com/apache/solr/pull/2381#discussion_r1712676449
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -310,6 +310,12 @@ private static Tool newTool(String toolType) throws
Exception {
else if ("post".equals(
epugh commented on code in PR #2381:
URL: https://github.com/apache/solr/pull/2381#discussion_r1712676384
##
solr/modules/hdfs/src/java/org/apache/solr/hdfs/snapshots/PrepareSnapshotExportCLI.java:
##
@@ -0,0 +1,342 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) und
epugh commented on code in PR #2381:
URL: https://github.com/apache/solr/pull/2381#discussion_r1712672798
##
solr/core/src/java/org/apache/solr/cli/SnapshotPrepareExportTool.java:
##
@@ -0,0 +1,322 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ *
epugh commented on code in PR #2381:
URL: https://github.com/apache/solr/pull/2381#discussion_r1712640972
##
solr/modules/hdfs/bin/prepare-snapshot-export.sh:
##
@@ -0,0 +1,176 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contr
malliaridis commented on code in PR #2381:
URL: https://github.com/apache/solr/pull/2381#discussion_r1705590402
##
solr/modules/hdfs/bin/prepare-snapshot-export.sh:
##
@@ -0,0 +1,176 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+#
epugh commented on PR #2381:
URL: https://github.com/apache/solr/pull/2381#issuecomment-2106274272
Okay, at this point I might need some help, as I want to move the remaining
shell script that is HDFS specific into the hdfs module in it's own `/bin` and
need maybe some gradle magic to bring
epugh opened a new pull request, #2381:
URL: https://github.com/apache/solr/pull/2381
https://issues.apache.org/jira/browse/SOLR-17180
# Description
Migrating some commands that are nested in the rather unknown
`snapshotscli.sh` into `bin/solr` as commands.
#
