AndreyBozhko commented on PR #2356:
URL: https://github.com/apache/solr/pull/2356#issuecomment-2015325094
Sure @epugh - here's the PR: https://github.com/apache/solr/pull/2365
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub an
epugh commented on PR #2356:
URL: https://github.com/apache/solr/pull/2356#issuecomment-2014943816
This is really great @AndreyBozhko. Would you be interested in doing the
follow up PR to remove the deprecated code from 10x? And add an entry into
the major changes for 10x release notes?
epugh merged PR #2356:
URL: https://github.com/apache/solr/pull/2356
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #2356:
URL: https://github.com/apache/solr/pull/2356#issuecomment-2014932225
> Thanks for this. I'm actually a little surprised we don't have a well
defined approach for sharing deprecation messages in logs..
I poked about and yeah, some things have helpers, but
epugh commented on PR #2356:
URL: https://github.com/apache/solr/pull/2356#issuecomment-2012293378
Thanks for this. I'm actually a little surprised we don't have a well
defined approach for sharing deprecation messages in logs..
--
This is an automated message from the Apache Git Ser
AndreyBozhko commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1533183040
##
solr/core/src/java/org/apache/solr/spelling/WordBreakSolrSpellChecker.java:
##
@@ -62,15 +62,15 @@ public class WordBreakSolrSpellChecker extends
SolrSpellChecker
epugh commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1532281318
##
solr/core/src/java/org/apache/solr/spelling/WordBreakSolrSpellChecker.java:
##
@@ -62,15 +62,15 @@ public class WordBreakSolrSpellChecker extends
SolrSpellChecker {
p
cpoerschke commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1531943470
##
solr/core/src/java/org/apache/solr/spelling/WordBreakSolrSpellChecker.java:
##
@@ -62,15 +62,15 @@ public class WordBreakSolrSpellChecker extends
SolrSpellChecker {
AndreyBozhko commented on PR #2356:
URL: https://github.com/apache/solr/pull/2356#issuecomment-2007853365
Thanks for the review @epugh, please feel free to merge this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
epugh commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530850952
##
solr/core/src/java/org/apache/solr/spelling/AbstractLuceneSpellChecker.java:
##
@@ -81,7 +81,6 @@ public abstract class AbstractLuceneSpellChecker extends
SolrSpellCheck
AndreyBozhko commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530738178
##
solr/solr-ref-guide/modules/query-guide/pages/spell-checking.adoc:
##
@@ -530,4 +597,4 @@ For example:
http://localhost:8983/solr/techproducts/spell?spellcheck=t
AndreyBozhko commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530737343
##
solr/core/src/java/org/apache/solr/spelling/AbstractLuceneSpellChecker.java:
##
@@ -81,7 +81,6 @@ public abstract class AbstractLuceneSpellChecker extends
SolrSpe
epugh commented on PR #2356:
URL: https://github.com/apache/solr/pull/2356#issuecomment-2007595741
Tests pass!, let me know if you are ready for this to be merged!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
UR
epugh commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530600667
##
solr/solr-ref-guide/modules/query-guide/pages/spell-checking.adoc:
##
@@ -530,4 +597,4 @@ For example:
http://localhost:8983/solr/techproducts/spell?spellcheck=true&spe
epugh commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530599052
##
solr/core/src/java/org/apache/solr/spelling/AbstractLuceneSpellChecker.java:
##
@@ -81,7 +81,6 @@ public abstract class AbstractLuceneSpellChecker extends
SolrSpellCheck
AndreyBozhko commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530571928
##
solr/solr-ref-guide/modules/query-guide/pages/spell-checking.adoc:
##
@@ -530,4 +597,4 @@ For example:
http://localhost:8983/solr/techproducts/spell?spellcheck=t
AndreyBozhko commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530571928
##
solr/solr-ref-guide/modules/query-guide/pages/spell-checking.adoc:
##
@@ -530,4 +597,4 @@ For example:
http://localhost:8983/solr/techproducts/spell?spellcheck=t
epugh commented on PR #2356:
URL: https://github.com/apache/solr/pull/2356#issuecomment-2007367282
I'd love to review a PR that rationalizes the string/floats..We would
probably need to make the string version deprecated in 9x with a warning, and
then require just the float in 10x...
epugh commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530500951
##
solr/solr-ref-guide/modules/query-guide/pages/spell-checking.adoc:
##
@@ -25,26 +25,34 @@ The basis for these suggestions can be terms in a field in
Solr, externally cre
AndreyBozhko commented on code in PR #2356:
URL: https://github.com/apache/solr/pull/2356#discussion_r1530503936
##
solr/core/src/java/org/apache/solr/spelling/AbstractLuceneSpellChecker.java:
##
@@ -81,7 +81,6 @@ public abstract class AbstractLuceneSpellChecker extends
SolrSpe
AndreyBozhko opened a new pull request, #2356:
URL: https://github.com/apache/solr/pull/2356
https://issues.apache.org/jira/browse/SOLR-12089
# Description
Updated the Ref Guide about Spell Checking.
Also, I noticed some inconsistencies with how different spel
21 matches
Mail list logo
