Re: [PR] SOLR-14892 - shards.info with shards.tolerant can yield an empty key [solr]

2024-03-20 Thread via GitHub
dsmiley merged PR #286: URL: https://github.com/apache/solr/pull/286 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org

Re: [PR] SOLR-14892 - shards.info with shards.tolerant can yield an empty key [solr]

2024-03-18 Thread via GitHub
dsmiley commented on code in PR #286: URL: https://github.com/apache/solr/pull/286#discussion_r1529325382 ## solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] SOLR-14892 - shards.info with shards.tolerant can yield an empty key [solr]

2024-03-18 Thread via GitHub
dsmiley commented on code in PR #286: URL: https://github.com/apache/solr/pull/286#discussion_r1529324002 ## solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] SOLR-14892 - shards.info with shards.tolerant can yield an empty key [solr]

2024-03-18 Thread via GitHub
dsmiley commented on code in PR #286: URL: https://github.com/apache/solr/pull/286#discussion_r1529320577 ## solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] SOLR-14892 - shards.info with shards.tolerant can yield an empty key [solr]

2024-03-01 Thread via GitHub
mariemat commented on code in PR #286: URL: https://github.com/apache/solr/pull/286#discussion_r1509204591 ## solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java: ## @@ -984,8 +985,13 @@ protected void mergeIds(ResponseBuilder rb, ShardRequest sreq) {

Re: [PR] SOLR-14892 - shards.info with shards.tolerant can yield an empty key [solr]

2024-03-01 Thread via GitHub
dsmiley commented on code in PR #286: URL: https://github.com/apache/solr/pull/286#discussion_r1508510783 ## solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java: ## @@ -0,0 +1,87 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] SOLR-14892 - shards.info with shards.tolerant can yield an empty key [solr]

2024-02-29 Thread via GitHub
dsmiley commented on code in PR #286: URL: https://github.com/apache/solr/pull/286#discussion_r1508509359 ## solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] SOLR-14892 - shards.info with shards.tolerant can yield an empty key [solr]

2024-02-29 Thread via GitHub
psalagnac commented on code in PR #286: URL: https://github.com/apache/solr/pull/286#discussion_r1507250522 ## solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] SOLR-14892 - shards.info with shards.tolerant can yield an empty key [solr]

2024-02-29 Thread via GitHub
mariemat commented on code in PR #286: URL: https://github.com/apache/solr/pull/286#discussion_r1507246777 ## solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] SOLR-14892 - shards.info with shards.tolerant can yield an empty key [solr]

2024-02-28 Thread via GitHub
psalagnac commented on code in PR #286: URL: https://github.com/apache/solr/pull/286#discussion_r1506394384 ## solr/core/src/test/org/apache/solr/cloud/TestShardsInfoResponse.java: ## @@ -0,0 +1,84 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + *

Re: [PR] SOLR-14892 - shards.info with shards.tolerant can yield an empty key [solr]

2024-02-23 Thread via GitHub
github-actions[bot] commented on PR #286: URL: https://github.com/apache/solr/pull/286#issuecomment-1962154626 This PR had no visible activity in the past 60 days, labeling it as stale. Any new activity will remove the stale label. To attract more reviewers, please tag someone or notify the