epugh commented on PR #2540:
URL: https://github.com/apache/solr/pull/2540#issuecomment-2228845624
Good thoughts here @janhoy... I will leave this open for another day or
so, and then look to commit it. I will put out an appeal to the dev mailing
list when 9.7 release process starts
janhoy commented on PR #2540:
URL: https://github.com/apache/solr/pull/2540#issuecomment-2228245666
It’s the best I could do with my available time. I have NOT done a thorough
review of all options in all tools, just fixed the ones causing test failures.
The windows script lacks
epugh commented on PR #2540:
URL: https://github.com/apache/solr/pull/2540#issuecomment-2223108355
@janhoy, just looking again at this one, thanks for all the efforts
This looks like it's ready to commit? However before I click "Squash and
merge", I wanted to confirm with you!!
janhoy commented on code in PR #2540:
URL: https://github.com/apache/solr/pull/2540#discussion_r1663897957
##
solr/bin/solr.cmd:
##
@@ -246,11 +246,12 @@ set FIRST_ARG=%1
IF [%1]==[] goto usage
-IF "%1"=="-help" goto usage
-IF "%1"=="-usage" goto usage
-IF "%1"=="-h" goto
janhoy commented on code in PR #2540:
URL: https://github.com/apache/solr/pull/2540#discussion_r1663325672
##
solr/bin/solr.cmd:
##
@@ -246,11 +246,12 @@ set FIRST_ARG=%1
IF [%1]==[] goto usage
-IF "%1"=="-help" goto usage
-IF "%1"=="-usage" goto usage
-IF "%1"=="-h" goto
janhoy commented on code in PR #2540:
URL: https://github.com/apache/solr/pull/2540#discussion_r1663323040
##
solr/core/src/java/org/apache/solr/cli/SolrCLI.java:
##
@@ -435,11 +503,34 @@ public static boolean exceptionIsAuthRelated(Exception
exc) {
&&
epugh commented on code in PR #2540:
URL: https://github.com/apache/solr/pull/2540#discussion_r1663203570
##
solr/bin/solr.cmd:
##
@@ -246,11 +246,12 @@ set FIRST_ARG=%1
IF [%1]==[] goto usage
-IF "%1"=="-help" goto usage
-IF "%1"=="-usage" goto usage
-IF "%1"=="-h" goto
janhoy commented on PR #2540:
URL: https://github.com/apache/solr/pull/2540#issuecomment-2200147713
Getting there... All BATS tests now run, except these five:
```
not ok 32 solr help flag prints help in 1521ms
# (from function `assert_output' in file
janhoy commented on PR #2540:
URL: https://github.com/apache/solr/pull/2540#issuecomment-2200072644
Just fixed the `test_delete_collection.bats` test (Linux only).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
janhoy commented on code in PR #2540:
URL: https://github.com/apache/solr/pull/2540#discussion_r1660997239
##
solr/bin/solr:
##
@@ -982,31 +982,10 @@ else
exit
fi
+# status tool
if [ "$SCRIPT_CMD" == "status" ]; then
- if [ $# -gt 0 ]; then
-while true; do
-
janhoy commented on PR #2540:
URL: https://github.com/apache/solr/pull/2540#issuecomment-2197768183
Pushed some commits that at least makes Solr compile, and Fixes
HealthCheckToolTest.
I propose that we revert most .bats files to testing original (deprecated)
options, so we know the
11 matches
Mail list logo
