epugh merged PR #2593:
URL: https://github.com/apache/solr/pull/2593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@solr.apache.org
epugh commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2283777138
I believe the one failing unit test doesn't have anything to do with this
PR... This is ready for review and merging for 9.8!
--
This is an automated message from the Apache Git Service.
T
epugh commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2283730826
@rahulgoswami I updated the ref guide docs to cross link to an EXISTING
page for the upconfig/downconfig etc commands... Someday we'll reorg the ref
guide page to make the solrcli easier to
epugh commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2283703009
> Minor hiccup with solr zk --help command. "downconfig" is being displayed
twice. Submitted a tiny PR [#9](https://github.com/epugh/solr/pull/9).
Thanks! I also saw that the getUsage
epugh commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2283702202
> The only zk commands in the "solr zk --help" list that I have not been
able to test are "zk linkconfig" and "zk updateacls". I am not sure how these
are supposed to work/how to test them. Th
rahulgoswami commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2283192238
Minor hiccup with solr zk --help command. downconfig is being displayed
twice. Submitted a tiny PR.
...\packaging\build\dev\bin>solr zk --help
usage:
bin/solr zk ls [-r ] [
rahulgoswami commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2283186751
The only ones in the "solr zk --help" list that I have not been able to test
are "zk linkconfig" and "zk updateacls". I am not sure how are these supposed
to work/how to test them. The
rahulgoswami commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2283163304
Ok, so 6.iii) is a non-issue. The zk destination was missing a trailing '/'
and the zk cp command works fine for a file once the destination ends in a '/'
to indicate a parent znode.
epugh commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2277782852
@rahulgoswami thanks for your work, I was able to take what you did and
find a really nice refactoring on the `-r` option! Looking forward to the next
pr...
--
This is an automated messag
rahulgoswami commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2275072649
Submitted PR [#8](https://github.com/epugh/solr/pull/8) for issues 6 and 7.
6.iii is the only known open issue for now (File copy from local drive to zk
fails). Will tackle soon!
-
rahulgoswami commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2270460370
Submitted a PR for #4 against your branch. Will work on #6 and #7 tonight.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to Git
epugh commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2266690468
thanks for the testing..
1. Great to hear! That was an embarassing goof.
2. solr zk -help is no longer valid with our move to using the patterns -h
and --help. The docs in branch
rahulgoswami commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2266361235
Pulled in the latest changes on the branch SOLR-17359 and rebuilt.
1) zk downconfig has been fixed. upconfig worked for me the first time as
well.
2) solr zk -help now says
epugh commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2266315693
@rahulgoswami would you mind giving another pass through! I fixed a BUNCH
of bugs that you found, thank you for the testing. Plus, I updated this branch
with other changes that have happene
epugh commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2266313899
Okay, just fixed the downconfig and upconfig commands!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
epugh commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2266047490
I'm going to try out some of the examples on my Mac, just to see which are
OS specific and which are just part of the code movement not being right. I'll
also take a stab at adding more bats
rahulgoswami commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2264499307
Update from tests so far:
1) Commands that work as expected: solr zk ls , solr zk upconfig
Yet to test: zk rm, zk mv, zk mkroot, and some more of zk cp . That should
cover everythi
epugh commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2260400967
FYI, for folks tracking this, @rahulgoswami has started testing this PR on
Windows! Thanks @rahulgoswami ... He has validated `start`, `stop` and
`restart` and then will start digging into
epugh commented on PR #2593:
URL: https://github.com/apache/solr/pull/2593#issuecomment-2251203887
Okay, I changed the short cut "-s" to mean Solr URL instead of "shards".
however, in 9x "-s" means shards.. I am thinking that maybe I change allt he
tests to use "--shards", and when I back
epugh opened a new pull request, #2593:
URL: https://github.com/apache/solr/pull/2593
https://issues.apache.org/jira/browse/SOLR-17359
# Description
Migrate arg parsing for ZK commands into Java code
# Solution
Had to add a ZkToolHelp to handle some of the glob
20 matches
Mail list logo
