Re: [PR] SOLR-17006: Persist user-defined core properties [solr]

2023-10-16 Thread via GitHub
pvcnt commented on code in PR #1973: URL: https://github.com/apache/solr/pull/1973#discussion_r1360417880 ## solr/core/src/java/org/apache/solr/cloud/overseer/ClusterStateMutator.java: ## @@ -125,6 +125,13 @@ public ZkWriteCommand createCollection(ClusterState clusterState, ZkN

Re: [PR] Add support for mirroring plain commit requests. [solr-sandbox]

2023-10-16 Thread via GitHub
sigram merged PR #74: URL: https://github.com/apache/solr-sandbox/pull/74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache

[jira] [Created] (SOLR-17032) Jersey MessagingBinders class logs "A class javax.activation.DataSource for a default provider MessageBodyWriter was not found" warning on st

2023-10-16 Thread Shawn Heisey (Jira)
Shawn Heisey created SOLR-17032: --- Summary: Jersey MessagingBinders class logs "A class javax.activation.DataSource for a default provider MessageBodyWriter was not found" warning on startup Key: SOLR-17032 URL: htt

[jira] [Commented] (SOLR-17032) Jersey MessagingBinders class logs "A class javax.activation.DataSource for a default provider MessageBodyWriter was not found" warning on

2023-10-16 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775776#comment-17775776 ] Shawn Heisey commented on SOLR-17032: - I just built and installed 9.4.1-SNAPSHOT from

[jira] [Comment Edited] (SOLR-17032) Jersey MessagingBinders class logs "A class javax.activation.DataSource for a default provider MessageBodyWriter was not found" warnin

2023-10-16 Thread Shawn Heisey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775776#comment-17775776 ] Shawn Heisey edited comment on SOLR-17032 at 10/16/23 2:35 PM:

[jira] [Commented] (SOLR-17032) Jersey MessagingBinders class logs "A class javax.activation.DataSource for a default provider MessageBodyWriter was not found" warning on

2023-10-16 Thread Jason Gerlowski (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775789#comment-17775789 ] Jason Gerlowski commented on SOLR-17032: bq. Shouldn't branch_9x have been change

Re: [PR] SOLR-15782: Declare container-level plugins in solr.xml [solr]

2023-10-16 Thread via GitHub
pvcnt commented on code in PR #2016: URL: https://github.com/apache/solr/pull/2016#discussion_r1360821830 ## solr/core/src/test/org/apache/solr/api/ContainerPluginsRegistryTest.java: ## @@ -0,0 +1,105 @@ +package org.apache.solr.api; + +import java.nio.file.Path; +import java.ut

Re: [PR] SOLR-15782: Declare container-level plugins in solr.xml [solr]

2023-10-16 Thread via GitHub
pvcnt commented on code in PR #2016: URL: https://github.com/apache/solr/pull/2016#discussion_r1360822384 ## solr/core/src/test/org/apache/solr/core/TestSolrXml.java: ## @@ -78,6 +78,7 @@ public void testAllInfoPresent() throws IOException { assertEquals("info handler class

Re: [PR] SOLR-15782: Declare container-level plugins in solr.xml [solr]

2023-10-16 Thread via GitHub
pvcnt commented on code in PR #2016: URL: https://github.com/apache/solr/pull/2016#discussion_r1360822785 ## solr/solrj/src/java/org/apache/solr/client/solrj/request/beans/PluginMeta.java: ## @@ -48,6 +48,7 @@ public PluginMeta copy() { result.name = name; result.klass

[PR] SOLR-15782: Declare container-level plugins in solr.xml [solr]

2023-10-16 Thread via GitHub
pvcnt opened a new pull request, #2016: URL: https://github.com/apache/solr/pull/2016 https://issues.apache.org/jira/browse/SOLR-15782 # Description Currently, container-level plugins can only be declared installed via calls to /cluster/plugin APIs. In some situatio

[jira] [Commented] (SOLR-17032) Jersey MessagingBinders class logs "A class javax.activation.DataSource for a default provider MessageBodyWriter was not found" warning on

2023-10-16 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775797#comment-17775797 ] Eric Pugh commented on SOLR-17032: -- It's great that we finding ways to make Jersey/JAX-R

[jira] [Commented] (SOLR-15782) Configure custom node/container handlers in solr.xml

2023-10-16 Thread Vincent Primault (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775799#comment-17775799 ] Vincent Primault commented on SOLR-15782: - As I do need this feature, I gave it a

[jira] [Assigned] (SOLR-17027) Removing list.toArray calls with pre sized arrays

2023-10-16 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kevin Risden reassigned SOLR-17027: --- Assignee: Kevin Risden > Removing list.toArray calls with pre sized arrays > ---

[jira] [Commented] (SOLR-17027) Removing list.toArray calls with pre sized arrays

2023-10-16 Thread Kevin Risden (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775804#comment-17775804 ] Kevin Risden commented on SOLR-17027: - Just because I didn't know about it and Intell

Re: [PR] Update readme and upgrade notes [solr-operator]

2023-10-16 Thread via GitHub
HoustonPutman merged PR #643: URL: https://github.com/apache/solr-operator/pull/643 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@s

Re: [I] Support SolrNode autoscaling using the HPA [solr-operator]

2023-10-16 Thread via GitHub
HoustonPutman closed issue #536: Support SolrNode autoscaling using the HPA URL: https://github.com/apache/solr-operator/issues/536 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] Support SolrNode autoscaling using the HPA [solr-operator]

2023-10-16 Thread via GitHub
HoustonPutman commented on issue #536: URL: https://github.com/apache/solr-operator/issues/536#issuecomment-1764733230 This can be considered closed even though there is no managed HPA. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

[jira] [Commented] (SOLR-17027) Removing list.toArray calls with pre sized arrays

2023-10-16 Thread Uwe Schindler (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775830#comment-17775830 ] Uwe Schindler commented on SOLR-17027: -- bq. Just because I didn't know about it and

Re: [PR] SOLR-17030: Open TransactionLog for extension. [solr]

2023-10-16 Thread via GitHub
stillalex commented on code in PR #2012: URL: https://github.com/apache/solr/pull/2012#discussion_r1360949853 ## solr/core/src/java/org/apache/solr/update/TransactionLog.java: ## @@ -527,18 +562,18 @@ public Object lookup(long pos) { // make sure any unflushed buffer has

Re: [PR] SOLR-17030: Open TransactionLog for extension. [solr]

2023-10-16 Thread via GitHub
stillalex commented on code in PR #2012: URL: https://github.com/apache/solr/pull/2012#discussion_r1360954968 ## solr/core/src/java/org/apache/solr/update/TransactionLog.java: ## @@ -987,4 +1022,28 @@ public String toString() { + position(); } } + + /** Opens

Re: [PR] SOLR-17030: Open TransactionLog for extension. [solr]

2023-10-16 Thread via GitHub
stillalex commented on PR #2012: URL: https://github.com/apache/solr/pull/2012#issuecomment-1764878981 before merging could you run a few rounds of the CloudIndexing benchmark (https://github.com/apache/solr/blob/main/solr/benchmark/src/java/org/apache/solr/bench/index/CloudIndexing.java#L51

Re: [PR] SOLR-17006: Persist user-defined core properties [solr]

2023-10-16 Thread via GitHub
dsmiley commented on code in PR #1973: URL: https://github.com/apache/solr/pull/1973#discussion_r1361049769 ## solr/core/src/java/org/apache/solr/cloud/overseer/ClusterStateMutator.java: ## @@ -125,6 +125,13 @@ public ZkWriteCommand createCollection(ClusterState clusterState, Z

[jira] [Commented] (SOLR-16451) PRS: Don't fetch the prs state, while registering the collection watch

2023-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16451?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775871#comment-17775871 ] ASF subversion and git services commented on SOLR-16451: Commit 4

[jira] [Commented] (SOLR-16452) Keep prs state of latest version

2023-10-16 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-16452?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775872#comment-17775872 ] ASF subversion and git services commented on SOLR-16452: Commit 6

Re: [PR] SOLR-17006: Persist user-defined core properties [solr]

2023-10-16 Thread via GitHub
dsmiley commented on code in PR #1973: URL: https://github.com/apache/solr/pull/1973#discussion_r1361088912 ## solr/solr-ref-guide/modules/deployment-guide/pages/collection-management.adoc: ## @@ -250,6 +250,7 @@ If `true` the states of individual replicas will be maintained as

Re: [PR] SOLR-17006: Persist user-defined core properties [solr]

2023-10-16 Thread via GitHub
hossman commented on code in PR #1973: URL: https://github.com/apache/solr/pull/1973#discussion_r1361110252 ## solr/solr-ref-guide/modules/deployment-guide/pages/collection-management.adoc: ## @@ -250,6 +250,7 @@ If `true` the states of individual replicas will be maintained as

[jira] [Commented] (SOLR-15782) Configure custom node/container handlers in solr.xml

2023-10-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775882#comment-17775882 ] David Smiley commented on SOLR-15782: - Perhaps a brief bike-shed on naming here.  Can

Re: [PR] No Jira: some release script tweaks [solr]

2023-10-16 Thread via GitHub
stillalex merged PR #1976: URL: https://github.com/apache/solr/pull/1976 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@solr.apache.

[jira] [Commented] (SOLR-15782) Configure custom node/container handlers in solr.xml

2023-10-16 Thread Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775902#comment-17775902 ] Eric Pugh commented on SOLR-15782: -- I checked the Glossary to see if it was helpful, but

[jira] [Commented] (SOLR-15782) Configure custom node/container handlers in solr.xml

2023-10-16 Thread Jira
[ https://issues.apache.org/jira/browse/SOLR-15782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775938#comment-17775938 ] Jan Høydahl commented on SOLR-15782: +1 to using solr.xml for this. Thanks for pickin

[jira] [Commented] (SOLR-17032) Jersey MessagingBinders class logs "A class javax.activation.DataSource for a default provider MessageBodyWriter was not found" warning on

2023-10-16 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-17032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17775966#comment-17775966 ] David Smiley commented on SOLR-17032: - It'd be wonderful to have an integration test