[jira] [Commented] (WW-4241) Negative Integers not submitted when language is arabic

2014-02-25 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13912183#comment-13912183 ] Johno Crawford commented on WW-4241: Close as won't fix? The answer in stackoverflow sums

[jira] [Commented] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2014-01-02 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13860917#comment-13860917 ] Johno Crawford commented on WW-4263: Attaching patch proposal which uses thread-safe

[jira] [Updated] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2014-01-02 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4263: --- Attachment: WW-4263-lang.patch DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when

[jira] [Updated] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2014-01-02 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4263: --- Attachment: (was: WW-4263-lang.patch) DefaultHttpHeaders.compareIfModifiedSince() throws

[jira] [Updated] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2014-01-02 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4263: --- Attachment: WW-4263-lang.patch DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when

[jira] [Comment Edited] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-28 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857462#comment-13857462 ] Johno Crawford edited comment on WW-4263 at 12/28/13 11:21 AM: ---

[jira] [Updated] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-28 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4263: --- Attachment: (was: WW-4263-final.patch) DefaultHttpHeaders.compareIfModifiedSince() throws

[jira] [Updated] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-28 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4263: --- Attachment: WW-4263-final.patch DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when

[jira] [Comment Edited] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-28 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857722#comment-13857722 ] Johno Crawford edited comment on WW-4263 at 12/28/13 12:28 PM: ---

[jira] [Commented] (WW-4264) notifyDeveloper method logs error even when devMode is set false

2013-12-28 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858030#comment-13858030 ] Johno Crawford commented on WW-4264: Thanks Bruce! notifyDeveloper method logs error

[jira] [Commented] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-28 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858103#comment-13858103 ] Johno Crawford commented on WW-4263: safe-simple-date-format uses ThreadLocal :) what's

[jira] [Commented] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-28 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13858104#comment-13858104 ] Johno Crawford commented on WW-4263: Could also wait for commons-lang 3.2 then use

[jira] [Commented] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857462#comment-13857462 ] Johno Crawford commented on WW-4263: private static final SimpleDateFormat

[jira] [Commented] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857478#comment-13857478 ] Johno Crawford commented on WW-4263: As for locale.. can we parse that out of the request

[jira] [Comment Edited] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857462#comment-13857462 ] Johno Crawford edited comment on WW-4263 at 12/27/13 1:21 PM: --

[jira] [Comment Edited] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857478#comment-13857478 ] Johno Crawford edited comment on WW-4263 at 12/27/13 1:59 PM: --

[jira] [Updated] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4263: --- Attachment: WW-4263-1.patch How about something like this Yasser?

[jira] [Comment Edited] (WW-4264) notifyDeveloper method logs error even when devMode is set false

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857505#comment-13857505 ] Johno Crawford edited comment on WW-4264 at 12/27/13 2:33 PM: --

[jira] [Commented] (WW-4264) notifyDeveloper method logs error even when devMode is set false

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857505#comment-13857505 ] Johno Crawford commented on WW-4264: Yep. Java will always select the most suitable

[jira] [Comment Edited] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857498#comment-13857498 ] Johno Crawford edited comment on WW-4263 at 12/27/13 2:33 PM: --

[jira] [Updated] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4263: --- Attachment: WW-4263-2.patch DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the

[jira] [Commented] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857722#comment-13857722 ] Johno Crawford commented on WW-4263: New patch proposal

[jira] [Updated] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4263: --- Attachment: (was: WW-4263-1.patch) DefaultHttpHeaders.compareIfModifiedSince() throws

[jira] [Updated] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4263: --- Attachment: WW-4263-final.patch DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when

[jira] [Updated] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4263: --- Attachment: (was: WW-4263.patch) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException

[jira] [Updated] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4263: --- Attachment: (was: WW-4263-2.patch) DefaultHttpHeaders.compareIfModifiedSince() throws

[jira] [Comment Edited] (WW-4264) notifyDeveloper method logs error even when devMode is set false

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857505#comment-13857505 ] Johno Crawford edited comment on WW-4264 at 12/27/13 8:56 PM: --

[jira] [Comment Edited] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857722#comment-13857722 ] Johno Crawford edited comment on WW-4263 at 12/27/13 8:59 PM: --

[jira] [Issue Comment Deleted] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4263: --- Comment: was deleted (was: How about something like this Yasser?

[jira] [Commented] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857733#comment-13857733 ] Johno Crawford commented on WW-4263: Storing SimpleDateTime in ThreadLocal is perhaps

[jira] [Comment Edited] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857722#comment-13857722 ] Johno Crawford edited comment on WW-4263 at 12/27/13 9:05 PM: --

[jira] [Updated] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4263: --- Attachment: WW-4263-final.patch DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when

[jira] [Updated] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4263: --- Attachment: (was: WW-4263-final.patch) DefaultHttpHeaders.compareIfModifiedSince() throws

[jira] [Comment Edited] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857722#comment-13857722 ] Johno Crawford edited comment on WW-4263 at 12/27/13 11:35 PM: ---

[jira] [Commented] (WW-4264) notifyDeveloper method logs error even when devMode is set false

2013-12-26 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857161#comment-13857161 ] Johno Crawford commented on WW-4264: 2.3.16 / trunk. I can assure you it does not. The

[jira] [Updated] (WW-4264) notifyDeveloper method logs error even when devMode is set false

2013-12-26 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4264: --- Flags: Patch notifyDeveloper method logs error even when devMode is set false

[jira] [Updated] (WW-4264) notifyDeveloper method logs error even when devMode is set false

2013-12-26 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4264: --- Attachment: WW-4264.patch Attaching proposed patch to fix logging error (notifyDeveloper call in

[jira] [Comment Edited] (WW-4264) notifyDeveloper method logs error even when devMode is set false

2013-12-26 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857168#comment-13857168 ] Johno Crawford edited comment on WW-4264 at 12/26/13 11:58 PM: ---

[jira] [Commented] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-26 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13857179#comment-13857179 ] Johno Crawford commented on WW-4263: Bigger issue I see here is that we are using

[jira] [Updated] (WW-4263) DefaultHttpHeaders.compareIfModifiedSince() throws ParseException when the locale of the web browser is different to the server

2013-12-26 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4263: --- Attachment: WW-4263.patch Please find attached patch proposal, sdf static field removed as it is not

[jira] [Created] (WW-4264) notifyDeveloper method logs error even when devMode is set false

2013-12-23 Thread Johno Crawford (JIRA)
Johno Crawford created WW-4264: -- Summary: notifyDeveloper method logs error even when devMode is set false Key: WW-4264 URL: https://issues.apache.org/jira/browse/WW-4264 Project: Struts 2

[jira] [Commented] (WW-4044) executeResult=true generate an infinite loop wheen the result type is tiles3

2013-10-28 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13807515#comment-13807515 ] Johno Crawford commented on WW-4044: The second container =

[jira] [Commented] (WW-4066) Submitting form with parameters using brackets while devMode=true yields StringIndexOutOfBoundsException

2013-10-21 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13800668#comment-13800668 ] Johno Crawford commented on WW-4066: Are you able to give an ETA on 2.3.16 vote?

[jira] [Commented] (WW-4066) Submitting form with parameters using brackets while devMode=true yields StringIndexOutOfBoundsException

2013-10-19 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799824#comment-13799824 ] Johno Crawford commented on WW-4066: Sure, our apps are built on the original behaviour

[jira] [Updated] (WW-4066) Submitting form with parameters using brackets while devMode=true yields StringIndexOutOfBoundsException

2013-10-19 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4066: --- Attachment: ParametersInterceptor.java Submitting form with parameters using brackets while

[jira] [Comment Edited] (WW-4066) Submitting form with parameters using brackets while devMode=true yields StringIndexOutOfBoundsException

2013-10-19 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799824#comment-13799824 ] Johno Crawford edited comment on WW-4066 at 10/19/13 7:52 AM: --

[jira] [Comment Edited] (WW-4066) Submitting form with parameters using brackets while devMode=true yields StringIndexOutOfBoundsException

2013-10-19 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4066?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13799824#comment-13799824 ] Johno Crawford edited comment on WW-4066 at 10/19/13 12:02 PM: ---

[jira] [Updated] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-06-10 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4073: --- Attachment: disable_request_attribute_value_stack_lookup.patch Disable eval expressions and simple

[jira] [Updated] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-06-10 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4073: --- Attachment: (was: disable_simple_jstl_accessibility.patch) Disable eval expressions and simple

[jira] [Commented] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-06-10 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679379#comment-13679379 ] Johno Crawford commented on WW-4073: Attached new patch, diff available at

[jira] [Commented] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-06-10 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13679728#comment-13679728 ] Johno Crawford commented on WW-4073: [~maurizio.cucchiara] thanks!

[jira] [Commented] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-06-08 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13678839#comment-13678839 ] Johno Crawford commented on WW-4073: Two main reasons, security and performance. One of

[jira] [Comment Edited] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-06-08 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13678839#comment-13678839 ] Johno Crawford edited comment on WW-4073 at 6/8/13 8:04 PM: Two

[jira] [Commented] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-06-08 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13678852#comment-13678852 ] Johno Crawford commented on WW-4073: Any suggestions for renaming the constant?

[jira] [Commented] (WW-4094) struts.allowed.action.names inconsistency

2013-06-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13676728#comment-13676728 ] Johno Crawford commented on WW-4094: What do you think about logging this as debug by

[jira] [Updated] (WW-4093) Javadoc of RegexFieldValidator-annotation out-dated

2013-06-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4093: --- Attachment: javadoc_fix1.patch Javadoc of RegexFieldValidator-annotation out-dated

[jira] [Commented] (WW-4093) Javadoc of RegexFieldValidator-annotation out-dated

2013-06-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4093?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13676749#comment-13676749 ] Johno Crawford commented on WW-4093: Attached patch with corrected javadoc.

[jira] [Updated] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-06-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4073: --- Attachment: (was: d4c4e615bee50884838f1b8f928106378afa5de2.patch) Disable eval expressions and

[jira] [Updated] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-06-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4073: --- Attachment: (was: bbaab4e50fefb3be092071bf43c905ff05ce0383.patch) Disable eval expressions and

[jira] [Updated] (WW-4095) cleanupActionName should not compile regex every request

2013-06-06 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4095: --- Description: Please find attached patch proposal, cuts execution time in half. Run time compiled

[jira] [Commented] (WW-4090) Remote code execution via wildcard matching and double evaluation of OGNL expression

2013-06-05 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13676398#comment-13676398 ] Johno Crawford commented on WW-4090: Might be nice to compile the regex pattern in the

[jira] [Updated] (WW-4095) cleanupActionName should not compile regex for every request

2013-06-05 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4095: --- Attachment: compile_pattern_once.patch cleanupActionName should not compile regex for every

[jira] [Commented] (WW-4090) Remote code execution via wildcard matching and double evaluation of OGNL expression

2013-06-05 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4090?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13676440#comment-13676440 ] Johno Crawford commented on WW-4090: WW-4095 for compiling regex every request.

[jira] [Created] (WW-4095) cleanupActionName should not compile regex for every request

2013-06-05 Thread Johno Crawford (JIRA)
Johno Crawford created WW-4095: -- Summary: cleanupActionName should not compile regex for every request Key: WW-4095 URL: https://issues.apache.org/jira/browse/WW-4095 Project: Struts 2 Issue

[jira] [Updated] (WW-4095) cleanupActionName should not compile regex for every request

2013-06-05 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4095: --- Component/s: Core Actions cleanupActionName should not compile regex for every request

[jira] [Updated] (WW-4095) cleanupActionName should not compile regex every request

2013-06-05 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4095: --- Summary: cleanupActionName should not compile regex every request (was: cleanupActionName should not

[jira] [Comment Edited] (WW-4094) struts.allowed.action.names inconsistency

2013-06-05 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13676435#comment-13676435 ] Johno Crawford edited comment on WW-4094 at 6/5/13 10:35 PM: - We

[jira] [Comment Edited] (WW-4094) struts.allowed.action.names inconsistency

2013-06-05 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13676435#comment-13676435 ] Johno Crawford edited comment on WW-4094 at 6/5/13 10:35 PM: - We

[jira] [Comment Edited] (WW-4094) struts.allowed.action.names inconsistency

2013-06-05 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13676435#comment-13676435 ] Johno Crawford edited comment on WW-4094 at 6/5/13 10:36 PM: - We

[jira] [Comment Edited] (WW-4094) struts.allowed.action.names inconsistency

2013-06-05 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4094?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13676435#comment-13676435 ] Johno Crawford edited comment on WW-4094 at 6/5/13 10:59 PM: - We

[jira] [Updated] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-05-29 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4073: --- Attachment: disable_simple_jstl_accessibility.patch Disable eval expressions and simple JSTL

[jira] [Commented] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-05-29 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669280#comment-13669280 ] Johno Crawford commented on WW-4073: Confirming configuration works with new patch

[jira] [Commented] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-05-29 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669284#comment-13669284 ] Johno Crawford commented on WW-4073: Heads up [~lukaszlenart]! Disable

[jira] [Comment Edited] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-05-29 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13669284#comment-13669284 ] Johno Crawford edited comment on WW-4073 at 5/29/13 2:17 PM: -

[jira] [Created] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-05-21 Thread Johno Crawford (JIRA)
Johno Crawford created WW-4073: -- Summary: Disable eval expressions and simple JSTL accessibility Key: WW-4073 URL: https://issues.apache.org/jira/browse/WW-4073 Project: Struts 2 Issue Type:

[jira] [Updated] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-05-21 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4073: --- Attachment: 5.patch Disable eval expressions and simple JSTL accessibility

[jira] [Updated] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-05-21 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4073: --- Attachment: (was: 5.patch) Disable eval expressions and simple JSTL accessibility

[jira] [Updated] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-05-21 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4073: --- Attachment: bbaab4e50fefb3be092071bf43c905ff05ce0383.patch

[jira] [Updated] (WW-4073) Disable eval expressions and simple JSTL accessibility

2013-05-21 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4073?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4073: --- Description: afaik the simple JSTL accessibility is used only in jsp. Currently we have a hacky

[jira] [Commented] (WW-3973) WW-3866 overrides ParameterNameAware decision with interceptor settings

2013-05-17 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13660701#comment-13660701 ] Johno Crawford commented on WW-3973: Bit late to the party insert slowpoke pic, we would

[jira] [Commented] (WW-3973) WW-3866 overrides ParameterNameAware decision with interceptor settings

2013-05-17 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13660771#comment-13660771 ] Johno Crawford commented on WW-3973: Looks like I do not have permission to reopen the

[jira] [Created] (WW-4068) Refactor ParametersInterceptor so it's easier to extend

2013-05-17 Thread Johno Crawford (JIRA)
Johno Crawford created WW-4068: -- Summary: Refactor ParametersInterceptor so it's easier to extend Key: WW-4068 URL: https://issues.apache.org/jira/browse/WW-4068 Project: Struts 2 Issue Type:

[jira] [Updated] (WW-4068) Refactor ParametersInterceptor so it's easier to extend

2013-05-17 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-4068?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-4068: --- Attachment: extracted_method_for_extending.patch Refactor ParametersInterceptor so it's easier to

[jira] [Commented] (WW-3973) WW-3866 overrides ParameterNameAware decision with interceptor settings

2013-05-17 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-3973?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13660775#comment-13660775 ] Johno Crawford commented on WW-3973: [~lukaszlenart] new ticket and patch proposal over

[jira] [Issue Comment Edited] (WW-3655) Freemarker result loads request uri as template

2011-07-01 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13058598#comment-13058598 ] Johno Crawford edited comment on WW-3655 at 7/1/11 3:29 PM:

[jira] [Updated] (WW-3655) Freemarker result loads request uri as template

2011-06-30 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-3655: --- Description: If the template location is either null or an empty string FreemarkerResult will take

[jira] [Commented] (WW-3655) Freemarker result loads request uri as template

2011-06-28 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=13056786#comment-13056786 ] Johno Crawford commented on WW-3655: Would the action namespace be enough Lukasz? At

[jira] [Created] (WW-3655) Freemarker result loads request uri as template

2011-06-27 Thread Johno Crawford (JIRA)
Freemarker result loads request uri as template --- Key: WW-3655 URL: https://issues.apache.org/jira/browse/WW-3655 Project: Struts 2 Issue Type: Bug Affects Versions: 2.2.3

[jira] [Updated] (WW-3655) Freemarker result loads request uri as template

2011-06-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-3655: --- Description: If the template location is either null or an empty string FreemarkerResult will take

[jira] [Updated] (WW-3655) Freemarker result loads request uri as template

2011-06-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-3655: --- Description: If the template location is either null or an empty string FreemarkerResult will take

[jira] [Updated] (WW-3655) Freemarker result loads request uri as template

2011-06-27 Thread Johno Crawford (JIRA)
[ https://issues.apache.org/jira/browse/WW-3655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Johno Crawford updated WW-3655: --- Description: If the template location is either null or an empty string FreemarkerResult will take