[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-09-06 Thread Zhiyuan Yang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15468049#comment-15468049 ] Zhiyuan Yang commented on TEZ-3230: --- Thank you so much! Waited so long for this moment :-)

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-09-02 Thread Ming Ma (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15459809#comment-15459809 ] Ming Ma commented on TEZ-3230: -- +1. I will commit it earlier next week in case others have comm

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-31 Thread TezQA (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453893#comment-15453893 ] TezQA commented on TEZ-3230: {color:green}+1 overall{color}. Here are the results of testing th

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-31 Thread Zhiyuan Yang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453699#comment-15453699 ] Zhiyuan Yang commented on TEZ-3230: --- Cancel the patch due to a minor issue. Will submit it

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-31 Thread Zhiyuan Yang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453686#comment-15453686 ] Zhiyuan Yang commented on TEZ-3230: --- Thanks for your review! Already uploaded a new patch

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-31 Thread Ming Ma (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15453559#comment-15453559 ] Ming Ma commented on TEZ-3230: -- [~aplusplus] the latest patch looks good. One minor thing, in

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-29 Thread Zhiyuan Yang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15446618#comment-15446618 ] Zhiyuan Yang commented on TEZ-3230: --- [~mingma] Any chance to help review the latest patch?

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-23 Thread TezQA (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15432423#comment-15432423 ] TezQA commented on TEZ-3230: {color:green}+1 overall{color}. Here are the results of testing th

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-22 Thread TezQA (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430311#comment-15430311 ] TezQA commented on TEZ-3230: {color:green}+1 overall{color}. Here are the results of testing th

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-22 Thread Zhiyuan Yang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15430227#comment-15430227 ] Zhiyuan Yang commented on TEZ-3230: --- Everything is fixed in the new patch. The first and s

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-19 Thread Ming Ma (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15429095#comment-15429095 ] Ming Ma commented on TEZ-3230: -- Thanks [~aplusplus]. Couple more comments: bq. But since there

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-19 Thread Zhiyuan Yang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427796#comment-15427796 ] Zhiyuan Yang commented on TEZ-3230: --- Failed test is irrelevant. > Implement vertex manage

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-16 Thread TezQA (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15423749#comment-15423749 ] TezQA commented on TEZ-3230: {color:red}-1 overall{color}. Here are the results of testing the

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-15 Thread TezQA (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15421477#comment-15421477 ] TezQA commented on TEZ-3230: {color:red}-1 overall{color}. Here are the results of testing the

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-13 Thread Zhiyuan Yang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15420070#comment-15420070 ] Zhiyuan Yang commented on TEZ-3230: --- My bad...You are correct. Actually, here we can also

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-12 Thread Ming Ma (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419756#comment-15419756 ] Ming Ma commented on TEZ-3230: -- About "Only on demand routing" question, I am trying to underst

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-12 Thread Zhiyuan Yang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419700#comment-15419700 ] Zhiyuan Yang commented on TEZ-3230: --- bq. Does it mean the TezException message "Only on de

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-12 Thread TezQA (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419670#comment-15419670 ] TezQA commented on TEZ-3230: {color:red}-1 overall{color}. Here are the results of testing the

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-12 Thread Ming Ma (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419672#comment-15419672 ] Ming Ma commented on TEZ-3230: -- bq. For now, cDME is more prevalent given it won't consume too

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-12 Thread Zhiyuan Yang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419567#comment-15419567 ] Zhiyuan Yang commented on TEZ-3230: --- bq. CartesianProductEdgeManagerUnpartitioned#getNumDe

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-12 Thread Zhiyuan Yang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15419564#comment-15419564 ] Zhiyuan Yang commented on TEZ-3230: --- Thanks for reviewing the patch. bq. Does it support

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-11 Thread TezQA (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417769#comment-15417769 ] TezQA commented on TEZ-3230: {color:red}-1 overall{color}. Here are the results of testing the

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-09 Thread Ming Ma (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15413956#comment-15413956 ] Ming Ma commented on TEZ-3230: -- Couple suggestions w.r.t. EdgeManager: * {{CartesianProductEdg

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-08-05 Thread Ming Ma (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15409872#comment-15409872 ] Ming Ma commented on TEZ-3230: -- Thanks [~aplusplus]. Nice patch! Some comments are about design

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-07-27 Thread Zhiyuan Yang (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15396416#comment-15396416 ] Zhiyuan Yang commented on TEZ-3230: --- Fixed various warnings. Locality-based optimization,

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-06-21 Thread TezQA (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15342357#comment-15342357 ] TezQA commented on TEZ-3230: {color:red}-1 overall{color}. Here are the results of testing the

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-05-31 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15308873#comment-15308873 ] Hitesh Shah commented on TEZ-3230: -- Some comments on the patch: CartesianProductFilter

[jira] [Commented] (TEZ-3230) Implement vertex manager and edge manager of cartesian product edge

2016-05-16 Thread TezQA (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15285046#comment-15285046 ] TezQA commented on TEZ-3230: {color:red}-1 overall{color}. Here are the results of testing the