[jira] [Commented] (TEZ-3359) Add granular log levels for HistoryLoggingService.

2016-07-26 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394176#comment-15394176 ] Hitesh Shah commented on TEZ-3359: -- {color:green}+1 overall{color}. Here are the results o

[jira] [Commented] (TEZ-3359) Add granular log levels for HistoryLoggingService.

2016-07-26 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394053#comment-15394053 ] Hitesh Shah commented on TEZ-3359: -- https://builds.apache.org/job/PreCommit-Tez-Build/1882/

[jira] [Commented] (TEZ-3359) Add granular log levels for HistoryLoggingService.

2016-07-26 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15394052#comment-15394052 ] Hitesh Shah commented on TEZ-3359: -- +1. Will commit shortly after pre-commit comes back.

[jira] [Commented] (TEZ-3359) Add granular log levels for HistoryLoggingService.

2016-07-26 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393771#comment-15393771 ] Hitesh Shah commented on TEZ-3359: -- Need to investigate why pre commit is failing to add co

[jira] [Commented] (TEZ-3359) Add granular log levels for HistoryLoggingService.

2016-07-25 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15393231#comment-15393231 ] Hitesh Shah commented on TEZ-3359: -- Comments: {code} } else { 1063 // Valida

[jira] [Commented] (TEZ-3359) Add granular log levels for HistoryLoggingService.

2016-07-25 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392422#comment-15392422 ] Hitesh Shah commented on TEZ-3359: -- Comments: {code} // Copy historyLogLevel from tezCon

[jira] [Commented] (TEZ-3359) Add granular log levels for HistoryLoggingService.

2016-07-25 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392327#comment-15392327 ] Hitesh Shah commented on TEZ-3359: -- Patch mostly looks good. Comments: {code} if (!this

[jira] [Commented] (TEZ-3359) Add granular log levels for HistoryLoggingService.

2016-07-25 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15392296#comment-15392296 ] Hitesh Shah commented on TEZ-3359: -- For some reason, the pre-commit did not update jira:

[jira] [Commented] (TEZ-3359) Add granular log levels for HistoryLoggingService.

2016-07-22 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389988#comment-15389988 ] Hitesh Shah commented on TEZ-3359: -- Comments: - findbugs warning to be addressed. -

[jira] [Commented] (TEZ-3359) Add granular log levels for HistoryLoggingService.

2016-07-22 Thread TezQA (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15389925#comment-15389925 ] TezQA commented on TEZ-3359: {color:red}-1 overall{color}. Here are the results of testing the

[jira] [Commented] (TEZ-3359) Add granular log levels for HistoryLoggingService.

2016-07-21 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388510#comment-15388510 ] Hitesh Shah commented on TEZ-3359: -- Additional nit: other configs use "log.level" so the lo

[jira] [Commented] (TEZ-3359) Add granular log levels for HistoryLoggingService.

2016-07-21 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388490#comment-15388490 ] Hitesh Shah commented on TEZ-3359: -- Counters disabling can probably looked at in a follow-u

[jira] [Commented] (TEZ-3359) Add granular log levels for HistoryLoggingService.

2016-07-21 Thread Hitesh Shah (JIRA)
[ https://issues.apache.org/jira/browse/TEZ-3359?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15388454#comment-15388454 ] Hitesh Shah commented on TEZ-3359: -- Comments: - ConcurrentHashMap instead of HashMap?