[GitHub] trafficserver issue #801: TS-4664: Fix crash by unifying event handlers for ...

2016-07-17 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/801 I had to re-read this code to refresh my memory on how this works. I think that the invariant that the ``ProxyClientSession`` requires is that the API hooks are the first and last operations

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25613=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25613 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4664) Crash due to separate event handlers for IO events and plugin events for ClientSession

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4664?focusedWorklogId=25614=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25614 ] ASF GitHub Bot logged work on TS-4664: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread yatsukhnenko
Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/804 > What do you think of a future feature (config) to disable this Via checking completely? If I know there's not chance of a loop, why bother checking the Via header? @zwoop,

[jira] [Created] (TS-4670) Document SSL lifecycle hooks

2016-07-17 Thread James Peach (JIRA)
James Peach created TS-4670: --- Summary: Document SSL lifecycle hooks Key: TS-4670 URL: https://issues.apache.org/jira/browse/TS-4670 Project: Traffic Server Issue Type: Improvement

[jira] [Work logged] (TS-4583) CID 1021958: Null-pointer dereference after check

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4583?focusedWorklogId=25612=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25612 ] ASF GitHub Bot logged work on TS-4583: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #802: TS-4583: Null-pointer dereference after check

2016-07-17 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/802 I don't think this change is correct. It seems to me that the invariant is that ``server_session`` and ``server_entry`` should be NULL or non-NULL together. So if we call

[jira] [Commented] (TS-4669) HttpSM should use hsm_release_assert consistently

2016-07-17 Thread James Peach (JIRA)
[ https://issues.apache.org/jira/browse/TS-4669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381606#comment-15381606 ] James Peach commented on TS-4669: - Also, add {{hsm_assert}} to use instead of {{ink_assert}}. > HttpSM

[jira] [Created] (TS-4669) HttpSM should use hsm_release_assert consistently

2016-07-17 Thread James Peach (JIRA)
James Peach created TS-4669: --- Summary: HttpSM should use hsm_release_assert consistently Key: TS-4669 URL: https://issues.apache.org/jira/browse/TS-4669 Project: Traffic Server Issue Type: Bug

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

2016-07-17 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/805 This follows the pattern of the other APIs, but I notice the initialization is not thread safe. Shall we file a separate JIRA for that? --- If your project is set up for it, you can reply to

[jira] [Work logged] (TS-4595) Need a public API to get to RUNTIMEDIR

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4595?focusedWorklogId=25611=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25611 ] ASF GitHub Bot logged work on TS-4595: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4595) Need a public API to get to RUNTIMEDIR

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4595?focusedWorklogId=25610=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25610 ] ASF GitHub Bot logged work on TS-4595: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

2016-07-17 Thread jpeach
Github user jpeach commented on the issue: https://github.com/apache/trafficserver/pull/805 The documentation for this API family is in {{doc/developer-guide/api/functions/TSInstallDirGet.en.rst}}, Just mention the new API there. --- If your project is set up for it, you can reply

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/804 Did a quick test of this, and it looks good: Via: http/1.1 fedora.ogre.com[f6f5162d-5a02-4d10-ac6e-35aede508fe5] (ApacheTrafficServer/7.0.0) --- If your project is set up for it,

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25609=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25609 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25605=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25605 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25604=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25604 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/804 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/337/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/804 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/443/ for details. --- If your project is set up for it, you can reply to this email and have your

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25603=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25603 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/804 @yatsukhnenko What do you think of a future feature (config) to disable this Via checking completely? If I know there's not chance of a loop, why bother checking the Via header? I guess one

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25602=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25602 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/804 I checked the core on this FreeBSD build, and it seems completely unrelated to pretty much anything :). ``` (gdb) bt #0 0x in ?? () #1 0x006ec34a

[jira] [Commented] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread Leif Hedstrom (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15381480#comment-15381480 ] Leif Hedstrom commented on TS-4624: --- Any objections / concerns on landing this ? We should document this

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/804 I suspect this failed for other reasons, trying again [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25601=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25601 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4653?focusedWorklogId=25598=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25598 ] ASF GitHub Bot logged work on TS-4653: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4653?focusedWorklogId=25597=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25597 ] ASF GitHub Bot logged work on TS-4653: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #798: TS-4653: esi plugin - disable HTTP_COOKIE variable...

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/798 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/336/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver issue #798: TS-4653: esi plugin - disable HTTP_COOKIE variable...

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/798 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/442/ for details. --- If your project is set up for it, you can reply to this email and have your

[jira] [Work logged] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4653?focusedWorklogId=25596=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25596 ] ASF GitHub Bot logged work on TS-4653: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver pull request #798: TS-4653: esi plugin - disable HTTP_COOKIE v...

2016-07-17 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/798#discussion_r71086266 --- Diff: plugins/experimental/esi/esi.cc --- @@ -61,6 +61,7 @@ struct OptionInfo { }; static HandlerManager *gHandlerManager =

[GitHub] trafficserver issue #798: TS-4653: esi plugin - disable HTTP_COOKIE variable...

2016-07-17 Thread shukitchan
Github user shukitchan commented on the issue: https://github.com/apache/trafficserver/pull/798 @zwoop , i just did the cleanup. Good to merge? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not

[jira] [Work logged] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4653?focusedWorklogId=25595=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25595 ] ASF GitHub Bot logged work on TS-4653: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/804 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/335/ for details. --- If your project is set up for it, you can reply to this email and have your

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25592=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25592 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25593=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25593 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/804 FreeBSD build *failed*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/441/ for details. --- If your project is set up for it, you can reply to this email and have your

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25591=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25591 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/804 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] trafficserver pull request #804: TS-4624: use the server UUID in the Via hea...

2016-07-17 Thread yatsukhnenko
Github user yatsukhnenko commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/804#discussion_r71085622 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -750,12 +752,10 @@ HttpTransactHeaders::insert_via_header_in_request(HttpTransact::State *s,

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25590=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25590 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25586=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25586 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver pull request #804: TS-4624: use the server UUID in the Via hea...

2016-07-17 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/804#discussion_r71085418 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -750,12 +752,10 @@ HttpTransactHeaders::insert_via_header_in_request(HttpTransact::State *s, HTTPHd

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25581=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25581 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread yatsukhnenko
Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/804 Thanks for explaining about API usage --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25579=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25579 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver pull request #804: TS-4624: use the server UUID in the Via hea...

2016-07-17 Thread yatsukhnenko
Github user yatsukhnenko commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/804#discussion_r71084817 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -750,12 +752,10 @@ HttpTransactHeaders::insert_via_header_in_request(HttpTransact::State *s,

[jira] [Work logged] (TS-4595) Need a public API to get to RUNTIMEDIR

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4595?focusedWorklogId=25578=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25578 ] ASF GitHub Bot logged work on TS-4595: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

2016-07-17 Thread yatsukhnenko
Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/805 I added tests and created empty doc file(writing documentation is not a good idia considering my English level :shame:) --- If your project is set up for it, you can reply to this email

[jira] [Work logged] (TS-4583) CID 1021958: Null-pointer dereference after check

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4583?focusedWorklogId=25577=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25577 ] ASF GitHub Bot logged work on TS-4583: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #802: TS-4583: Null-pointer dereference after check

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/802 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/440/ for details. --- If your project is set up for it, you can reply to this email and have your

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25575=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25575 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/804 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/333/ for details. --- If your project is set up for it, you can reply to this email and have your

[jira] [Work logged] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4653?focusedWorklogId=25574=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25574 ] ASF GitHub Bot logged work on TS-4653: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver pull request #798: TS-4653: esi plugin - disable HTTP_COOKIE v...

2016-07-17 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/798#discussion_r71084383 --- Diff: plugins/experimental/esi/esi.cc --- @@ -61,6 +61,7 @@ struct OptionInfo { }; static HandlerManager *gHandlerManager = NULL;

[jira] [Work logged] (TS-4653) ESI plugin - $HTTP_COOKIE can leak important cookie info unintentionally

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4653?focusedWorklogId=25572=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25572 ] ASF GitHub Bot logged work on TS-4653: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25573=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25573 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/804 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/439/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request #798: TS-4653: esi plugin - disable HTTP_COOKIE v...

2016-07-17 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/798#discussion_r71084358 --- Diff: plugins/experimental/esi/lib/Variables.cc --- @@ -357,9 +357,26 @@ Variables::_parseCookieString(const char *str, int str_len)

[jira] [Work logged] (TS-4583) CID 1021958: Null-pointer dereference after check

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4583?focusedWorklogId=25571=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25571 ] ASF GitHub Bot logged work on TS-4583: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #802: TS-4583: Null-pointer dereference after check

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/802 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/334/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[jira] [Work logged] (TS-4583) CID 1021958: Null-pointer dereference after check

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4583?focusedWorklogId=25570=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25570 ] ASF GitHub Bot logged work on TS-4583: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #802: TS-4583: Null-pointer dereference after check

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/802 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[jira] [Work logged] (TS-4595) Need a public API to get to RUNTIMEDIR

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4595?focusedWorklogId=25568=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25568 ] ASF GitHub Bot logged work on TS-4595: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25569=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25569 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25567=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25567 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/805 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/438/ for details. --- If your project is set up for it, you can reply to this email and have your

[GitHub] trafficserver pull request #804: TS-4624: use the server UUID in the Via hea...

2016-07-17 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/804#discussion_r71084262 --- Diff: proxy/http/HttpTransactHeaders.cc --- @@ -750,12 +752,10 @@ HttpTransactHeaders::insert_via_header_in_request(HttpTransact::State *s, HTTPHd

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/805 Linux build *successful*! See https://ci.trafficserver.apache.org/job/Github-Linux/332/ for details. --- If your project is set up for it, you can reply to this email and have your

[jira] [Work logged] (TS-4595) Need a public API to get to RUNTIMEDIR

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4595?focusedWorklogId=25566=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25566 ] ASF GitHub Bot logged work on TS-4595: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/804 It's an inefficiency for starters (you go through a C-> C++ wrapper layer, for no good reason (remember, the public APIs are all C, whereas in the core, you can use all the C++ objects and

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25565=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25565 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[jira] [Updated] (TS-4595) Need a public API to get to RUNTIMEDIR

2016-07-17 Thread Leif Hedstrom (JIRA)
[ https://issues.apache.org/jira/browse/TS-4595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-4595: -- Assignee: Pavlo Yatsukhnenko > Need a public API to get to RUNTIMEDIR >

[jira] [Updated] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread Leif Hedstrom (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-4624: -- Assignee: Pavlo Yatsukhnenko > use the server UUID in the Via header >

[jira] [Updated] (TS-4595) Need a public API to get to RUNTIMEDIR

2016-07-17 Thread Leif Hedstrom (JIRA)
[ https://issues.apache.org/jira/browse/TS-4595?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-4595: -- Fix Version/s: (was: sometime) 7.0.0 > Need a public API to get to RUNTIMEDIR >

[jira] [Updated] (TS-4304) header_rewrite: There is no implementation of ConditionUrl::append_value for URL's

2016-07-17 Thread Leif Hedstrom (JIRA)
[ https://issues.apache.org/jira/browse/TS-4304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Leif Hedstrom updated TS-4304: -- Assignee: Pavlo Yatsukhnenko (was: Leif Hedstrom) > header_rewrite: There is no implementation of

[GitHub] trafficserver issue #806: TS-4304: implementation of ConditionUrl::append_va...

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/806 This is a good start, but it's missing a few things (I think at least, been a while since I looked at this). Look at how the eval() function is handling the different cases. But at least I

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25563=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25563 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4304) header_rewrite: There is no implementation of ConditionUrl::append_value for URL's

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4304?focusedWorklogId=25564=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25564 ] ASF GitHub Bot logged work on TS-4304: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread yatsukhnenko
Github user yatsukhnenko commented on the issue: https://github.com/apache/trafficserver/pull/804 Don't quite understand why public API can't be used in internal code, but ok, changed code to `Machine::instance()->uuid.getString()` --- If your project is set up for it, you can reply

[jira] [Work logged] (TS-4595) Need a public API to get to RUNTIMEDIR

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4595?focusedWorklogId=25562=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25562 ] ASF GitHub Bot logged work on TS-4595: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/805 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/805 Also, please add some tests to proxy/InkAPITest.cc, see how the existing tests are done for e.g. TSInstallDirGet. --- If your project is set up for it, you can reply to this email and have

[jira] [Work logged] (TS-4595) Need a public API to get to RUNTIMEDIR

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4595?focusedWorklogId=25558=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25558 ] ASF GitHub Bot logged work on TS-4595: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4595) Need a public API to get to RUNTIMEDIR

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4595?focusedWorklogId=25557=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25557 ] ASF GitHub Bot logged work on TS-4595: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #805: TS-4595: TSRuntimeDirGet

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/805 Cool. Can you add a documentation to this too? Either just add a new file, e.g. doc/developer-guide/api/functions/TSRuntimeDirGet.en.rst Or, my personal preference, merge

[jira] [Work logged] (TS-4624) use the server UUID in the Via header

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4624?focusedWorklogId=25556=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25556 ] ASF GitHub Bot logged work on TS-4624: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #804: TS-4624: use the server UUID in the Via header

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/804 Almost, but not quite. :) All APIs that are prefixed TS are the public APIs, and we don't use those in the internal code. Look at the log tags in logging that uses the internal APIs for the

[jira] [Work logged] (TS-4584) CID 1254818: Resource leak on file descriptor and allocated memory

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4584?focusedWorklogId=2=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-2 ] ASF GitHub Bot logged work on TS-4584: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #803: TS-4584: Resource leak, CID 1254818 and 1254809

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/803 Could we use the ats_scoped_obj here? Or some other smart ptr? I'm ok either way, but maybe we should encourage these smart pointer patterns? This might change memory management though

[jira] [Work logged] (TS-4304) header_rewrite: There is no implementation of ConditionUrl::append_value for URL's

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4304?focusedWorklogId=25554=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25554 ] ASF GitHub Bot logged work on TS-4304: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver pull request #806: TS-4304: implementation of ConditionUrl::ap...

2016-07-17 Thread yatsukhnenko
GitHub user yatsukhnenko opened a pull request: https://github.com/apache/trafficserver/pull/806 TS-4304: implementation of ConditionUrl::append_value You can merge this pull request into a Git repository by running: $ git pull https://github.com/yatsukhnenko/trafficserver

[jira] [Work logged] (TS-4584) CID 1254818: Resource leak on file descriptor and allocated memory

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4584?focusedWorklogId=25553=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25553 ] ASF GitHub Bot logged work on TS-4584: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #803: TS-4584: Resource leak, CID 1254818 and 1254809

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/803 FreeBSD build *successful*! See https://ci.trafficserver.apache.org/job/Github-FreeBSD/437/ for details. --- If your project is set up for it, you can reply to this email and have your

[jira] [Work logged] (TS-4584) CID 1254818: Resource leak on file descriptor and allocated memory

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4584?focusedWorklogId=25548=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25548 ] ASF GitHub Bot logged work on TS-4584: -- Author: ASF GitHub Bot Created

[jira] [Work logged] (TS-4584) CID 1254818: Resource leak on file descriptor and allocated memory

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4584?focusedWorklogId=25552=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25552 ] ASF GitHub Bot logged work on TS-4584: -- Author: ASF GitHub Bot Created

[GitHub] trafficserver issue #803: TS-4584: Resource leak, CID 1254818 and 1254809

2016-07-17 Thread atsci
Github user atsci commented on the issue: https://github.com/apache/trafficserver/pull/803 Linux build *failed*! See https://ci.trafficserver.apache.org/job/Github-Linux/331/ for details. --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #803: TS-4584: Resource leak, CID 1254818 and 1254809

2016-07-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/803 add to whitelist --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[jira] [Work logged] (TS-4584) CID 1254818: Resource leak on file descriptor and allocated memory

2016-07-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/TS-4584?focusedWorklogId=25551=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-25551 ] ASF GitHub Bot logged work on TS-4584: -- Author: ASF GitHub Bot Created

  1   2   >