Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/881
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/881
TS-4766: HTTP/2 frame corruption fix.
Moved handler reset into the do_complete_frame_read worker.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/866
Reviewing the bug comments Sudheer says "Yes, the external URLs should be
already encoded - however, internally, I see code that decodes the URL strings
(e.g. UrlMatcher::Match
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/866
@maskit, you list some lovely tricky cases. Abort encode on detect seems
like a reasonable approach too. Ideally, we just could declare that nothing
comes in already encoded
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/866#discussion_r74760880
--- Diff: proxy/logging/LogUtils.cc ---
@@ -359,6 +359,23 @@ LogUtils::escapify_url(Arena *arena, char *url, size_t
len_in, int *len_out, cha
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/866#discussion_r74760536
--- Diff: configure.ac ---
@@ -49,7 +49,7 @@ AM_INIT_AUTOMAKE([-Wall -Werror -Wno-portability
tar-ustar foreign no-installinf
AM_MAINTAINER_MODE
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/866
TS-2237: Fix double encoding of URLs in squid logs.
Resurrecting @sudheerv's fix. We've been running with this fix for over a
year. The logic to lookup the character in the bitfield array
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/865
TS-2987: Add new TS API TSHttpTxnPluginTagGet
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-2987
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/863
TS-4750: Fix Connection Leak warnings.
Removing secondary server address cache in HttpServerSession. Instead pull
that information from netvc. Use the same address to add server sessions
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/857
Looks good. Having an explicit disable_io_read/write might be nice. But
using NULL's to clear out the current io's does't seem too surprising.
---
If your project is set up for it, you
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/856
TS-4749: generate warning message when origin_max_connections limits
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/753
Looks good to me!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/853
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/853
The add1 version increments the reference count of the certificate, The
add0 version doesn't, so it effectively takes ownership of the reference you
pass in. From the man page
&quo
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/853
TS-4619: intermediate chain loading can miss certificates.
Made the changes @jpeach suggested in the bug. Tested with three deep
chains for rsa and ec (cert and two signers). Tested
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/846
Yes, we should land it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/849
TS-4729: Fix dead assignment.
Alternative to PR 847
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver ts-4729
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/847#discussion_r74317308
--- Diff: proxy/http2/Http2Stream.cc ---
@@ -509,7 +509,7 @@ Http2Stream::update_write_request(IOBufferReader
*buf_reader, int64_t write_len
Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/842
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/842#discussion_r74137828
--- Diff: proxy/http2/Http2ClientSession.h ---
@@ -243,6 +243,12 @@ class Http2ClientSession : public ProxyClientSession
return "h
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/846
Agreed that the assert doesn't mean much at this point.
current_reader (the HttpSM) may be NULL here or not. If the StateMachine
calls ua_session->release then it will not be n
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/842
Thanks @maskit. Looking at your debug messages and comparing it to my own,
I realized that I was not running completely up to date with master. Once got
the right version of the code, I
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/842
Thanks @maskit. I fixed the sense of inside_frame. Had made a name change
and flipped the sense of the bool. Thought I had fixed up the patch, after
testing on my build, but missed
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/831#discussion_r73763348
--- Diff: proxy/logging/LogCollationClientSM.cc ---
@@ -266,6 +266,9 @@ LogCollationClientSM::client_auth(int event, VIO * /*
vio ATS_UNUSED
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/842
TS-4717: Http2 stack explosion.
Added a common state_process_frame_read method to loop over reading frames
while there is data available. The original state_start_frame_read
Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/810
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/787
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/761
One benefit of the existing throttle approach is that there is a single
limit for both inbound and outbound connections. This allows you to create a
last ditch limit if the number
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/766
Yes, I'll go ahead and merge this up. Might consider backporting.
Stopping the period on the inactivty cop seems like a bad thing.
---
If your project is set up for it, you can reply
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/766#discussion_r72139223
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -1139,8 +1139,8 @@ UnixNetVConnection::mainEvent(int event, Event *e)
(write.vio.mutex
Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/800
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/801
We are running with this change locally. I've made some other changes on
this front too. I'll look at adding some asserts/warning messages to see
whether we are still encountering
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/801#discussion_r72125568
--- Diff: configure.ac ---
@@ -49,7 +49,7 @@ AM_INIT_AUTOMAKE([-Wall -Werror -Wno-portability
tar-ustar foreign no-installinf
AM_MAINTAINER_MODE
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/825
Looks good to me as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/825#discussion_r72122764
--- Diff: proxy/ProxyClientTransaction.h ---
@@ -211,7 +211,11 @@ class ProxyClientTransaction : public VConnection
virtual bool
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/810
TS-4671: Allow multicert line with action but no ssl_cert_name
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/shinrich/trafficserver
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/801
I'm not sure how to interpret your comment. I was seeing IO events
trailing during the SSN close handling. For example, it looks like I could
call the clearing do_io_write
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/801#discussion_r71157128
--- Diff: proxy/ProxyClientSession.cc ---
@@ -142,7 +141,9 @@ ProxyClientSession::do_api_callout(TSHttpHookID id)
this->api_current = N
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/801
TS-4664: Fix crash by unifying event handlers for ClientSession.
Combining the handlers for ClientSession so both IO events and plugin
events can be handled.
You can merge this pull
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/766#discussion_r71044678
--- Diff: iocore/net/UnixNetVConnection.cc ---
@@ -1139,8 +1139,8 @@ UnixNetVConnection::mainEvent(int event, Event *e)
(write.vio.mutex
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/800
TS-4663: ASAN crash. Scheduled event triggers after ClientSession deleted
Track scheduled event and cancel it when client session is deleted if it is
still hanging around.
You can merge
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/787
Pushed new version of the branch that does not include the schedule_event
and state_api_callout fixes. Filed TS-4663 and TS-4664 to track those issues.
Will try to reproduce those fixes
Github user shinrich commented on the issue:
https://github.com/apache/trafficserver/pull/787
It would be possible to break out the schedule_event clean up and the
state_api_callout into smaller patches. The rest of it really needs to be
together.I need to move onto another
301 - 343 of 343 matches
Mail list logo
