Github user shinrich closed the pull request at:
https://github.com/apache/trafficserver/pull/1088
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1088#discussion_r83086541
--- Diff: lib/ts/PriorityQueue.h ---
@@ -110,6 +110,12 @@ PriorityQueue::pop()
return;
}
+ // SKH - I suspect
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1088#discussion_r83084441
--- Diff: lib/ts/PriorityQueue.h ---
@@ -110,6 +110,12 @@ PriorityQueue::pop()
return;
}
+ // SKH - I suspect
Github user jpeach commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1088#discussion_r83048953
--- Diff: lib/ts/PriorityQueue.h ---
@@ -110,6 +110,12 @@ PriorityQueue::pop()
return;
}
+ // SKH - I suspect this
Github user shinrich commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1088#discussion_r82863899
--- Diff: lib/ts/PriorityQueue.h ---
@@ -110,6 +110,12 @@ PriorityQueue::pop()
return;
}
+ // SKH - I suspect
Github user PSUdaemon commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1088#discussion_r82852063
--- Diff: lib/ts/PriorityQueue.h ---
@@ -110,6 +110,12 @@ PriorityQueue::pop()
return;
}
+ // SKH - I suspect
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1088#discussion_r82836137
--- Diff: lib/ts/PriorityQueue.h ---
@@ -123,11 +129,18 @@ PriorityQueue::erase(PriorityQueueEntry
*entry)
return;
}
Github user bryancall commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1088#discussion_r82832753
--- Diff: lib/ts/PriorityQueue.h ---
@@ -123,11 +129,18 @@ PriorityQueue::erase(PriorityQueueEntry
*entry)
return;
}
GitHub user shinrich opened a pull request:
https://github.com/apache/trafficserver/pull/1088
TS-4915: Crash from hostdb in PriorityQueueLess
These changes have been running on my production box since leaving work
Monday night. Will keep an eye on it. Lower traffic overnight