[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-20 Thread shukitchan
Github user shukitchan closed the pull request at: https://github.com/apache/trafficserver/pull/1516 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-16 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r106500402 --- Diff: doc/admin-guide/plugins/combo_handler.en.rst --- @@ -83,3 +83,16 @@ results in these file paths being "reconstructed"::

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-16 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r106499461 --- Diff: doc/admin-guide/plugins/combo_handler.en.rst --- @@ -83,3 +83,16 @@ results in these file paths being "reconstructed"::

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-16 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r106484837 --- Diff: doc/admin-guide/plugins/combo_handler.en.rst --- @@ -83,3 +83,16 @@ results in these file paths being "reconstructed"::

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-07 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r104771989 --- Diff: plugins/esi/combo_handler.cc --- @@ -187,6 +207,94 @@ InterceptData::~InterceptData() } } +void

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-06 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r104584519 --- Diff: plugins/esi/combo_handler.cc --- @@ -187,6 +207,94 @@ InterceptData::~InterceptData() } } +void

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-02 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103987142 --- Diff: plugins/esi/combo_handler.cc --- @@ -136,6 +138,24 @@ struct InterceptData { ~InterceptData(); }; +/* + * This

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-02 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103965565 --- Diff: plugins/esi/combo_handler.cc --- @@ -136,6 +138,24 @@ struct InterceptData { ~InterceptData(); }; +/* + * This

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-02 Thread danobi
Github user danobi commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103965747 --- Diff: plugins/esi/combo_handler.cc --- @@ -136,6 +138,24 @@ struct InterceptData { ~InterceptData(); }; +/* + * This

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-03-01 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103611267 --- Diff: plugins/esi/combo_handler.cc --- @@ -187,6 +207,94 @@ InterceptData::~InterceptData() } } +void

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-02-28 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103610662 --- Diff: plugins/esi/combo_handler.cc --- @@ -136,6 +138,24 @@ struct InterceptData { ~InterceptData(); }; +/* + *

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-02-28 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103590528 --- Diff: plugins/esi/combo_handler.cc --- @@ -187,6 +207,94 @@ InterceptData::~InterceptData() } } +void

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-02-28 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103587579 --- Diff: plugins/esi/combo_handler.cc --- @@ -136,6 +138,24 @@ struct InterceptData { ~InterceptData(); }; +/* + * This

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-02-28 Thread shukitchan
Github user shukitchan commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1516#discussion_r103586416 --- Diff: plugins/esi/combo_handler.cc --- @@ -136,6 +138,24 @@ struct InterceptData { ~InterceptData(); }; +/* + * This

[GitHub] trafficserver pull request #1516: Implement Cache-Control: immutable handlin...

2017-02-28 Thread danobi
GitHub user danobi opened a pull request: https://github.com/apache/trafficserver/pull/1516 Implement Cache-Control: immutable handling This patch makes `combo_handler` correctly handle the presence of one or more immutable flags. In short, the combo response will be