[GitHub] trafficserver pull request #965: TS-4532: Static type checking for time.

2016-09-05 Thread SolidWallOfCode
Github user SolidWallOfCode closed the pull request at: https://github.com/apache/trafficserver/pull/965 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if

[GitHub] trafficserver pull request #965: TS-4532: Static type checking for time.

2016-09-05 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/965#discussion_r77548123 --- Diff: iocore/eventsystem/PQ-List.cc --- @@ -22,18 +22,31 @@ */ #include "P_EventSystem.h" +typedef

[GitHub] trafficserver pull request #965: TS-4532: Static type checking for time.

2016-09-05 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/965#discussion_r77541569 --- Diff: iocore/eventsystem/UnixEThread.cc --- @@ -149,10 +149,10 @@ EThread::process_event(Event *e, int calling_code)

[GitHub] trafficserver pull request #965: TS-4532: Static type checking for time.

2016-09-05 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/965#discussion_r77541520 --- Diff: iocore/eventsystem/UnixEThread.cc --- @@ -149,10 +149,10 @@ EThread::process_event(Event *e, int calling_code)

[GitHub] trafficserver pull request #965: TS-4532: Static type checking for time.

2016-09-05 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/965#discussion_r77540649 --- Diff: iocore/eventsystem/I_Thread.h --- @@ -168,21 +168,21 @@ class Thread @note This also updates the cached time.

[GitHub] trafficserver pull request #965: TS-4532: Static type checking for time.

2016-09-05 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/965#discussion_r77540451 --- Diff: iocore/eventsystem/I_Lock.h --- @@ -241,7 +241,7 @@ class ProxyMutex : public RefCountObj thread_holding = NULL;

[GitHub] trafficserver pull request #965: TS-4532: Static type checking for time.

2016-09-05 Thread SolidWallOfCode
Github user SolidWallOfCode commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/965#discussion_r77540321 --- Diff: iocore/eventsystem/I_Lock.h --- @@ -28,7 +28,7 @@ #include "ts/Diags.h" #include "I_Thread.h" -#define

[GitHub] trafficserver pull request #965: TS-4532: Static type checking for time.

2016-09-05 Thread SolidWallOfCode
GitHub user SolidWallOfCode opened a pull request: https://github.com/apache/trafficserver/pull/965 TS-4532: Static type checking for time. Rough first pass just for iocore/eventsystem to get a feel for the changes. THIS WILL NOT RUN - it's just an experiment to be verified