Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1357
This has to go into 7.1.0 as well, since we already landed previous tries
:).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1355
I'm marking this for 7.1.0, since it's mostly benign, and generally useful.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1364
Is this a 7.1.0 back port candidate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1366
7.1.0 candidate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1350
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1350
Seems FreeBSD / clang is finicky on one of the strings.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1355
Question: Why is this PR also modifying the Debian layout? That seems
slightly non-intuitive considering the Summary from the PR (OpenBSD).
---
If your project is set up for it, you can reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1328
Are you guys comfortable with cherry-picking this to 7.1.0?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1357
@shinrich @SolidWallOfCode Is this landing for 7.1.x?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1350
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1303
Status on this? is thing going to land for 7.1.x ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1382
Ah wth, it seems safe, cherry-picking.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1378
I saw what happened, the reverts makes sense now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1313
You need this for 7.1.x ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1382
You want this for 7.1.x?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1313
Cherry-picked to 7.1.x
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1383
This fixes build problems when using non-standard OpenSSL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zwoop/trafficserver Fix40310af
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1383
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1395
Giving to @PSUdaemon, this is for him to consider for backport.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1393
Nice catch on AC_SEARCH_LIBS! Question, i wonder if we do this wrong in
other places? Are we adding things to LIBS when we shouldn't?
There are several places where we do things like
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1248
For future references, this really should have been squashed down to one
commit before merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1396
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1393
In fact, taking a quick look, tools like traffic_top is getting all the
"optional" libraries, even though they are highly unlikely to use 'em? Like,
libhwloc.
---
If your project
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1365
Nit picky, and too late, but I kinda wish these two new variables would
have been named "saved_XXX" instead of "cached_XXX". Cached make it sounds like
it's an optim
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1392
I suspect we might want to backport a fix for this to 7.1.x as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1397
Wonder if we should bother back porting these to 7.1.x ? Wdyt ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1396
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1384
Warnings when compiling against OpenSSL 1.1.0d
```
SSLUtils.cc: In function âvoid SSLInitializeLibrary()â:
SSLUtils.cc:863:57: warning: statement has no effect [-Wunused-value
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1385
sslheaders plugin fails with OpenSSL v1.1.0d
```
CXX
experimental/sslheaders/experimental_sslheaders_libsslhdr_la-expand.lo
experimental/sslheaders/expand.cc: In function 'void
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1386
ATS hangs, possibly because of OpenSSL 1.1.0
Seeing very, very deep stack traces, like
```
...
#1602 0x00792a94 in ssl_rm_cached_session (ctx=0x2b6b0bd23400,
sess
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1378
Also, please remember to add Milestone, Label's etc. on each Issue / PR,
otherwise @bryancall gets all pissy. :)
---
If your project is set up for it, you can reply to this email and have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1375
Is this a 7.1.x candidate?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1368
@shinrich Should we cherry-pick this back to 7.1.x ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1378
Why are there 4 commits on this? Can you squash those?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1374
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1303
This doesn't merge cleanly into 7.1.x branch (conflicts on the python
script). @jablko Can you make a new PR, for the 7.1.x branch please?
---
If your project is set up for it, you can reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1368
@maskit @shinrich ping? Should we back port to 7.1.x ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1380
ink_inet.cc:613:10: error: unused variable 'value_size'
[-Werror=unused-variable]
size_t value_size = sizeof(value);
---
If your project is set up for it, you can reply to this email
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1352
Documentation for volume.config is confusing and obsolete
In particular, the example with scheme=http / scheme=https is invalid,
there's only one protocol that's supported, http (for all HTTP
Github user zwoop closed the issue at:
https://github.com/apache/trafficserver/issues/1336
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1337
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1349
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1350
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1378
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1477
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1474
Leak detections when running ASAN on Docs/CI
It's likely that many (most?) of these are FPs, and can be avoided with
proper exit cleanups.
```
root@qa1 376/0 # ASAN_OPTIONS
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
This introduced a new Coverity issues:
```
*** CID 1371483: Error handling issues (CHECKED_RETURN)
/lib/ts/signals.cc: 173 in signal_format_siginfo(int, siginfo_t *, const
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1466
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1466
Good idea. @jpeach Can you either file an Issue or a PR with this?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1475
ASAN issue in traffic_manager metrics Lua bindings
```
root@qa1 616/1 # /opt/ats/bin/traffic_manager
[E. Mgmt] log ==> [TrafficManager] using root directory '/opt/
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1475
Invalid, I have no idea what the compilers are doing, and devtoolset-6 hate
me.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zwoop closed the issue at:
https://github.com/apache/trafficserver/issues/1475
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Ah, that fails because you don't have the fixes I made on master. All you
have to do is rebase your branch with current master, and push again.
---
If your project is set up for it, you can
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Yeh, this failed because the Intel installation was not correct on one of
the VMs. [approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1460
Removes some unnecessary dependencies on the public ts/ts.h
This also removes the proxy/api/ts directory from all default
search paths, to make it more difficult to introduce more bad
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1456
Hmmm, how is this different from
proxy.process.http.total_incoming_connections ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
@zizhong No need to apologize, this is exactly why we have a CI / build
system. :).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1450
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1461
Changes debug builds with Intel to just -g
This gets rid of debug build warnings with Intel compilers.
You can merge this pull request into a Git repository by running:
$ git pull https
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1466
Fixes the type for a few overridables
These are all MgmtByte, so should not use the INT type here.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Also, I'm gonna mark this for v7.1.0, because I've experienced these
crashers myself, and they are super annoying.
---
If your project is set up for it, you can reply to this email and have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1362
Somewhat mixed feelings on this. If someone has requests some particular
"limit" and that fails, I'd be concerned that we'd start up in a crippled
state. Meaning, I feel it bett
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1467
Adds the OpenSSL license
I believe since we copied the BIO function from OpenSSL, we must include
the OpenSSL license as well. I removed the NOTICE thing, since the copyright
attribution can
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1467
@jablko Did any of this OpenSSL code go into 7.1.x? If so, we need this
change there as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1464#discussion_r101878798
--- Diff: proxy/InkAPI.cc ---
@@ -8153,6 +8153,10 @@ _conf_to_memberp(TSOverridableConfigKey conf,
OverridableHttpConfigParams *overr
typ
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1464#discussion_r101878882
--- Diff: proxy/http/HttpConfig.h ---
@@ -563,6 +564,7 @@ struct OverridableHttpConfigParams {
// hostdb/dns variables
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
Did we address @jpeach concern re: memory leak debugging? Also, probably
would be a good idea if @bryancall chimed in here, since he did a lot of the
work around making ASAN etc. function
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1465
MIT is fine. You should retain the MIT header in any imported source, and
also update the NOTICE file accordingly.
---
If your project is set up for it, you can reply to this email and have
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1442
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1444
Fwiw, the fix here (like it or not) prevents the segfaults on docs / Ci.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1457
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1460
@jpeach Thanks for the solid review! I'm going to push a second commit unto
this PR, so you can see the changes I made on top of this review. I'll squash
them before committing.
---
If your
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1460#discussion_r102559050
--- Diff: lib/wccp/Makefile.am ---
@@ -20,8 +20,8 @@
include $(top_srcdir)/build/tidy.mk
AM_CPPFLAGS = \
- -I$(abs_top_srcdir)/lib
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1460
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/issues/1484
Well, more than just having the constant, we really need to think about the
implications of this, and how we should handle immutable in the cache. Today,
we have configurations to basically
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1482
@SolidWallOfCode
```
$ make -h clang-format
```
AND, add the flipping script I wrote to your .git hooks :-/
---
If your project is set up for it, you can reply
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1479
I like the elimination of that additional enum type, but I don't know
enough about the details in C++11 here to know what the impact are on
performance.
---
If your project is set up
GitHub user zwoop opened a pull request:
https://github.com/apache/trafficserver/pull/1488
This allows old ssl_multicert.config to still function on reload
The problem is that if a certificate fails to load, for whatever reason
that might be, ATS still switches the configuration
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1264
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1267
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1158
I still think we need to have a discussion on what these new "Lua" style
configs should be named, such that we don't have to come up with contrived
renaming. I'm ok with a pre
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1114
This needs rebasing and then I'll +1 it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1209
[approve ci]
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1488#discussion_r103039820
--- Diff: iocore/net/SSLUtils.cc ---
@@ -2007,7 +2007,10 @@ SSLParseCertificateConfiguration(const
SSLConfigParams *params, SSLCertLookup *l
Github user zwoop commented on a diff in the pull request:
https://github.com/apache/trafficserver/pull/1488#discussion_r103039976
--- Diff: iocore/net/SSLUtils.cc ---
@@ -2007,7 +2007,10 @@ SSLParseCertificateConfiguration(const
SSLConfigParams *params, SSLCertLookup *l
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1488
I see now, there's a new configuration,
proxy.config.ssl.server.multicert.exit_on_load_fail, which would exit on load
errors. Surprised that this is not the default to "1&qu
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1490
Inconsistent "exit" strategy on remap.config (and possibly other
configurations)
It seems, remap.config will allow some bad configurations to still startup,
but not others.
GitHub user zwoop opened an issue:
https://github.com/apache/trafficserver/issues/1489
Change default for proxy.config.ssl.server.multicert.exit_on_load_fail to
"1"
The default behavior is inconsistent with how the rest of ATS works, so I
think we should change
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1488
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1479
@SolidWallOfCode If you fix the merge conflicts now, I'll +1 this against
my better judgement :-).
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1488
I'm gonna close this PR for now, I think this code could be cleaned up, but
setting proxy.config.ssl.server.multicert.exit_on_load_fail=1 seems to behave
more reasonable than the defaults
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1465
Should this be in the "ci" tree rather that its own top-level tree?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as wel
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1460
@jablko Can you review please?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1435
@jablko should we land this? Please rebase and push, and I'll +1 it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1004
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1467
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop commented on the issue:
https://github.com/apache/trafficserver/pull/1455
I cherry-picked this to 7.1.x, so no need to make an additional PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1455
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user zwoop closed the pull request at:
https://github.com/apache/trafficserver/pull/1457
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
201 - 300 of 896 matches
Mail list logo
