[GitHub] trafficserver pull request #1239: TS-5069 enhance logstats to report stats p...

2016-12-01 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1239#discussion_r90559251 --- Diff: proxy/logstats.cc --- @@ -1164,16 +1167,64 @@ update_schemes(OriginStats *stat, int scheme, int size

[GitHub] trafficserver pull request #1239: TS-5069 enhance logstats to report stats p...

2016-12-01 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1239#discussion_r90557544 --- Diff: proxy/logstats.cc --- @@ -594,15 +594,16 @@ struct CommandLineArgs { int64_t min_hits; int max_age; int line_len

[GitHub] trafficserver issue #1050: TS-4897: Unbound growth of number of memory maps ...

2016-12-01 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1050 It's fixed elsewhere? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1246: TS-5069: Fixes CID 1366771 and 1366771

2016-12-03 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1246 TS-5069: Fixes CID 1366771 and 1366771 These might be older, but this last batch of commits in TS-5069 triggers Coverity. You can merge this pull request into a Git repository by running

[GitHub] trafficserver pull request #1246: TS-5069: Fixes CID 1366771 and 1366771

2016-12-03 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1246 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1245: TS-5076: Test and set the in_enabled_list by atom...

2016-12-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1245 clang-format :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1209: Remove unused and never to be used classes from M...

2016-12-04 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1209 @SolidWallOfCode Did you make the fixes to the unit tests ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver pull request #1247: TS-5078: Support MADV_DONTDUMP even when t...

2016-12-05 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1247 TS-5078: Support MADV_DONTDUMP even when the freelist is disabled I'm a little bit on this ice here, Phil already gave advice on some details, but this should be properly reviewed (of course

[GitHub] trafficserver issue #1249: TS-5061 TS use ats_malloc instead of malloc in lo...

2016-12-05 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1249 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1247: TS-5078: Support MADV_DONTDUMP even when t...

2016-12-05 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1247 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1249: TS-5061 TS use ats_malloc instead of mallo...

2016-12-05 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1249 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1229: TS-5061 TS use ats_malloc instead of mallo...

2016-12-04 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1229 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1229: TS-5061 TS use ats_malloc instead of malloc in lo...

2016-12-04 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1229 Well dammit, I screwed up, this PR was against the 7.0.x branch :-/ Can you please make a new PR against master please? I will undo the 7.0.x commit. --- If your project is set up for it, you

[GitHub] trafficserver issue #1245: TS-5076: Test and set the in_enabled_list by atom...

2016-12-05 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1245 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1239: TS-5069 enhance logstats to report stats p...

2016-12-02 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1239 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1229: TS-5061 TS use ats_malloc instead of malloc in lo...

2016-12-02 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1229 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1301: Can trafficserver proxy to another proxy?

2017-01-06 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1301 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1301: Can trafficserver proxy to another proxy?

2017-01-06 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1301 This really belongs on the us...@trafficserver.apache.org mailing list. I'm going to close this, but the short answer is that you could use the parent.config instead of remap. --- If your

[GitHub] trafficserver issue #1297: ISSUE 1283: Fix CID 1367526 and CID 1367525 in mo...

2017-01-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1297 I think the Jenkins master was wedged, trying a new build [approve ci]. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1299: TS-2888: remove vararg and format parameters from...

2017-01-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1299 [add to whitelist] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL 1.1.0

2017-01-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1294 I'm seeing e.g. ``` BIO_fastopen.cc: In function 'int fastopen_create(BIO*)': BIO_fastopen.cc:48:11: error: 'BIO' has no member named 'data' BIO_set_data(bio, data

[GitHub] trafficserver issue #1294: TS-5059: Port TCP Fast Open BIO to OpenSSL 1.1.0

2017-01-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1294 [add to whitelist] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1257: TS-5053 const char **argv passed to TSPluginInit ...

2017-01-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1257 [add to whitelist] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1298: traffic_server deadlocked after config reload

2017-01-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1298 @randall We only saw this once so far, right? It might be worth trying turning off HostDB syncing again, now that we can do that (supposedly safely) in 7.x ? --- If your project is set up

[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...

2017-01-03 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1276 Marking this for 6.2.2 for now, unless we need to respond 6.2.1? Also, this has build issues I think? --- If your project is set up for it, you can reply to this email and have your reply

[GitHub] trafficserver issue #1306: [openbsd] pthread_np.h needs to be included

2017-01-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1306 Yeh, I agree with peach, it seems very odd that it's not picking it up properly. It'd be better to fix that, instead of ifdef on openbsd IMO. --- If your project is set up for it, you can

[GitHub] trafficserver issue #1303: TS-5107: Changes to autolinking in Docutils 1.3

2017-01-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1303 We need into 7.1.x as well, right? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1308: CID 1368316 & 1368315: Leaks and NULL references

2017-01-07 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1308 CID 1368316 & 1368315: Leaks and NULL references I think this landed recently (TS-5092?), and we have to fix this for 7.1.x. clang-analyzer also detects the NULL pointer reference.

[GitHub] trafficserver issue #1305: CID 1368316 Resource leak

2017-01-07 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1305 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1305: CID 1368316 Resource leak

2017-01-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1305 Closing this as a dupe of #1308, since it has more details. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #1276: TS-5105: Do vc->con.setRemote(target) before sock...

2017-01-07 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1276 Trying a new build [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1291: CID 1196420: Error handling issues (CHECKED_RETUR...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1291 CID 1196420: Error handling issues (CHECKED_RETURN): proxy/CoreUtils.cc ``` *** CID 1196420: Error handling issues (CHECKED_RETURN) /proxy/CoreUtils.cc: 482 in CoreUtils

[GitHub] trafficserver issue #1286: CID 1367521: Low impact quality (MISSING_MOVE_ASS...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1286 CID 1367521: Low impact quality (MISSING_MOVE_ASSIGNMENT): tsconfig/Errata.h and tsconfig/TsValue.h ``` *** CID 1367521: Low impact quality (MISSING_MOVE_ASSIGNMENT) /lib/tsconfig

[GitHub] trafficserver issue #1282: CID 1367527: Program hangs (SLEEP): cluster/Clust...

2016-12-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1282 Do we just ignore /kill all clustering issues? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1284: CID 1367523: (MISSING_MOVE_ASSIGNMENT): tsconfig/...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1284 CID 1367523:(MISSING_MOVE_ASSIGNMENT): tsconfig/IntrusivePtr. ``` *** CID 1367523:(MISSING_MOVE_ASSIGNMENT) /lib/tsconfig/IntrusivePtr.h: 134 in () 128 ownded by a set

[GitHub] trafficserver issue #1285: CID 1367522: (MISSING_MOVE_ASSIGNMENT): /ts/Ptr.h

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1285 CID 1367522:(MISSING_MOVE_ASSIGNMENT): /ts/Ptr.h ``` *** CID 1367522:(MISSING_MOVE_ASSIGNMENT) /lib/ts/Ptr.h: 101 in () 95 96

[GitHub] trafficserver issue #1280: CID 1367529: Security best practices violations (...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1280 CID 1367529: Security best practices violations (STRING_OVERFLOW): url_sig/url_sig.c ``` *** CID 1367529: Security best practices violations (STRING_OVERFLOW) /plugins/experimental

[GitHub] trafficserver issue #1279: CID 1367531: Uninitialized members (UNINIT_CTOR):...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1279 CID 1367531: Uninitialized members (UNINIT_CTOR): proxy/main.cc ``` *** CID 1367531: Uninitialized members (UNINIT_CTOR) /proxy/Main.cc: 352 in MemoryLimit::MemoryLimit()() 346

[GitHub] trafficserver issue #1282: CID 1367527: Program hangs (SLEEP): cluster/Clust...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1282 CID 1367527: Program hangs (SLEEP): cluster/ClusterCom.cc ``` *** CID 1367527: Program hangs (SLEEP) /mgmt/cluster/ClusterCom.cc: 1953 in ClusterCom::sendReliableMessage(unsigned long

[GitHub] trafficserver issue #1281: CID 1367528: Security best practices violations (...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1281 CID 1367528: Security best practices violations (STRING_OVERFLOW): http/HttpTransactHeaders.cc ``` *** CID 1367528: Security best practices violations (STRING_OVERFLOW) /proxy/http

[GitHub] trafficserver issue #1290: CID 1367516: Null pointer dereferences (FORWARD_N...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1290 CID 1367516: Null pointer dereferences (FORWARD_NULL): wccp/WccpConfig.cc ``` *** CID 1367516: Null pointer dereferences (FORWARD_NULL) /lib/wccp/WccpConfig.cc: 528 in wccp::CacheImpl

[GitHub] trafficserver issue #1289: CID 1367517: API usage errors (LOCK): mgmt/FileMa...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1289 CID 1367517: API usage errors (LOCK): mgmt/FileManager.cc ``` *** CID 1367517: API usage errors (LOCK) /mgmt/FileManager.cc: 97 in FileManager::~FileManager()() 91 92

[GitHub] trafficserver issue #1288: CID 1367518: (LOCK): records/P_RecCore.cc

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1288 CID 1367518:(LOCK): records/P_RecCore.cc ``` *** CID 1367518:(LOCK) /lib/records/P_RecCore.cc: 751 in RecSyncConfigToTB(textBuffer *, bool *)() 745 break

[GitHub] trafficserver issue #1287: CID 1367519: Low impact quality (MISSING_MOVE_ASS...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1287 CID 1367519: Low impact quality (MISSING_MOVE_ASSIGNMENT): ts/ink_memory.h ``` *** CID 1367519: Low impact quality (MISSING_MOVE_ASSIGNMENT) /lib/ts/ink_memory.h: 242 in () 236

[GitHub] trafficserver issue #1283: CID 1367526: CID 1367525 : money_trace/money_trac...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1283 CID 1367526: CID 1367525 : money_trace/money_trace.cc ``` *** CID 1367526: Null pointer dereferences (REVERSE_INULL) /plugins/experimental/money_trace/money_trace.cc: 57

[GitHub] trafficserver issue #1292: CID 1367515, CID 1367514, CID 1367513: ts_lua plu...

2016-12-30 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1292 Meh, there's already a PR for this, nm. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1292: CID 1367515, CID 1367514, CID 1367513: ts_lua plu...

2016-12-30 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1292 CID 1367515, CID 1367514, CID 1367513: ts_lua plugin ``` *** CID 1367515: Error handling issues (CHECKED_RETURN) /plugins/experimental/ts_lua/ts_lua_server_response.c: 354

[GitHub] trafficserver issue #1292: CID 1367515, CID 1367514, CID 1367513: ts_lua plu...

2016-12-30 Thread zwoop
Github user zwoop closed the issue at: https://github.com/apache/trafficserver/issues/1292 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1302: CID 1368306 & 1368305: NULLPTR and security BP in...

2017-01-06 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1302 CID 1368306 & 1368305: NULLPTR and security BP in logical.cc ```c ** CID 1368306: Security best practices violations (TOCTOU) /proxy/logcat.cc: 299 in

[GitHub] trafficserver issue #1184: TS-5030: Add API to get the unique client request...

2016-12-22 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1184 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1224: TS-5056 Implement nonrecoverable error mechanism

2016-12-22 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1224 This needs to run clang-format again. Please rebase and push the PR again, and I'll land it. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1184: TS-5030: Add API to get the unique client request...

2016-12-22 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1184 This needs to run clang-format again. Please rebase and push the PR again, and I'll land it. --- If your project is set up for it, you can reply to this email and have your reply appear

[GitHub] trafficserver issue #1184: TS-5030: Add API to get the unique client request...

2016-12-22 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1184 I'm gonna merge this, and fix the clang-format separately. Please make an effort to always run clang-format though :). --- If your project is set up for it, you can reply to this email

[GitHub] trafficserver pull request #1184: TS-5030: Add API to get the unique client ...

2016-12-22 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1184 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1273: TS-5030: Fixes the sizeof issues, adds a c...

2016-12-22 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1273 TS-5030: Fixes the sizeof issues, adds a constant You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver TS-5030

[GitHub] trafficserver pull request #996: TS-4834 Expose bad disk and disk access fai...

2016-12-22 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/996 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1273: TS-5030: Fixes the sizeof issues, adds a constant

2016-12-22 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1273 Try again [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver pull request #1273: TS-5030: Fixes the sizeof issues, adds a c...

2016-12-22 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1273 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1610: backport c4144 and 74fc4 to 7.1.x

2017-03-27 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1610 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver pull request #1608: FTP Support

2017-03-28 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1608#discussion_r108462625 --- Diff: proxy/http/HttpConfig.cc --- @@ -1129,6 +1129,8 @@ HttpConfig::startup() // Local Manager HttpEstablishStaticConfigLongLong

[GitHub] trafficserver pull request #1608: FTP Support

2017-03-28 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1608#discussion_r108462430 --- Diff: proxy/http/HttpConfig.h --- @@ -824,6 +824,8 @@ struct HttpConfigParams : public ConfigInfo { MgmtInt

[GitHub] trafficserver pull request #1608: FTP Support

2017-03-28 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1608#discussion_r108463799 --- Diff: ci/tsqa/tests/test_forward_proxy.py --- @@ -0,0 +1,123 @@ +''' --- End diff -- If at all possible, can you convert

[GitHub] trafficserver issue #1604: TS-4976: Regularize plugins - protocol_stack

2017-03-26 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1604 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1546: NetVC maybe lost from read_ready_list if Plugin c...

2017-03-26 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1546 Is there a reason why this hasn't landed? if not, land it :). --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] trafficserver issue #1568: TS-4195: double free on exit

2017-03-26 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1568 @bryancall Ping? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes

[GitHub] trafficserver issue #1540: Metalink Plugin: Must not destroy the Transform C...

2017-03-26 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1540 @jablko Can you review this please? And also, I think your MATT connection needs to be redone, since we got moved to gitbox for the internal ASF sync service). --- If your project is set up

[GitHub] trafficserver issue #1600: fix , remove not used array buf in rcv_data_frame...

2017-03-26 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1600 Cherry-picked to 7.1.x, seems safe, and very reasonable. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1606: require sphinx version 1.5.1

2017-03-26 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1606 Why was this merged without setting appropriate labels / versions? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1547: Fix ssl hook state logic.

2017-03-26 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1547 @persiaAziz This does not cherry-pick cleanly to 7.1.0, so if we want this for 7.1.x branch, can you please make another PR, against the 7.1.x branch? --- If your project is set up

[GitHub] trafficserver pull request #1620: Adds a new condition, %{IP:}

2017-03-29 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1620 Adds a new condition, %{IP:} This replaces the old %{CLIENT-IP}, and generalizes the access to all four IP addresses. E.g. cond %{SEND_RESPONSE_HDR_HOOK} set-header X

[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...

2017-03-29 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1583 I've been running with this on docs for a few days, with no problem. It does not seem to address the threads running at 100% CPU at times though. But assuming this fixes another problem

[GitHub] trafficserver pull request #1619: Perform the config reload on ET_TASK threa...

2017-03-29 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1619 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1612: Changed some of the HTTP/2 enums to enum classes ...

2017-03-29 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1612 Cherry picked to 7.1.x --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1612: Changed some of the HTTP/2 enums to enum classes ...

2017-03-27 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1612 Moved to 7.1.0, I think this is a good patch + good fix! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1602: proxy.config.ssl.server.multicert.exit_on_load_fa...

2017-03-25 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/issues/1602 Not reloadable. The setting restores the old/expected behavior, meaning 1. It will not let you start traffic_server with a bad ssl_multicert.config 2. It will not replace

[GitHub] trafficserver pull request #1623: Delete dead code

2017-03-30 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1623#discussion_r109090078 --- Diff: proxy/logging/LogBuffer.cc --- @@ -112,14 +112,6 @@ LogBufferHeader::log_filename() return addr

[GitHub] trafficserver issue #1587: Intermittent regression test failures (debug buil...

2017-03-16 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1587 Intermittent regression test failures (debug build) Seeing this on some VMs: ``` REGRESSION TEST SDK_API_HttpTxnTransform started [SDK_API_HttpTxnTransform] TSTransformCreate

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-16 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1548 I'm fine with this. However, seeing that the two policy implementations has virtually identical implementations here, it begs the question as to why this is not in a base class? It seems

[GitHub] trafficserver pull request #1588: Make clear the implicit relationship betwe...

2017-03-16 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1588 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1593: Thread "hangs" on Docs

2017-03-17 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1593 Thread "hangs" on Docs Running latest 7.1.x branch on Docs with #1583 as well, I started seeing a thread consuming a *lot* of CPU. In the order of 1000x more than the other thread

[GitHub] trafficserver issue #1497: Doc: change .svg to .png.

2017-03-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1497 Yeh, that's fine, I upgraded Sphinx long ago on the Docs build box. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your

[GitHub] trafficserver issue #1592: TS-4976: Regularize plugins - hello

2017-03-17 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1592 Why did the AU check fail? Did you forget to rebase? :) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1577: Update http2.test.py

2017-03-14 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1577 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1578: Add missing include, which otherwise break...

2017-03-14 Thread zwoop
GitHub user zwoop opened a pull request: https://github.com/apache/trafficserver/pull/1578 Add missing include, which otherwise breaks on OSX You can merge this pull request into a Git repository by running: $ git pull https://github.com/zwoop/trafficserver CMATH

[GitHub] trafficserver pull request #1578: Add missing include, which otherwise break...

2017-03-14 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1578 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1577: Update http2.test.py

2017-03-14 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1577 Please file an Issue on the cleanup task, so we know about it, and it gets assigned. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub

[GitHub] trafficserver issue #1577: Update http2.test.py

2017-03-14 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1577 I think we need to make the AU check succeed, right ? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does

[GitHub] trafficserver issue #1568: TS-4195: double free on exit

2017-03-14 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1568 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver pull request #1576: Add option to choose interface

2017-03-14 Thread zwoop
Github user zwoop commented on a diff in the pull request: https://github.com/apache/trafficserver/pull/1576#discussion_r106004593 --- Diff: tests/tools/microServer/uWServer.py --- @@ -17,6 +17,7 @@ # See the License for the specific language governing permissions

[GitHub] trafficserver pull request #1586: Update the list of overridable configs

2017-03-15 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1586 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

[GitHub] trafficserver issue #1583: Set HttpSM::tunnel_handler_post to handle write e...

2017-03-15 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1583 This sounds like a 7.1.0 candidate? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] trafficserver issue #1580: change command to use python3

2017-03-14 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1580 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1548: Insure that parent health stats are updated prope...

2017-03-14 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1548 @jrushford Do you want this in 7.1.0? If not, move it out to 7.2.0 please. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well

[GitHub] trafficserver issue #1582: Make regex_revalidate.c use ref-counted config da...

2017-03-14 Thread zwoop
GitHub user zwoop opened an issue: https://github.com/apache/trafficserver/issues/1582 Make regex_revalidate.c use ref-counted config data Instead of scheduling a "delete" of the data sometime in the future, a more reliable pattern is to ref-count the configurations, a

[GitHub] trafficserver issue #1552: rectify a minor error in file test_intercept.lua

2017-03-14 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1552 @shukitchan You ok with this? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] trafficserver issue #1552: rectify a minor error in file test_intercept.lua

2017-03-14 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1552 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1550: rectify a minor error in healthchecks.c

2017-03-14 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1550 [approve ci] to see if the FreeBSD builds succeed. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have

[GitHub] trafficserver issue #1371: Calling setrlimit() twice is redundant

2017-03-14 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1371 [approve ci] --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] trafficserver issue #1517: Remove BisonHeaderToC++.sed

2017-03-14 Thread zwoop
Github user zwoop commented on the issue: https://github.com/apache/trafficserver/pull/1517 Note that it has to succeed on CentOS6, which is indeed running ``` [root@centos6 ~]# bison --version bison (GNU Bison) 2.4.1 ``` --- If your project is set up

[GitHub] trafficserver pull request #1576: Add option to choose interface

2017-03-14 Thread zwoop
Github user zwoop closed the pull request at: https://github.com/apache/trafficserver/pull/1576 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature

<    3   4   5   6   7   8   9   >