We _could_ do a wholesale change as part of 3.0, and then just make
sure that committers going forward format properly. I've seen other
projects do that.
Also, I'm not sure, but I think Hadoop's automated patch checker can
check to see if a patch is properly formatted or not. We need to
[
https://issues.apache.org/jira/browse/LUCENE-1424?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12646215#action_12646215
]
Michael McCandless commented on LUCENE-1424:
OK this version looks good! I
[
https://issues.apache.org/jira/browse/LUCENE-1286?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12646266#action_12646266
]
Mark Miller commented on LUCENE-1286:
-
It didn't turn out as well as I had hoped. You
[
https://issues.apache.org/jira/browse/LUCENE-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12646275#action_12646275
]
Mark Miller commented on LUCENE-1122:
-
Its because a term is madeup of TERM_START_CHAR
[
https://issues.apache.org/jira/browse/LUCENE-1122?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-1122:
Priority: Minor (was: Major)
queryparser whitespace escaping and documentation?
[
https://issues.apache.org/jira/browse/LUCENE-1409?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless resolved LUCENE-1409.
Resolution: Cannot Reproduce
I agree.
read past EOF
-
It seems to me that the following would work:
1) All new code (contrib too) has to be formatted according to
published standards. This can be done either by the person doing the
submission, by a committer, or (It doesn't matter to me)
2) All existing code for which there is no patch can
[
https://issues.apache.org/jira/browse/LUCENE-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12646280#action_12646280
]
Mark Miller commented on LUCENE-427:
Tempted to close this. Seems to me you are better
[
https://issues.apache.org/jira/browse/LUCENE-427?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12646280#action_12646280
]
Mark Miller commented on LUCENE-427:
Tempted to close this. Seems to me you are better
[
https://issues.apache.org/jira/browse/LUCENE-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Paul Elschot updated LUCENE-1443:
-
Attachment: LUCENE-1443b.patch
Some more bits, some less.
The b patch should be faster than the
Michael McCandless wrote:
I do worry that wholesale formatting changes will obsolete pending
patches
Note that 'patch -l' will ignore whitespace, permitting indentation
changes w/o breaking patches.
Doug
-
To unsubscribe,
[
https://issues.apache.org/jira/browse/LUCENE-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12646350#action_12646350
]
Yonik Seeley commented on LUCENE-1443:
--
Looks good Paul, the int version of clear()
[
https://issues.apache.org/jira/browse/LUCENE-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12646370#action_12646370
]
Paul Elschot commented on LUCENE-1443:
--
Thanks for taking a look Yonik, I was about
[
https://issues.apache.org/jira/browse/LUCENE-861?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller updated LUCENE-861:
---
Attachment: LUCENE-861.patch
It makes sense to fix this, but I don't know that we can meet your
[
https://issues.apache.org/jira/browse/LUCENE-655?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller resolved LUCENE-655.
Resolution: Incomplete
field queries does not work as expected
[
https://issues.apache.org/jira/browse/LUCENE-402?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Miller resolved LUCENE-402.
Resolution: Incomplete
Assignee: (was: Lucene Developers)
Come back with an efficient
[
https://issues.apache.org/jira/browse/LUCENE-1263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12646396#action_12646396
]
Mark Miller commented on LUCENE-1263:
-
I cannot duplicate your problem. Are you sure
[
https://issues.apache.org/jira/browse/LUCENE-1246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12646400#action_12646400
]
Mark Miller commented on LUCENE-1246:
-
bq. Could one argue that maybe your
[
https://issues.apache.org/jira/browse/LUCENE-1052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12646437#action_12646437
]
Mark Miller commented on LUCENE-1052:
-
Should any further improvements be in a new
[
https://issues.apache.org/jira/browse/LUCENE-1443?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Yonik Seeley resolved LUCENE-1443.
--
Resolution: Fixed
Fix Version/s: 2.9
Lucene Fields: [New, Patch Available] (was:
[
https://issues.apache.org/jira/browse/LUCENE-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Busch updated LUCENE-1446:
--
Attachment: lucene-1446.patch
Small update: the availability check of a tag must be done in
[
https://issues.apache.org/jira/browse/LUCENE-1446?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael Busch resolved LUCENE-1446.
---
Resolution: Fixed
Lucene Fields: [New, Patch Available] (was: [Patch Available,
[
https://issues.apache.org/jira/browse/LUCENE-1435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Steven Rowe updated LUCENE-1435:
Attachment: LUCENE-1435.patch
Modifications in this patch:
# Added dependency on ICU4J 4.0
#
23 matches
Mail list logo
