[
https://issues.apache.org/jira/browse/LUCENE-1823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784709#action_12784709
]
Shai Erera commented on LUCENE-1823:
I prefer syntax 2 for the opaque terms. If the id
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784716#action_12784716
]
Uwe Schindler commented on LUCENE-2074:
---
I think we can go forward with this now?
I
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784720#action_12784720
]
Robert Muir commented on LUCENE-2074:
-
bq. I think we can go forward with this now?
[
https://issues.apache.org/jira/browse/LUCENE-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784733#action_12784733
]
Simon Willnauer commented on LUCENE-2034:
-
DM, thanks for the extensive example. B
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784738#action_12784738
]
Simon Willnauer commented on LUCENE-2102:
-
Maybe I miss something but what is the
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784743#action_12784743
]
Uwe Schindler commented on LUCENE-2102:
---
We should use version from the beginning of
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784748#action_12784748
]
Simon Willnauer commented on LUCENE-2102:
-
bq. But to be consistent with LowerCas
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784750#action_12784750
]
Simon Willnauer commented on LUCENE-2102:
-
I think we should have a consistent beh
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-2074:
--
Attachment: jflex-1.4.1-vs-1.5-snapshot.diff
I tried with JFlex 1.5 svn trunk version from tod
NoLockFactory documents in its javadocs that one should call the static
getNoLockFactory() in order to create an instance. The class however does
not have a private ctor, so someone can create another instance of it. This
is not a big deal though, because makeLock returns a static member. But it
lo
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784788#action_12784788
]
Uwe Schindler edited comment on LUCENE-2074 at 12/2/09 12:12 PM:
---
I have seen this several times when working on oal.store. We should have
deprecated the ctor in 2.9 and removed in 3.0. For BW compatibility we have
to simply deprecate it and tell the user to take the singleton.
Uwe
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.
[
https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784811#action_12784811
]
Mark Miller commented on LUCENE-1458:
-
I've put the merge on hold for a bit - will try
[
https://issues.apache.org/jira/browse/LUCENE-2034?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784812#action_12784812
]
DM Smith commented on LUCENE-2034:
--
bq. But I do not see the benefit compared to the curr
So you believe someone actually does "new NoLockFactory()"? If so, we should
add the ctor as deprecated, because currently it does not exist, and thus
cannot be deprecated :).
Of course, adding a deprecated empty ctor needs to be accompanied by proper
documentation to move it to private, or else i
[
https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784818#action_12784818
]
Michael McCandless commented on LUCENE-1458:
I think that test failure was fro
[
https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784819#action_12784819
]
Michael McCandless commented on LUCENE-1458:
And, thanks for taking over on me
Hi Shai,
It exists, auto-generated by the compiler! But for deprecating and javadocs,
we have to explicitly create one. This is not a huge deal. And for everybody
it is clear (the @deprec message should tell, that this class should be a
singleton), that it will not be removed in 4.0, but instea
[
https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784823#action_12784823
]
Uwe Schindler commented on LUCENE-1458:
---
I have seen your change in the tests, too.
ok so will you mark it deprecated that way?
On Wed, Dec 2, 2009 at 3:46 PM, Uwe Schindler wrote:
> Hi Shai,
>
>
>
> It exists, auto-generated by the compiler! But for deprecating and
> javadocs, we have to explicitly create one. This is not a huge deal. And for
> everybody it is clear (the @dep
[
https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784825#action_12784825
]
Michael McCandless commented on LUCENE-1458:
bq. In my opinion, it should not
Can you open an issue, I will take it then. I will not commit any API change
without issue for the next time *g*
Uwe
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
_
From: Shai Erera [mailto:ser...@gmail.com]
Sent: Wednesda
:)
opened LUCENE-2103
On Wed, Dec 2, 2009 at 3:59 PM, Uwe Schindler wrote:
> Can you open an issue, I will take it then. I will not commit any API
> change without issue for the next time **g**
>
>
>
> Uwe
>
>
>
> -
> Uwe Schindler
> H.-H.-Meier-Allee 63, D-28213 Bremen
> http://www.thetap
NoLockFactory should have a private constructor
---
Key: LUCENE-2103
URL: https://issues.apache.org/jira/browse/LUCENE-2103
Project: Lucene - Java
Issue Type: Bug
Reporter: Shai Erera
[
https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784829#action_12784829
]
Uwe Schindler commented on LUCENE-1458:
---
I rewrote to:
{code}
public void testEmptyT
[
https://issues.apache.org/jira/browse/LUCENE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler reassigned LUCENE-2103:
-
Assignee: Uwe Schindler
> NoLockFactory should have a private constructor
>
[
https://issues.apache.org/jira/browse/LUCENE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-2103:
--
Component/s: Store
Priority: Trivial (was: Major)
Affects Version/s: 3.
[
https://issues.apache.org/jira/browse/LUCENE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-2103:
--
Attachment: LUCENE-2103.patch
Attached is the patch with javadocs and deprecation.
Will commi
[
https://issues.apache.org/jira/browse/LUCENE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-2103:
--
Attachment: LUCENE-2103.patch
New patch with CHANGES.txt, thanks Shai!
> NoLockFactory should
[
https://issues.apache.org/jira/browse/LUCENE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784842#action_12784842
]
Uwe Schindler commented on LUCENE-2103:
---
One addition: In my opinion, this class sho
[
https://issues.apache.org/jira/browse/LUCENE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784845#action_12784845
]
Shai Erera commented on LUCENE-2103:
if we're breaking BW, why not add the private cto
[
https://issues.apache.org/jira/browse/LUCENE-2103?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784851#action_12784851
]
Uwe Schindler commented on LUCENE-2103:
---
I think I keep this open for a moment, mayb
Hi
Not sure if I'm using it right, so apologize in advance if I posted to the
wrong list. I tried to use IndexWriter.unlock, as according to my
understanding, it should unlock a directory if it's locked, and that's by
deleting the lock file. But it doesn't work. Here's a short test:
Directory dir
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784863#action_12784863
]
Robert Muir commented on LUCENE-2074:
-
Uwe, I think you need to change your grammar to
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784865#action_12784865
]
Uwe Schindler commented on LUCENE-2074:
---
That's obvious. But do we want to do this?
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784867#action_12784867
]
Robert Muir commented on LUCENE-2074:
-
Uwe, thats not the only interesting new feature
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784868#action_12784868
]
Uwe Schindler commented on LUCENE-2074:
---
So I should also be able to regenerate the
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784871#action_12784871
]
Robert Muir commented on LUCENE-2074:
-
ooh i actually do liek that... it should work..
It seems that only NativeFSLock has a problem here. The rest either attempt
to delete the file or do something else. Only NativeFSLock does not do
anything, if its 'lock' instance in null. Which will always be the case,
because NativeFSLockFactory.makeLock always returns a new NativeFSLock. So
unle
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784872#action_12784872
]
Uwe Schindler commented on LUCENE-2074:
---
Accoring to the title of this issue, we sho
[
https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784873#action_12784873
]
Michael McCandless commented on LUCENE-1458:
Looks great -- can/did you commit
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784875#action_12784875
]
Robert Muir commented on LUCENE-2102:
-
bq. If somebody uses Version < 3.1 this filter
Sneaky! Can you open a bug?
Mike
On Wed, Dec 2, 2009 at 10:23 AM, Shai Erera wrote:
> It seems that only NativeFSLock has a problem here. The rest either attempt
> to delete the file or do something else. Only NativeFSLock does not do
> anything, if its 'lock' instance in null. Which will alway
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784877#action_12784877
]
Robert Muir commented on LUCENE-2074:
-
Uwe I agree, I am just answering your questions
[
https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784876#action_12784876
]
Mark Miller commented on LUCENE-1458:
-
bq. Does that explain it?
That was my initial
[
https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784878#action_12784878
]
Uwe Schindler commented on LUCENE-1458:
---
I can do this, but according to Mark, only
IndexWriter.unlock does does nothing if NativeFSLockFactory is used
---
Key: LUCENE-2104
URL: https://issues.apache.org/jira/browse/LUCENE-2104
Project: Lucene - Java
Issue Type
Ok Mike, opened https://issues.apache.org/jira/browse/LUCENE-2104. I'll
figure how to reproduce this in a JUnit test, and then fix it.
Shai
On Wed, Dec 2, 2009 at 5:28 PM, Michael McCandless <
luc...@mikemccandless.com> wrote:
> Sneaky! Can you open a bug?
>
> Mike
>
> On Wed, Dec 2, 2009 at 10
[
https://issues.apache.org/jira/browse/LUCENE-2062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir resolved LUCENE-2062.
-
Resolution: Fixed
Committed revision 886190.
Thanks for the reviews and assistance
> Bulgarian
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-2074:
--
Attachment: LUCENE-2074.patch
Attached is a patch.
To regenerate the parsers you can run "ant
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784898#action_12784898
]
Robert Muir commented on LUCENE-2074:
-
Hi Uwe, do we even need READ_BEFORE_REGENERATIN
[
https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784903#action_12784903
]
Mark Miller commented on LUCENE-1458:
-
Interesting ... after many, many runs without s
[
https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784904#action_12784904
]
Mark Miller commented on LUCENE-1458:
-
bq. I can do this, but according to Mark, only
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784905#action_12784905
]
Uwe Schindler commented on LUCENE-2074:
---
I will try out if it fails. But you cannot
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784905#action_12784905
]
Uwe Schindler edited comment on LUCENE-2074 at 12/2/09 5:22 PM:
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784906#action_12784906
]
Robert Muir commented on LUCENE-2074:
-
bq. By this whenever we create a new version/sy
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784907#action_12784907
]
Simon Willnauer commented on LUCENE-2102:
-
Robert, I see your point. The root caus
[
https://issues.apache.org/jira/browse/LUCENE-2039?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784910#action_12784910
]
Simon Willnauer commented on LUCENE-2039:
-
bq. ...was to remove ComplexPhraseQuery
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784926#action_12784926
]
Robert Muir commented on LUCENE-2102:
-
bq. I don't think that new code should try do a
We should change the test in the same way on trunk and ist bw branch, I will
do this later.
-
Uwe Schindler
H.-H.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
> -Original Message-
> From: markrmil...@apache.org [mailto:markrmil...@apache.org]
> Sent: W
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-2102:
Attachment: LUCENE-2102.patch
patch with Simon's suggestions.
> LowerCaseFilter for Turkish langu
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784928#action_12784928
]
Simon Willnauer commented on LUCENE-2102:
-
bq. ok, I will change this. You are rig
Is anyone thinking about committing this patch? And/or what do I need to
do/should have done to indicate it's ready for review?
Poor lonely patch, sitting out there all alone and neglected ...
Erick
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784944#action_12784944
]
Simon Willnauer commented on LUCENE-2102:
-
Robert, this patch looks good!
Much cl
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-2102:
Attachment: LUCENE-2102.patch
trivial update with comment for the test and better example explaini
[
https://issues.apache.org/jira/browse/LUCENE-2102?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Simon Willnauer reassigned LUCENE-2102:
---
Assignee: Simon Willnauer (was: Robert Muir)
I will take over for Robert - go ahead
[
https://issues.apache.org/jira/browse/LUCENE-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Michael McCandless resolved LUCENE-2095.
Resolution: Fixed
> Document not guaranteed to be found after write and commit
> -
[
https://issues.apache.org/jira/browse/LUCENE-2095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784974#action_12784974
]
Michael McCandless commented on LUCENE-2095:
Thanks Sanne!
> Document not gua
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784986#action_12784986
]
Gunnar Wagenknecht commented on LUCENE-1483:
Hi,
This issue introduced Sorter
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784990#action_12784990
]
Yonik Seeley commented on LUCENE-1483:
--
That's strange... looks like SorterTemplate i
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784997#action_12784997
]
Mark Miller commented on LUCENE-1483:
-
I originally borrowed to sort readers and start
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12784999#action_12784999
]
Robert Muir commented on LUCENE-1483:
-
but isn't this code ok to borrow?
http://cglib
[
https://issues.apache.org/jira/browse/LUCENE-1483?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785003#action_12785003
]
Mark Miller commented on LUCENE-1483:
-
Sure is - but IP teams are crazy :) Other stuff
[
https://issues.apache.org/jira/browse/LUCENE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Robert Muir updated LUCENE-1606:
Attachment: LUCENE-1606.patch
here is an updated patch. In my opinion all that is needed is to add
[
https://issues.apache.org/jira/browse/LUCENE-1606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785034#action_12785034
]
Robert Muir commented on LUCENE-1606:
-
btw the unicode complexity i mention here is no
[
https://issues.apache.org/jira/browse/LUCENE-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785036#action_12785036
]
DM Smith commented on LUCENE-1488:
--
Robert, just finished reviewing the code. Looks great
[
https://issues.apache.org/jira/browse/LUCENE-2074?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Uwe Schindler updated LUCENE-2074:
--
Attachment: LUCENE-2074.patch
This patch now implements my latest proposal about the filenames
[
https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785052#action_12785052
]
Uwe Schindler commented on LUCENE-1458:
---
I put the better test into trunk/trunk BW.
[
https://issues.apache.org/jira/browse/LUCENE-1488?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785054#action_12785054
]
Robert Muir commented on LUCENE-1488:
-
DM, I really appreciate your review. You have b
Thanks Uwe!
uschind...@apache.org wrote:
> Author: uschindler
> Date: Wed Dec 2 23:29:17 2009
> New Revision: 886340
>
> URL: http://svn.apache.org/viewvc?rev=886340&view=rev
> Log:
> other way round!
>
> Modified:
>
> lucene/java/branches/flex_1458/src/test/org/apache/lucene/search/TestNume
[
https://issues.apache.org/jira/browse/LUCENE-1458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785058#action_12785058
]
Uwe Schindler commented on LUCENE-1458:
---
Mike: When fixing the NRQ test Mark merged,
I see where I was confused - I was looking at the javadoc for TermsEnum,
which says you must call next or seek before getting the term - but I
was more confused than straightened out when I saw FilteredTermsEnum
said the enum must already be positioned at the first term - it didn't
dawn on me that
82 matches
Mail list logo
