Re: FieldCacheImpl concurrency

2010-02-11 Thread Shay Banon
On Thu, Feb 11, 2010 at 5:41 PM, Yonik Seeley wrote: > On Thu, Feb 11, 2010 at 9:54 AM, Shay Banon wrote: > >I would like to try and improve concurrency in Lucene in several > places, > > and thought I would start with FieldCacheImpl. The implementation is > heavily > > synchronized on both a

[jira] Commented: (LUCENE-1720) TimeLimitedIndexReader and associated utility class

2010-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832858#action_12832858 ] Shai Erera commented on LUCENE-1720: Thanks Mark. I will take a look at the patch a bi

Hudson build is back to normal : Lucene-trunk #1092

2010-02-11 Thread Apache Hudson Server
See - To unsubscribe, e-mail: java-dev-unsubscr...@lucene.apache.org For additional commands, e-mail: java-dev-h...@lucene.apache.org

[jira] Commented: (LUCENE-2089) explore using automaton for fuzzyquery

2010-02-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832822#action_12832822 ] Robert Muir commented on LUCENE-2089: - thanks, this will give you something to play wi

[jira] Commented: (LUCENE-2089) explore using automaton for fuzzyquery

2010-02-11 Thread Aaron McCurry (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832819#action_12832819 ] Aaron McCurry commented on LUCENE-2089: --- Sure I will give it a try, still wrapping m

[jira] Updated: (LUCENE-1990) Add unsigned packed int impls in oal.util

2010-02-11 Thread Toke Eskildsen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1990?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Toke Eskildsen updated LUCENE-1990: --- Attachment: LUCENE-1990-te20100212.patch I've read through the comments on LUCENE-1990 and i

[jira] Commented: (LUCENE-2089) explore using automaton for fuzzyquery

2010-02-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832817#action_12832817 ] Robert Muir commented on LUCENE-2089: - bq. Excuse my ignorance, but what is a DFA? h

[jira] Commented: (LUCENE-2089) explore using automaton for fuzzyquery

2010-02-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832814#action_12832814 ] Robert Muir commented on LUCENE-2089: - bq. So I have to ask, who has the entire unicod

[jira] Issue Comment Edited: (LUCENE-2089) explore using automaton for fuzzyquery

2010-02-11 Thread Aaron McCurry (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832798#action_12832798 ] Aaron McCurry edited comment on LUCENE-2089 at 2/12/10 2:22 AM:

[jira] Commented: (LUCENE-2089) explore using automaton for fuzzyquery

2010-02-11 Thread Aaron McCurry (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832798#action_12832798 ] Aaron McCurry commented on LUCENE-2089: --- {quote} Aaron i think generation may pose a

[jira] Commented: (LUCENE-2089) explore using automaton for fuzzyquery

2010-02-11 Thread Aaron McCurry (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832794#action_12832794 ] Aaron McCurry commented on LUCENE-2089: --- Excuse my ignorance, but what is a DFA? >

[jira] Commented: (LUCENE-2089) explore using automaton for fuzzyquery

2010-02-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832789#action_12832789 ] Robert Muir commented on LUCENE-2089: - bq. But who would use standard distance with su

[jira] Commented: (LUCENE-2089) explore using automaton for fuzzyquery

2010-02-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832785#action_12832785 ] Robert Muir commented on LUCENE-2089: - Aaron i think generation may pose a problem for

[jira] Commented: (LUCENE-2089) explore using automaton for fuzzyquery

2010-02-11 Thread Aaron McCurry (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832773#action_12832773 ] Aaron McCurry commented on LUCENE-2089: --- I have written a levenstein generator today

[jira] Commented: (LUCENE-2089) explore using automaton for fuzzyquery

2010-02-11 Thread Eks Dev (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832741#action_12832741 ] Eks Dev commented on LUCENE-2089: - {quote} I assume you mean by weighted edit distance tha

[jira] Commented: (LUCENE-2257) relax the per-segment max unique term limit

2010-02-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832729#action_12832729 ] Michael McCandless commented on LUCENE-2257: bq. With the patch, we don't see

[jira] Updated: (LUCENE-2257) relax the per-segment max unique term limit

2010-02-11 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Michael McCandless updated LUCENE-2257: --- Attachment: LUCENE-2257.patch > relax the per-segment max unique term limit > --

[jira] Commented: (LUCENE-1720) TimeLimitedIndexReader and associated utility class

2010-02-11 Thread Mark Harwood (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832721#action_12832721 ] Mark Harwood commented on LUCENE-1720: -- bq. When's this ready to test with Solr? I t

[jira] Commented: (LUCENE-2257) relax the per-segment max unique term limit

2010-02-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832698#action_12832698 ] Robert Muir commented on LUCENE-2257: - bq. (I discovered that queries containing Korea

[jira] Commented: (LUCENE-2257) relax the per-segment max unique term limit

2010-02-11 Thread Tom Burton-West (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2257?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832689#action_12832689 ] Tom Burton-West commented on LUCENE-2257: - Hi Michael, Thanks for your help. We m

[jira] Commented: (LUCENE-2089) explore using automaton for fuzzyquery

2010-02-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832687#action_12832687 ] Robert Muir commented on LUCENE-2089: - bq. Imo, the only thing that would work better

[jira] Commented: (LUCENE-2261) configurable MultiTermQuery TopTermsScoringBooleanRewrite pq size

2010-02-11 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832683#action_12832683 ] Uwe Schindler commented on LUCENE-2261: --- Looks good when gaining a first insight. I

[jira] Updated: (LUCENE-2261) configurable MultiTermQuery TopTermsScoringBooleanRewrite pq size

2010-02-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-2261: Attachment: LUCENE-2261.patch sorry, i created a javadoc warning, (TOP_TERMS singleton was referen

[jira] Updated: (LUCENE-2261) configurable MultiTermQuery TopTermsScoringBooleanRewrite pq size

2010-02-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-2261: Attachment: LUCENE-2261.patch here is a patch with uwe's suggestions. now that fuzzyquery supports

[jira] Commented: (LUCENE-1720) TimeLimitedIndexReader and associated utility class

2010-02-11 Thread Jason Rutherglen (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832638#action_12832638 ] Jason Rutherglen commented on LUCENE-1720: -- When's this ready to test with Solr?

[jira] Updated: (LUCENE-2261) configurable MultiTermQuery TopTermsScoringBooleanRewrite pq size

2010-02-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-2261: Attachment: LUCENE-2261.patch the previous patch was wrong for readResolve, here is a fix. > con

[jira] Commented: (LUCENE-2261) configurable MultiTermQuery TopTermsScoringBooleanRewrite pq size

2010-02-11 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832607#action_12832607 ] Uwe Schindler commented on LUCENE-2261: --- Patch looks good, some things because of se

[jira] Updated: (LUCENE-2261) configurable MultiTermQuery TopTermsScoringBooleanRewrite pq size

2010-02-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir updated LUCENE-2261: Attachment: LUCENE-2261.patch attached is a patch. i changed FuzzyQueries pq test to use this so i

[jira] Updated: (LUCENE-1720) TimeLimitedIndexReader and associated utility class

2010-02-11 Thread Mark Harwood (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Harwood updated LUCENE-1720: - Attachment: Lucene-1720.patch Moved ATM to o.a.l.util package Added isProjectedToTimeout method

[jira] Created: (LUCENE-2261) configurable MultiTermQuery TopTermsScoringBooleanRewrite pq size

2010-02-11 Thread Robert Muir (JIRA)
configurable MultiTermQuery TopTermsScoringBooleanRewrite pq size - Key: LUCENE-2261 URL: https://issues.apache.org/jira/browse/LUCENE-2261 Project: Lucene - Java Issue Type: Im

Re: FieldCacheImpl concurrency

2010-02-11 Thread Yonik Seeley
On Thu, Feb 11, 2010 at 9:54 AM, Shay Banon wrote: >    I would like to try and improve concurrency in Lucene in several places, > and thought I would start with FieldCacheImpl. The implementation is heavily > synchronized on both a global map and on creation values for a pretty > heavily used pat

[jira] Updated: (LUCENE-2260) AttributeSource holds strong reference to class instances and prevents unloading e.g. in Solr if webapplication reload and custom attributes in separate classloaders are

2010-02-11 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-2260: -- Attachment: LUCENE-2260-lucene29.patch Patch for 2.9 branch (without Java 5 generics) > Attri

FieldCacheImpl concurrency

2010-02-11 Thread Shay Banon
Hi, I would like to try and improve concurrency in Lucene in several places, and thought I would start with FieldCacheImpl. The implementation is heavily synchronized on both a global map and on creation values for a pretty heavily used path (get). I think the weak hash map is a good solution (

RE: [jira] Commented: (LUCENE-2089) explore using automaton for fuzzyquery

2010-02-11 Thread Fuad Efendi
Hi Eks Dev, thanks for the comment! I like this: > If you need too use this, nothing simpler, you do not even need pair > comparison (aka traversal), just Index terms split into bigrams and > search with standard Query. And, I need to study all the tricks of Automaton... -Fuad > -Orig

[jira] Resolved: (LUCENE-2080) Improve the documentation of Version

2010-02-11 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2080?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Robert Muir resolved LUCENE-2080. - Resolution: Fixed Committed revision 908975. > Improve the documentation of Version > -

[jira] Commented: (LUCENE-1720) TimeLimitedIndexReader and associated utility class

2010-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832501#action_12832501 ] Shai Erera commented on LUCENE-1720: BTW, perhaps to allow even finer granularity and

[jira] Commented: (LUCENE-1720) TimeLimitedIndexReader and associated utility class

2010-02-11 Thread Mark Harwood (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832500#action_12832500 ] Mark Harwood commented on LUCENE-1720: -- I'll pick this up > TimeLimitedIndexReader a

[jira] Updated: (LUCENE-2260) AttributeSource holds strong reference to class instances and prevents unloading e.g. in Solr if webapplication reload and custom attributes in separate classloaders are

2010-02-11 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-2260: -- Attachment: LUCENE-2260.patch Improved patch, now all class references are weak. The assumptio

[jira] Commented: (LUCENE-1720) TimeLimitedIndexReader and associated utility class

2010-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832491#action_12832491 ] Shai Erera commented on LUCENE-1720: bq. We can always provide a convenience wrapper m

[jira] Commented: (LUCENE-1720) TimeLimitedIndexReader and associated utility class

2010-02-11 Thread Mark Harwood (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832483#action_12832483 ] Mark Harwood commented on LUCENE-1720: -- Agreed, might be useful to provide boolean re

[jira] Updated: (LUCENE-2260) AttributeSource holds strong reference to class instances and prevents unloading e.g. in Solr if webapplication reload and custom attributes in separate classloaders are

2010-02-11 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-2260: -- Attachment: LUCENE-2260.patch Attached patch. I will commit this in a day and also merge to 2.

[jira] Commented: (LUCENE-1720) TimeLimitedIndexReader and associated utility class

2010-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832480#action_12832480 ] Shai Erera commented on LUCENE-1720: Liked the formatting. Didn't know you can do that

[jira] Created: (LUCENE-2260) AttributeSource holds strong reference to class instances and prevents unloading e.g. in Solr if webapplication reload and custom attributes in separate classloaders are

2010-02-11 Thread Uwe Schindler (JIRA)
AttributeSource holds strong reference to class instances and prevents unloading e.g. in Solr if webapplication reload and custom attributes in separate classloaders are used (e.g. in the Solr plugins classloader) ---

[jira] Commented: (LUCENE-1720) TimeLimitedIndexReader and associated utility class

2010-02-11 Thread Mark Harwood (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832470#action_12832470 ] Mark Harwood commented on LUCENE-1720: -- The change to ATM isn't that big - as you say

[jira] Commented: (LUCENE-1720) TimeLimitedIndexReader and associated utility class

2010-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832461#action_12832461 ] Shai Erera commented on LUCENE-1720: I like the idea of adding the projected activity

[jira] Updated: (LUCENE-2154) Need a clean way for Dir/MultiReader to "merge" the AttributeSources of the sub-readers

2010-02-11 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-2154: -- Attachment: LUCENE-2154.patch I had some more fun. Made ProxyAttributeSource non-final and add

[jira] Commented: (LUCENE-1720) TimeLimitedIndexReader and associated utility class

2010-02-11 Thread Mark Harwood (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832444#action_12832444 ] Mark Harwood commented on LUCENE-1720: -- Thanks for the updates, Shai. Agreed on remo

Re: Build failed in Hudson: Lucene-trunk #1091

2010-02-11 Thread Michael McCandless
This is LUCENE-2118 -- it strikes every so often. I think it's harmless (but really annoying). It looks like a corner case in the merge policy where somehow a level is able to have 11 segments after merging thinks it's done. Mike On Thu, Feb 11, 2010 at 3:03 AM, Uwe Schindler wrote: > Really c

[jira] Updated: (LUCENE-2154) Need a clean way for Dir/MultiReader to "merge" the AttributeSources of the sub-readers

2010-02-11 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uwe Schindler updated LUCENE-2154: -- Attachment: LUCENE-2154.patch Here is a first patch about cglib-generated proxy attributes. I

[jira] Commented: (LUCENE-1720) TimeLimitedIndexReader and associated utility class

2010-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832427#action_12832427 ] Shai Erera commented on LUCENE-1720: BTW Mark, if we assume the number of threads that

[jira] Updated: (LUCENE-1720) TimeLimitedIndexReader and associated utility class

2010-02-11 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1720?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Shai Erera updated LUCENE-1720: --- Attachment: LUCENE-1720.patch Collected all the files in the issue into a single .patch file. I also

[jira] Commented: (LUCENE-2089) explore using automaton for fuzzyquery

2010-02-11 Thread Eks Dev (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2089?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832424#action_12832424 ] Eks Dev commented on LUCENE-2089: - {quote} What about this, http://www.catalysoft.com/art

RE: Build failed in Hudson: Lucene-trunk #1091

2010-02-11 Thread Uwe Schindler
Really cool: This time we hit the failure during the clover run: [junit] Testsuite: org.apache.lucene.index.TestIndexWriterMergePolicy [junit] Tests run: 6, Failures: 1, Errors: 0, Time elapsed: 28.519 sec [junit] [junit] Testcase: testMaxBufferedDocsChange(org.apache.lucene.inde