Re: [PATCH] Bug on BrazilianAnalyzer

2008-12-02 Thread Michael McCandless
Rafael, Could you work these changes into a patch, add a test case, and open a Jira issue? Maybe first make the simple fixes (removing final, moving LowerCaseFilter up in the chain), and then as a 2nd issue this deeper refactoring of all StemFilters? Thanks. I agree the original issue

Re: [PATCH] Bug on BrazilianAnalyzer

2008-11-24 Thread Adriano Crestani
Hi Rafael, I kind of agree with you. Practically all the StemFilters have the same logic, they might be combined into only one class. All StemFilters seems to have a setStemmer already, we could keep that and also allow to pass the stemmer as a constructor paramenter, like you said. I think you ca

Re: [PATCH] Bug on BrazilianAnalyzer

2008-11-21 Thread Rafael Cunha de Almeida
On Fri, 21 Nov 2008 16:46:30 -0200 Rafael Cunha de Almeida <[EMAIL PROTECTED]> wrote: > On Mon, 17 Nov 2008 19:58:47 -0800 > "Adriano Crestani" <[EMAIL PROTECTED]> wrote: > > > Hi Rafael, > > > > What is your scenario? > > > > Maybe it was defined this way so it do not filter uppercased stop wo

Re: [PATCH] Bug on BrazilianAnalyzer

2008-11-21 Thread Rafael Cunha de Almeida
On Mon, 17 Nov 2008 19:58:47 -0800 "Adriano Crestani" <[EMAIL PROTECTED]> wrote: > Hi Rafael, > > What is your scenario? > > Maybe it was defined this way so it do not filter uppercased stop words. > Like, for example, the downcased word "se" is a stopword, but the uppercased > "SE" stands for "

Re: [PATCH] Bug on BrazilianAnalyzer

2008-11-17 Thread Adriano Crestani
Hi Rafael, What is your scenario? Maybe it was defined this way so it do not filter uppercased stop words. Like, for example, the downcased word "se" is a stopword, but the uppercased "SE" stands for "Sergipe", a brazilian state, so it should not be filtered. Best Regards, Adriano Crestani On M

[PATCH] Bug on BrazilianAnalyzer

2008-11-17 Thread Rafael Cunha de Almeida
Following is the patch for what I think is a bug on the BrazilianAnalyzer. The default stopwords list is all in lowercase, so it will only work if the LowerCaseFilter comes first of if the StopWordFilter is set to ignore case. Since the LowerCaseFilter is instantiated anyway I just changed its ord