[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12735253#action_12735253
]
Uwe Schindler commented on LUCENE-1693:
---
Committed revision: 797727
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12734955#action_12734955
]
Michael Busch commented on LUCENE-1693:
---
{quote}
Token is no longer deprecated, but
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12734959#action_12734959
]
Uwe Schindler commented on LUCENE-1693:
---
And in 3.0 all my phantastic
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12734963#action_12734963
]
Uwe Schindler commented on LUCENE-1693:
---
bq. if you don't want to deal with multiple
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12734982#action_12734982
]
Michael Busch commented on LUCENE-1693:
---
{quote}
So in general you can add an Token
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12735114#action_12735114
]
Michael Busch commented on LUCENE-1693:
---
Grant, are you still reviewing? I was going
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12735119#action_12735119
]
Grant Ingersoll commented on LUCENE-1693:
-
Go ahead, I'm satisfied.
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12735123#action_12735123
]
Michael Busch commented on LUCENE-1693:
---
Cool thanks for reviewing.
I'll commit
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12735124#action_12735124
]
Robert Muir commented on LUCENE-1693:
-
{quote}
I completely agree. We should
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12735125#action_12735125
]
Grant Ingersoll commented on LUCENE-1693:
-
Actually, one thing I still don't get:
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12735133#action_12735133
]
Michael Busch commented on LUCENE-1693:
---
{quote}
I don't think the WARNING:
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12735134#action_12735134
]
Michael Busch commented on LUCENE-1693:
---
{quote}
What happens to the attributes that
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12735210#action_12735210
]
Mark Miller commented on LUCENE-1693:
-
Not sure what issue it stems from, but Token
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12735215#action_12735215
]
Michael Busch commented on LUCENE-1693:
---
{quote}
Not sure what issue it stems from,
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12734867#action_12734867
]
Grant Ingersoll commented on LUCENE-1693:
-
Checking now.
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12734888#action_12734888
]
Grant Ingersoll commented on LUCENE-1693:
-
{quote}Token is no longer deprecated,
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733580#action_12733580
]
Michael McCandless commented on LUCENE-1693:
OK I looked at the latest patch!
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733604#action_12733604
]
Grant Ingersoll commented on LUCENE-1693:
-
One of the things that works really
bq. * Are we going to keep Token.java or not? (Current patch still has it
deprecated).
I need to know this as well - I have to make a new Token class for the
Highlighter package if this one is deprecated. It would seem a convenience to
keep it around.
On Tue, Jul 21, 2009 at 8:51 AM, Grant
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733761#action_12733761
]
Uwe Schindler commented on LUCENE-1693:
---
Mark Miller on java-dev:
bq. * Are we
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733765#action_12733765
]
Uwe Schindler commented on LUCENE-1693:
---
{quote}
bq. * Are we going to keep
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733931#action_12733931
]
Michael Busch commented on LUCENE-1693:
---
I think the points listed in the
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733070#action_12733070
]
Uwe Schindler commented on LUCENE-1693:
---
Michael: can you wait for comments and
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733081#action_12733081
]
Michael Busch commented on LUCENE-1693:
---
Hi Uwe,
I haven't reviewed the latest
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733083#action_12733083
]
Uwe Schindler commented on LUCENE-1693:
---
OK!
I forgot to mention: I replaced the
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733091#action_12733091
]
Michael Busch commented on LUCENE-1693:
---
I like the cache you added to
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733095#action_12733095
]
Uwe Schindler commented on LUCENE-1693:
---
Yes, good idea. I added it locally, works
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12733096#action_12733096
]
Michael Busch commented on LUCENE-1693:
---
yep, did already and all tests pass!
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732869#action_12732869
]
Michael McCandless commented on LUCENE-1693:
bq. Given the difficulty of using
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732878#action_12732878
]
Uwe Schindler commented on LUCENE-1693:
---
In this case we should rename TeeSink to
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732407#action_12732407
]
Michael Busch commented on LUCENE-1693:
---
{quote}
As CachingTokenFilter has no API to
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732450#action_12732450
]
Uwe Schindler commented on LUCENE-1693:
---
Patch looks good.
Only one thing: If you
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732458#action_12732458
]
Michael Busch commented on LUCENE-1693:
---
{quote}
Or we do not call the method
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732478#action_12732478
]
Uwe Schindler commented on LUCENE-1693:
---
bq. +1. Let's do that.
OK, I change this
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732483#action_12732483
]
Mark Miller commented on LUCENE-1693:
-
bq. ...and Mike said all others are trivial
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732749#action_12732749
]
Michael Busch commented on LUCENE-1693:
---
{quote}
Michael, any idea? The
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732757#action_12732757
]
Yonik Seeley commented on LUCENE-1693:
--
bq. I have personally never used the Tee/Sink
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732762#action_12732762
]
Uwe Schindler commented on LUCENE-1693:
---
In my opinion, this test that I was not
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732767#action_12732767
]
Uwe Schindler commented on LUCENE-1693:
---
So the simple case of an
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732769#action_12732769
]
Grant Ingersoll commented on LUCENE-1693:
-
bq. Who invented the whole Tee/Sink
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732772#action_12732772
]
Grant Ingersoll commented on LUCENE-1693:
-
It is not theoretical at all, even if
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732773#action_12732773
]
Michael Busch commented on LUCENE-1693:
---
{quote}
I have never heard of Tee/Sink
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12732781#action_12732781
]
Uwe Schindler commented on LUCENE-1693:
---
bq. Hey, stop insulting my awesome
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12731893#action_12731893
]
Uwe Schindler commented on LUCENE-1693:
---
Ok looks good. I think you will go to bed
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12731896#action_12731896
]
Grant Ingersoll commented on LUCENE-1693:
-
Favor to ask, when this is ready to
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12731947#action_12731947
]
Uwe Schindler commented on LUCENE-1693:
---
I forgot: I also implemented the final
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12731315#action_12731315
]
Michael Busch commented on LUCENE-1693:
---
{quote}
There is one case, when it also
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12731317#action_12731317
]
Michael Busch commented on LUCENE-1693:
---
{quote}
In my opinion, we should remove the
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12731330#action_12731330
]
Uwe Schindler commented on LUCENE-1693:
---
bq. What we really should have is an
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12731334#action_12731334
]
Michael Busch commented on LUCENE-1693:
---
{quote}
Have you seen my backwards
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12731337#action_12731337
]
Uwe Schindler commented on LUCENE-1693:
---
bq. But I'm not sure how realistic this
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12731555#action_12731555
]
Uwe Schindler commented on LUCENE-1693:
---
After the whole day thinking about a
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12730993#action_12730993
]
Uwe Schindler commented on LUCENE-1693:
---
I forgot:
I also added the TestCompatibilty
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12731289#action_12731289
]
Michael Busch commented on LUCENE-1693:
---
So if people are using streams/filters that
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12730306#action_12730306
]
Uwe Schindler commented on LUCENE-1693:
---
Mike implemented a nice idea to solve the
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12730003#action_12730003
]
Mark Miller commented on LUCENE-1693:
-
Token is still deprecated in the latest patch -
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12729565#action_12729565
]
Michael Busch commented on LUCENE-1693:
---
Thanks for all your hard work here, Uwe.
I
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12729567#action_12729567
]
Uwe Schindler commented on LUCENE-1693:
---
Thanks!
Before going to bed yesterday, I
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12729568#action_12729568
]
Michael Busch commented on LUCENE-1693:
---
I agree that in any case we should
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12729819#action_12729819
]
Michael McCandless commented on LUCENE-1693:
I'm still trying to wrap my brain
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12729823#action_12729823
]
Yonik Seeley commented on LUCENE-1693:
--
bq. One concern is: TokenStream.initialize
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12728823#action_12728823
]
Mark Miller commented on LUCENE-1693:
-
Mr. Busch my friend, I'll buy both you and Uwe
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12728879#action_12728879
]
Michael Busch commented on LUCENE-1693:
---
Alright, I hope you are coming to Oakland
Hows the progress here guys? I have 2 or 3 issues that relate to this, and I
really don't want to commit/finish them until this is done ...
://www.thetaphi.de
eMail: u...@thetaphi.de
_
From: Mark Miller [mailto:markrmil...@gmail.com]
Sent: Wednesday, July 01, 2009 3:14 PM
To: java-dev@lucene.apache.org
Subject: Re: [jira] Commented: (LUCENE-1693) AttributeSource/TokenStream API
improvements
Hows the progress here guys? I have 2 or 3
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12726066#action_12726066
]
Uwe Schindler commented on LUCENE-1693:
---
After thinking one round about it again.
.-Meier-Allee 63, D-28213 Bremen
http://www.thetaphi.de
eMail: u...@thetaphi.de
_
From: Mark Miller [mailto:markrmil...@gmail.com]
Sent: Wednesday, July 01, 2009 3:14 PM
To: java-dev@lucene.apache.org
Subject: Re: [jira] Commented: (LUCENE-1693) AttributeSource/TokenStream API
improvements
I hope Michael will have time to review this, too. It seems that we are
the only ones who can follow the thread J and all these “hey here is a BW
break…” hick-hacks.
Personally, I'm not a big fan of the new API. I think its going to be *much*
harder for new users to grok/manipulate. These back
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12723473#action_12723473
]
Uwe Schindler commented on LUCENE-1693:
---
{quote}
bq. The big difference is, that you
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12723549#action_12723549
]
Uwe Schindler commented on LUCENE-1693:
---
bq. But I'll definitely buy Uwe a beer if
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12723720#action_12723720
]
Michael Busch commented on LUCENE-1693:
---
Sorry, I don't want to be the bad guy here,
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12723727#action_12723727
]
Uwe Schindler commented on LUCENE-1693:
---
In your example, you mean SinkTokenizer is
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12723749#action_12723749
]
Uwe Schindler commented on LUCENE-1693:
---
bq. Not sure if we're talking about the
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12723751#action_12723751
]
Uwe Schindler commented on LUCENE-1693:
---
One solution around this poblem would be to
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12723759#action_12723759
]
Michael Busch commented on LUCENE-1693:
---
{quote}
I decided a while ago that you'll
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12723345#action_12723345
]
Mark Miller commented on LUCENE-1693:
-
How is this patch coming?
Do you think
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12723351#action_12723351
]
Uwe Schindler commented on LUCENE-1693:
---
Michael did not yet respond (I think he is
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12723353#action_12723353
]
Uwe Schindler commented on LUCENE-1693:
---
By the way: Token is no longer deprecated,
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12723362#action_12723362
]
Mark Miller commented on LUCENE-1693:
-
Ah, nice - I had to re-implement it for one or
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12723369#action_12723369
]
Mark Miller commented on LUCENE-1693:
-
bq. The big difference is, that you do not need
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721722#action_12721722
]
Michael Busch commented on LUCENE-1693:
---
Sorry, Uwe, I was really busy today. I'll
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721795#action_12721795
]
Uwe Schindler commented on LUCENE-1693:
---
During my tests I found a small problem
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721135#action_12721135
]
Michael Busch commented on LUCENE-1693:
---
{quote}
For backwards-compatiblility we
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721142#action_12721142
]
Uwe Schindler commented on LUCENE-1693:
---
OK, we can merge our patches then! At the
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721158#action_12721158
]
Uwe Schindler commented on LUCENE-1693:
---
By the way, I tested Solr's token streams
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721281#action_12721281
]
Grant Ingersoll commented on LUCENE-1693:
-
{quote}
By the way, I tested Solr's
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12721426#action_12721426
]
Uwe Schindler commented on LUCENE-1693:
---
I only tested performance with the lucene
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720524#action_12720524
]
Shai Erera commented on LUCENE-1693:
Doesn't this mean that we need to change all our
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720529#action_12720529
]
Michael Busch commented on LUCENE-1693:
---
I don't think we mention subclassing of
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720530#action_12720530
]
Michael Busch commented on LUCENE-1693:
---
But I'll definitely buy Uwe a beer if he
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720534#action_12720534
]
Uwe Schindler commented on LUCENE-1693:
---
Hi Michael,
in principle your test is
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720538#action_12720538
]
Michael Busch commented on LUCENE-1693:
---
OK, what about this sentence in Token.java:
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720550#action_12720550
]
Uwe Schindler commented on LUCENE-1693:
---
OK, I have a solution:
I write a wrapper
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720562#action_12720562
]
Michael Busch commented on LUCENE-1693:
---
For caching:
I guess you would have to
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720568#action_12720568
]
Uwe Schindler commented on LUCENE-1693:
---
bq. I think you should try it out and see
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720571#action_12720571
]
Michael Busch commented on LUCENE-1693:
---
{quote}
I am working on that, I have a
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720676#action_12720676
]
Uwe Schindler commented on LUCENE-1693:
---
Hi Michael,
I did not do any performance
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720692#action_12720692
]
Shai Erera commented on LUCENE-1693:
You can run tokenize.alg which invokes the
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720794#action_12720794
]
Michael Busch commented on LUCENE-1693:
---
I'm looking at TokenStream.next():
[
https://issues.apache.org/jira/browse/LUCENE-1693?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=12720809#action_12720809
]
Uwe Schindler commented on LUCENE-1693:
---
The code is almost identical to before, the
1 - 100 of 136 matches
Mail list logo
