[jira] Commented: (LUCENE-1852) Fix remaining localization test failures in lucene

2009-08-25 Thread Michael Busch (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747265#action_12747265 ] Michael Busch commented on LUCENE-1852: --- {quote} it is my understanding these are th

[jira] Commented: (LUCENE-1852) Fix remaining localization test failures in lucene

2009-08-24 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747254#action_12747254 ] Robert Muir commented on LUCENE-1852: - i will mention under some of these locales, bac

[jira] Commented: (LUCENE-1852) Fix remaining localization test failures in lucene

2009-08-24 Thread Michael Busch (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747253#action_12747253 ] Michael Busch commented on LUCENE-1852: --- great work and testing! I'll commit shortl

[jira] Commented: (LUCENE-1852) Fix remaining localization test failures in lucene

2009-08-24 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747251#action_12747251 ] Robert Muir commented on LUCENE-1852: - in my opinion the issue should be resolved. I

[jira] Commented: (LUCENE-1852) Fix remaining localization test failures in lucene

2009-08-24 Thread Michael Busch (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747250#action_12747250 ] Michael Busch commented on LUCENE-1852: --- Shall I commit this one too? > Fix remaini

[jira] Commented: (LUCENE-1852) Fix remaining localization test failures in lucene

2009-08-24 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747245#action_12747245 ] Robert Muir commented on LUCENE-1852: - Uwe, no. But i only tested under the followin

[jira] Commented: (LUCENE-1852) Fix remaining localization test failures in lucene

2009-08-24 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747243#action_12747243 ] Uwe Schindler commented on LUCENE-1852: --- Looks good. Robert, did you find any other

[jira] Commented: (LUCENE-1852) Fix remaining localization test failures in lucene

2009-08-24 Thread Robert Muir (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747193#action_12747193 ] Robert Muir commented on LUCENE-1852: - Luis, thanks for the review. yes this one needs

[jira] Commented: (LUCENE-1852) Fix remaining localization test failures in lucene

2009-08-24 Thread Luis Alves (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-1852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747191#action_12747191 ] Luis Alves commented on LUCENE-1852: I reviewed the code, all changes look good to me.