[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847034#action_12847034
]
Shai Erera commented on LUCENE-2320:
Thanks Mike !
> Add MergePolicy to IndexWriterCo
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847008#action_12847008
]
Michael McCandless commented on LUCENE-2320:
The patch looks great Shai -- I p
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846997#action_12846997
]
Shai Erera commented on LUCENE-2320:
Mike - are you reviewing it? I think I fixed all
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846665#action_12846665
]
Michael McCandless commented on LUCENE-2320:
Shai this patch looks good -- tha
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846622#action_12846622
]
Mark Miller commented on LUCENE-2320:
-
+1 - I've had to do this in the past too. Just
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846621#action_12846621
]
Michael McCandless commented on LUCENE-2320:
I think it's OK to add stubs to s
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846619#action_12846619
]
Uwe Schindler commented on LUCENE-2320:
---
In that case just remove the test in backwa
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846615#action_12846615
]
Shai Erera commented on LUCENE-2320:
Uwe, I'm pretty familiar w/ how backwards goes ..
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846614#action_12846614
]
Uwe Schindler commented on LUCENE-2320:
---
Its normally not the idea of backwards test
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846451#action_12846451
]
Michael McCandless commented on LUCENE-2320:
Patch looks good Shai! I'd rathe
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845930#action_12845930
]
Shai Erera commented on LUCENE-2320:
But it's MP which requires IW. So how will your p
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845530#action_12845530
]
Earwin Burrfoot commented on LUCENE-2320:
-
We could split MergePolicy in two - cla
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845490#action_12845490
]
Shai Erera commented on LUCENE-2320:
The thing is that we were at that position alread
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845370#action_12845370
]
Michael McCandless commented on LUCENE-2320:
bq. Or, maybe, we should think of
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845167#action_12845167
]
Earwin Burrfoot commented on LUCENE-2320:
-
Or, maybe, we should think of MergePoli
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845077#action_12845077
]
Shai Erera commented on LUCENE-2320:
Ok, I'll update that part of CHANGES. The convers
[
https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845064#action_12845064
]
Michael McCandless commented on LUCENE-2320:
This sounds good Shai!
This is t
17 matches
Mail list logo