[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-18 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847034#action_12847034 ] Shai Erera commented on LUCENE-2320: Thanks Mike ! > Add MergePolicy to IndexWriterCo

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-18 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847008#action_12847008 ] Michael McCandless commented on LUCENE-2320: The patch looks great Shai -- I p

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-18 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846997#action_12846997 ] Shai Erera commented on LUCENE-2320: Mike - are you reviewing it? I think I fixed all

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846665#action_12846665 ] Michael McCandless commented on LUCENE-2320: Shai this patch looks good -- tha

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-17 Thread Mark Miller (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846622#action_12846622 ] Mark Miller commented on LUCENE-2320: - +1 - I've had to do this in the past too. Just

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846621#action_12846621 ] Michael McCandless commented on LUCENE-2320: I think it's OK to add stubs to s

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846619#action_12846619 ] Uwe Schindler commented on LUCENE-2320: --- In that case just remove the test in backwa

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-17 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846615#action_12846615 ] Shai Erera commented on LUCENE-2320: Uwe, I'm pretty familiar w/ how backwards goes ..

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-17 Thread Uwe Schindler (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846614#action_12846614 ] Uwe Schindler commented on LUCENE-2320: --- Its normally not the idea of backwards test

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-17 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12846451#action_12846451 ] Michael McCandless commented on LUCENE-2320: Patch looks good Shai! I'd rathe

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-16 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845930#action_12845930 ] Shai Erera commented on LUCENE-2320: But it's MP which requires IW. So how will your p

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-15 Thread Earwin Burrfoot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845530#action_12845530 ] Earwin Burrfoot commented on LUCENE-2320: - We could split MergePolicy in two - cla

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-15 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845490#action_12845490 ] Shai Erera commented on LUCENE-2320: The thing is that we were at that position alread

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-15 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845370#action_12845370 ] Michael McCandless commented on LUCENE-2320: bq. Or, maybe, we should think of

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-14 Thread Earwin Burrfoot (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845167#action_12845167 ] Earwin Burrfoot commented on LUCENE-2320: - Or, maybe, we should think of MergePoli

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-14 Thread Shai Erera (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845077#action_12845077 ] Shai Erera commented on LUCENE-2320: Ok, I'll update that part of CHANGES. The convers

[jira] Commented: (LUCENE-2320) Add MergePolicy to IndexWriterConfig

2010-03-14 Thread Michael McCandless (JIRA)
[ https://issues.apache.org/jira/browse/LUCENE-2320?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12845064#action_12845064 ] Michael McCandless commented on LUCENE-2320: This sounds good Shai! This is t