[
https://issues.apache.org/jira/browse/LUCENE-686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12478594
]
Michael McCandless commented on LUCENE-686:
---
I just committed some fixes in LUCENE-823 that could apply her
[
http://issues.apache.org/jira/browse/LUCENE-686?page=comments#action_12447596 ]
Steven Parkes commented on LUCENE-686:
--
Came across these:
http://www.gossamer-threads.com/lists/lucene/java-dev/34085#34085
http://www.gossamer-threads.com/l
[
http://issues.apache.org/jira/browse/LUCENE-686?page=comments#action_12445027 ]
Steven Parkes commented on LUCENE-686:
--
You're right, and that's actually at the heart of the issue.
Seems like part of what needs to be clarified is what clo
[
http://issues.apache.org/jira/browse/LUCENE-686?page=comments#action_12444766 ]
Ning Li commented on LUCENE-686:
But removing TermDocs.close() will leave IndexInput.close() in a
similar half-in/half-out situation: e.g. close() will not be call
[
http://issues.apache.org/jira/browse/LUCENE-686?page=comments#action_12444758 ]
Steven Parkes commented on LUCENE-686:
--
Well, this has been a nice example to drive me into some of the internals.
It seems like close() methods are around in
[
http://issues.apache.org/jira/browse/LUCENE-686?page=comments#action_12444742 ]
Doron Cohen commented on LUCENE-686:
An example of how current Lucene code relies on not having to close resoures,
in PhraseQuery:
...
scorer(IndexRead
[
http://issues.apache.org/jira/browse/LUCENE-686?page=comments#action_1238 ]
Hoss Man commented on LUCENE-686:
-
Quick summary of some discussion from the mailing list...
1) i replied to paul's comments in the bug indicating that while there
The bottom line is:
> 1) TermDocs has a close method
> 2) anything implimenting TermDocs should be able to trust
that
> close() will be called
> 3) anything iterating over a TermDocs should call close()
>
> ...ergo: TermScorer needs a c
On Wednesday 18 October 2006 06:21, Chris Hostetter wrote:
> : > : When custom Scorers and/or Directories need a close method, it can
> : > : also be provided by subclassing Scorer, IndexSearcher and Directory
>
> : > it seems like that would handicap adoption of new
Queries/Directories ...
> : >
: > : When custom Scorers and/or Directories need a close method, it can
: > : also be provided by subclassing Scorer, IndexSearcher and Directory
: > it seems like that would handicap adoption of new Queries/Directories ...
: > I don't know how many people would have been interested in
: > Consta
A new scorer that requires reclaiming resources could be used by many
other scorers such as boolean scorers and conjunction scorers. Then
those scorers should have a closing method and so do the ones use
those scorers... A general closing method would be better, wouldn't
it?
-
On Tuesday 17 October 2006 21:10, Chris Hostetter wrote:
>
> : When custom Scorers and/or Directories need a close method, it can
> : also be provided by subclassing Scorer, IndexSearcher and Directory
> : in the custom code.
> : Not providing this close method in the Lucene core passes the messag
: When custom Scorers and/or Directories need a close method, it can
: also be provided by subclassing Scorer, IndexSearcher and Directory
: in the custom code.
: Not providing this close method in the Lucene core passes the message
: that a working implementation is possible without it.
it seems
On Tuesday 17 October 2006 20:32, Chris Hostetter wrote:
>
> : But as long as there is no real a memory leak, what is the point of
> : adding this close functionality?
>
> I think the concern is not so much that Lucene core as is has any leaks --
> but that subclasses of core implimentations have
: But as long as there is no real a memory leak, what is the point of
: adding this close functionality?
I think the concern is not so much that Lucene core as is has any leaks --
but that subclasses of core implimentations have no mechanism for safely
managing resources. Custom Directory implim
[
http://issues.apache.org/jira/browse/LUCENE-686?page=comments#action_12443014 ]
Paul Elschot commented on LUCENE-686:
-
In SpanTermQuery in the spans package, there is also a TermPositions that might
need to be closed.
This means that closin
[
http://issues.apache.org/jira/browse/LUCENE-686?page=comments#action_12442987 ]
Ning Li commented on LUCENE-686:
> Is there an actual memory leak problem related to this?
Right now no. For example, in FS based directories, the index inputs te
[
http://issues.apache.org/jira/browse/LUCENE-686?page=comments#action_12442943 ]
Paul Elschot commented on LUCENE-686:
-
Three things:
Is there an actual memory leak problem related to this?
In ReqExclScorer the two scorers can also be clos
18 matches
Mail list logo
