Is it save to remove the throw from FastCharStream.refill() ?

2006-10-03 Thread George Aroush
Hi folks, Over at Lucene.Net, we are trying to determine if it's safe to do the following change: http://issues.apache.org/jira/browse/LUCENENET-8 Can you tell us, if this change is done on the Java Lucene code, how it will effect Lucene? Do you expect the it to run faster but more importantly,

Re: Is it save to remove the throw from FastCharStream.refill() ?

2006-10-03 Thread Paul Smith
The throwing of an exception by this class is still being done on the Java side at this stage IIRC, and is also extremely bad for performance in Java. However I think the client of the class (one of the Filters I think) is expecting the EOF exception as a signal that it has received the en

Re: Is it save to remove the throw from FastCharStream.refill() ?

2006-10-03 Thread Yonik Seeley
Yeah, I don't think it's easy to get rid of the exception because the client of FastStreamChar is JavaCC generated code, which AFAIK uses the exception in lieu of explicit EOF checking. -Yonik http://incubator.apache.org/solr Solr, the open-source Lucene search server On 10/3/06, Paul Smith <[E

Re: Is it save to remove the throw from FastCharStream.refill() ?

2006-10-03 Thread Wolfgang Hoschek
A related prior discussion is at http://issues.apache.org/bugzilla/ show_bug.cgi?id=34930 Wolfgang. On Oct 3, 2006, at 7:08 PM, Yonik Seeley wrote: Yeah, I don't think it's easy to get rid of the exception because the client of FastStreamChar is JavaCC generated code, which AFAIK uses the exc

Re: Is it save to remove the throw from FastCharStream.refill() ?

2006-10-04 Thread Chris Hostetter
: A related prior discussion is at http://issues.apache.org/bugzilla/ : show_bug.cgi?id=34930 Which for the record is: https://issues.apache.org/jira/browse/LUCENE-388 -Hoss - To unsubscribe, e-mail: [EMAIL PROTECTED] For