OK I'll apply 2065 first, then we'll iterate on 2037 and get it in --
thanks Erick and Kay Kay! It's wonderful you all are putting in the
energy to keep our tests current :)
Mike
On Thu, Dec 3, 2009 at 9:14 PM, Erick Erickson erickerick...@gmail.com wrote:
Mike:
I should be able to create a
Thanks Kay Kay! Erick can you have a look / iterate? Thanks.
Mike
On Fri, Dec 4, 2009 at 3:30 PM, Kay Kay kaykay.uni...@gmail.com wrote:
Erick / Mike -
With 2065 commited onto trunk now - I created another patch for 2037 and
attached in the ticket.
3 classes remain pending though due to
Sure, but it won't be until late Saturday at the earliest, more likely
Sunday. Got
a busy Fri/Sat
Erick
On Fri, Dec 4, 2009 at 3:34 PM, Michael McCandless
luc...@mikemccandless.com wrote:
Thanks Kay Kay! Erick can you have a look / iterate? Thanks.
Mike
On Fri, Dec 4, 2009 at 3:30
On Thu, Dec 3, 2009 at 5:48 PM, Erick Erickson erickerick...@gmail.com wrote:
I generified the searches/function files in patch 2037. I don't really think
there's a conflict, just commit my patch and have at generifying the rest.
OK so then we'll start with 2037, then take 2065's patch,
I didn't realize 2065 had already been down this path, thought
you were volunteering to change all the code starting from
scratch. Your approach sounds like a fine plan.
Note that I'm not entirely sure that I cleaned up *everything*, but we
need to get to a known state before tackling the rest,
I created Lucene-2065 while working on 1257 , the original generics
related ticket , and since we were running out of time for 3.0 , I
guess we could not get src/test converted in.
In any case , if you were comitting this one (2037) to trunk , may be I
can wait before creating the patch
That's up to Mike, whichever way he finds easiest, I'll deal.
Erick
On Thu, Dec 3, 2009 at 8:43 PM, Kay Kay kaykay.uni...@gmail.com wrote:
I created Lucene-2065 while working on 1257 , the original generics related
ticket , and since we were running out of time for 3.0 , I guess we could
Mike -
I have attached another patch to LUCENE-2065 , in sync with the trunk now.
Erick Erickson wrote:
That's up to Mike, whichever way he finds easiest, I'll deal.
Erick
On Thu, Dec 3, 2009 at 8:43 PM, Kay Kay kaykay.uni...@gmail.com
mailto:kaykay.uni...@gmail.com wrote:
I created
Mike:
I should be able to create a new 2037 patch pretty easily if you
want to apply 2065 first. Let me know
Erick
On Thu, Dec 3, 2009 at 9:05 PM, Kay Kay kaykay.uni...@gmail.com wrote:
Mike -
I have attached another patch to LUCENE-2065 , in sync with the trunk now.
Erick Erickson
