variuos IndexReader methods -- was: Re: [jira] Updated: (LUCENE-832) NPE when calling isCurrent() on a ParallellReader

2007-08-01 Thread Chris Hostetter
is it just me, or does it seem like the base class versions of getVersion(), isOptimized(), and isCurrent() in IndexReader should all throw UnsupportedOperationException? (it seems like ideally they should abstract, but that ship/API has sailed) : This patch fixes ParallelReader similar to LUCE

Re: variuos IndexReader methods -- was: Re: [jira] Updated: (LUCENE-832) NPE when calling isCurrent() on a ParallellReader

2007-08-02 Thread Michael Busch
Chris Hostetter wrote: > is it just me, or does it seem like the base class versions of > getVersion(), isOptimized(), and isCurrent() in IndexReader should all > throw UnsupportedOperationException? > > (it seems like ideally they should abstract, but that ship/API has sailed) > > Hoss, I thi

Re: variuos IndexReader methods -- was: Re: [jira] Updated: (LUCENE-832) NPE when calling isCurrent() on a ParallellReader

2007-08-11 Thread Chris Hostetter
: We just have to make segmentInfos in IndexReader protected so that : subclasses can implement the methods. isn't segmentInfos the kind of thing that should be refactored into the subclasses? there might be a little duplication, but it shouldn't be significant (and it helps eliminate the odds o

Re: variuos IndexReader methods -- was: Re: [jira] Updated: (LUCENE-832) NPE when calling isCurrent() on a ParallellReader

2007-08-16 Thread Michael Busch
Chris Hostetter wrote: > > isn't segmentInfos the kind of thing that should be refactored into the > subclasses? there might be a little duplication, but it shouldn't be > significant (and it helps eliminate the odds of other problems like this > in the future as more features/methods get added).