Re: RFR: JEP 359-Records: javadoc code

2019-11-05 Thread Jonathan Gibbons
Hi Kumar, Thanks for the feedback. I'll be posting another webrev shortly. Let me respond here to some of the issues you raise. + // Special case to allow '{@link ...}' to appear in the string. + // A less general case would be to detect literal use of Object.equals + // A more general case wo

Re: RFR: JEP 359-Records: javadoc code

2019-11-05 Thread Jonathan Gibbons
Hannes, Thanks, I'll check and fix the imports. -- Jon On 11/5/19 8:19 AM, Hannes Wallnöfer wrote: Jon, Both the code and the generated documentation look good to me. A minor issue I noticed with the default branch patch is that it adds quite a few unused imports in TagletWriterImpl, ClassB

Re: RFR: JEP 359-Records: javadoc code

2019-11-05 Thread Hannes Wallnöfer
Jon, Both the code and the generated documentation look good to me. A minor issue I noticed with the default branch patch is that it adds quite a few unused imports in TagletWriterImpl, ClassBuilder, and TagletWriter. Hannes > Am 31.10.2019 um 00:50 schrieb Jonathan Gibbons : > > Please rev

Re: RFR: 8223378: CSS solution for navbar problem with <'a> elements is not ideal

2019-11-05 Thread Hannes Wallnöfer
I found a few problems with the first webrev. First, the generated documentation didn’t render correctly on some versions of Internet Explorer, because I had left away some markup/css that is not required in current browsers. Second, I had omitted some *Writers that still outputted the old mar