Re: RFR: 8252999: Cleanup: replace .equals("") with .isEmpty() within all codebase

2020-11-24 Thread David Holmes
On 10/09/2020 10:07 pm, Dmitriy Dumanskiy wrote: On Thu, 10 Sep 2020 11:21:28 GMT, David Holmes wrote: The code in java.base was updated to use String::isEmpty in JDK 12 (JDK-8215281). There was follow-up in JDK 13 to do the same in the java.desktop module (JDK-8223237). Changing the remainin

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v6]

2020-11-24 Thread Alex Buckley
On 11/5/2020 4:45 AM, Jan Lahoda wrote: FWIW, a javadoc generated with the current version of the patch: http://cr.openjdk.java.net/~jlahoda/8250768/jdk.javadoc.01/api/index.html Allow me to draw people's attention to the PREVIEW link in the banner of the generated javadoc. It shows all the pr

Re: RFR: 8246774: Record Classes (final) implementation

2020-11-24 Thread Alex Buckley
On 9/23/2020 5:26 PM, Mandy Chung wrote: What is the policy of `@since` release value when a preview API becomes final.I would expect `@since` should be updated from 14 to 16 because 16 is the Java SE release these APIs are added?? Yes. Per http://openjdk.java.net/jeps/12#Specifications-of

RE: 8157682: @inheritDoc doesn't work with @exception

2020-11-24 Thread yano-masan...@fujitsu.com
Hi Jon, It's been a year since I asked for a sponsor, so please tell me the progress of this bug fixing work. Regards, Masanori Yano > -Original Message- > From: Yano, Masanori > Sent: Thursday, September 26, 2019 2:28 PM > To: 'Jonathan Gibbons' ; > 'javadoc-dev@openjdk.java.net' > S

Documenting record compact constructor

2020-11-24 Thread Daniel Fuchs
Hi, What is the canonical way of documenting a record compact constructor? Consider the following dummy record class: = import java.util.Objects; /** * A class that represents a person's name. * * @param name the person's first name *

RFR: 8242652: Throw SkippedException if no JS engine availabe in TestSearchScript

2020-11-24 Thread Hannes Wallnöfer
This is a simple change to throw jtreg.SkippedException if no JavaScript engine is available to run the TestSearchScript test. In my previous attempt I tried to use the SkippedException class already present elsewhere in the test tree, not realizing I couuld just copy/create the exception in the

RFR: 8244535: JavaDoc search is overly strict with letter case

2020-11-24 Thread Hannes Wallnöfer
This PR softens the case-sensitivity rules in Javadoc searches by including results of case-insensitive search if a case-sensitive yields no or very few results. Changes also include some restructuring of the search.js code along with minor changes that improve compliance with the specificatio