On Fri, 12 Mar 2021 14:04:04 GMT, Hannes Wallnöfer wrote:
> This is a relatively simple change to add an `id="class-description"` to the
> description section of type pages. It also changes the CSS class for this
> section from `description` to `class-description` for consistency with
> packag
On Fri, 12 Mar 2021 15:36:46 GMT, Hannes Wallnöfer wrote:
> A simple change to make the HTML ids used for search input and reset button
> safe from collision with Java elements. The ids are also added th the
> `HtmlIds` class instead of using strings.
Looks good to me. Nice cleanup.
-
On Thu, 11 Mar 2021 15:17:50 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Update `@see` tag in class java.security.cert.PKIXRevocationChecker
>
> Nice! I like the basic change to `Tagl
On Wed, 24 Mar 2021 16:14:11 GMT, Hannes Wallnöfer wrote:
>> This adds a "Related Packages" table to package summary pages with a list of
>> neighboring tables. The rules for including packages is as follows:
>>
>> 1. The super package of the current package is included if it exists.
>> 2. Di
> Please review a moderately simple fix to improve DocLint's checking for empty
> tags, and in particular, bad use of `` as a paragraph terminator. This
> will help detect this bad usage at doclint-time, instead of later, with
> doccheck.
>
> There was already code to check if tags were empty.
On Fri, 5 Mar 2021 21:44:20 GMT, Jonathan Gibbons wrote:
> Please review a moderately simple fix to improve DocLint's checking for empty
> tags, and in particular, bad use of `` as a paragraph terminator. This
> will help detect this bad usage at doclint-time, instead of later, with
> doccheck
On Tue, 23 Mar 2021 21:10:33 GMT, Jonathan Gibbons wrote:
> This work started as a small cleanup in another changes, but the test changes
> became big enough to warrant a senate changeset.
>
> When the recently changed the terminology from "annotation type" to
> "annotation interface", we miss
On Tue, 23 Mar 2021 05:32:16 GMT, Jonathan Gibbons wrote:
> Please review an update to the structure and some of the content of the
> generated Help page, focussed on the following:
>
> * A new section at the top of the Help page headed "Navigation", providing an
> overview of how to navigate
On Wed, 24 Mar 2021 17:04:04 GMT, Hannes Wallnöfer wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Fix bad reference in property
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/resou
> Please review an update to the structure and some of the content of the
> generated Help page, focussed on the following:
>
> * A new section at the top of the Help page headed "Navigation", providing an
> overview of how to navigate around the docs.
> * The HELP button in the top navbar for
On Tue, 23 Mar 2021 05:32:16 GMT, Jonathan Gibbons wrote:
> Please review an update to the structure and some of the content of the
> generated Help page, focussed on the following:
>
> * A new section at the top of the Help page headed "Navigation", providing an
> overview of how to navigate
I like it except that I was expecting the module name (column) to
precede the package name (column).
Is there a strong reason to have the module name column appear second?
-- Jon
On 3/24/21 8:04 AM, Hannes Wallnöfer wrote:
On Fri, 12 Mar 2021 17:37:13 GMT, Jonathan Gibbons wrote:
Hannes Wa
> Please review a trivial change to fix this test when run behind a firewall
> with a proxy set.
>
> Previously, the test used `InetAddress.getLocalHost` which returns an IP
> address for the current host. It runs a temporary local web server on that
> address, but since the address is typical
> This adds a "Related Packages" table to package summary pages with a list of
> neighboring tables. The rules for including packages is as follows:
>
> 1. The super package of the current package is included if it exists.
> 2. Direct subpackages of the current package are included, but only if
On Tue, 23 Mar 2021 21:10:33 GMT, Jonathan Gibbons wrote:
> This work started as a small cleanup in another changes, but the test changes
> became big enough to warrant a senate changeset.
>
> When the recently changed the terminology from "annotation type" to
> "annotation interface", we miss
On 24/03/2021 15:04, Hannes Wallnöfer wrote:
I have added a change to this PR to add a "Module" column to the related
packages table if any of the packages is in a different module. Example output for the
JDK libraries is available here (`java.lang`, `java.util` and `com.sun.tools.*` packages
On Fri, 12 Mar 2021 17:37:13 GMT, Jonathan Gibbons wrote:
>> Hannes Wallnöfer has updated the pull request with a new target base due to
>> a merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains three additional
>
> This adds a "Related Packages" table to package summary pages with a list of
> neighboring tables. The rules for including packages is as follows:
>
> 1. The super package of the current package is included if it exists.
> 2. Direct subpackages of the current package are included, but only if
18 matches
Mail list logo
