Integrated: 8262891: Compiler implementation for Pattern Matching for switch (Preview)

2021-06-07 Thread Jan Lahoda
On Tue, 4 May 2021 16:41:44 GMT, Jan Lahoda wrote: > This is a preview of a patch implementing JEP 406: Pattern Matching for > switch (Preview): > https://bugs.openjdk.java.net/browse/JDK-8213076 > > The current draft of the specification is here: > http://cr.openjdk.java.net/~gbierman/jep406/j

Re: RFR: 8267832: SimpleVisitors and Scanners in jdk.compiler should use @implSpec [v2]

2021-06-07 Thread openjdk-notifier [bot]
On Fri, 28 May 2021 19:07:17 GMT, Jan Lahoda wrote: >> As noted in: >> https://bugs.openjdk.java.net/browse/JDK-8265981?focusedCommentId=14423316&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14423316 >> >> Methods in various utility visitor classes in jdk.compile

Re: RFR: 8267832: SimpleVisitors and Scanners in jdk.compiler should use @implSpec [v3]

2021-06-07 Thread Jan Lahoda
> As noted in: > https://bugs.openjdk.java.net/browse/JDK-8265981?focusedCommentId=14423316&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14423316 > > Methods in various utility visitor classes in jdk.compiler should use > @implSpec to specify the implementation be

Re: RFR: JDK-8149138: [javadoc] Fix SerialFormBuilder eliminate String bashing

2021-06-07 Thread Hannes Wallnöfer
On Thu, 3 Jun 2021 16:59:22 GMT, Jonathan Gibbons wrote: >> Removal of ugly old code in `SerializedFormBuilder.java`. Luckily there >> already is a clean overloaded method in the associated writer that we can >> use, so this is mostly a removal of code that is no longer used. >> >> I also enha

Integrated: JDK-8149138: [javadoc] Fix SerialFormBuilder eliminate String bashing

2021-06-07 Thread Hannes Wallnöfer
On Tue, 1 Jun 2021 16:21:56 GMT, Hannes Wallnöfer wrote: > Removal of ugly old code in `SerializedFormBuilder.java`. Luckily there > already is a clean overloaded method in the associated writer that we can > use, so this is mostly a removal of code that is no longer used. > > I also enhanced

Integrated: 8268318: Missing comma in copyright header

2021-06-07 Thread David Holmes
Please review this trivial fix to a copyright line. Thanks, David - Commit messages: - 8268318: Missing comma in copyright header Changes: https://git.openjdk.java.net/jdk/pull/4385/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=4385&range=00 Issue: https://bugs.ope

Re: Integrated: 8268318: Missing comma in copyright header

2021-06-07 Thread Stefan Karlsson
On Mon, 7 Jun 2021 10:15:06 GMT, David Holmes wrote: > Please review this trivial fix to a copyright line. > > Thanks, > David Marked as reviewed by stefank (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/4385

Integrated: 8268318: Missing comma in copyright header

2021-06-07 Thread David Holmes
On Mon, 7 Jun 2021 10:15:06 GMT, David Holmes wrote: > Please review this trivial fix to a copyright line. > > Thanks, > David This pull request has now been integrated. Changeset: 8130be56 Author:David Holmes URL: https://git.openjdk.java.net/jdk/commit/8130be561b76906be660e6d7798

Integrated: 8267832: SimpleVisitors and Scanners in jdk.compiler should use @implSpec

2021-06-07 Thread Jan Lahoda
On Thu, 27 May 2021 09:41:17 GMT, Jan Lahoda wrote: > As noted in: > https://bugs.openjdk.java.net/browse/JDK-8265981?focusedCommentId=14423316&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-14423316 > > Methods in various utility visitor classes in jdk.compiler sh

Re: RFR: 8268299: jvms tag produces incorrect URL

2021-06-07 Thread Erik Joelsson
On Sun, 6 Jun 2021 22:03:46 GMT, Joe Darcy wrote: > The @jls and @jvms taglet share most of their functionality. A JLS URL > looks like > > https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1 > > and a JVMS URL looks like > > > https://docs.oracle.com/javase/s

Re: RFR: JDK-8266748: Move modifiers code to Signatures.java [v2]

2021-06-07 Thread Hannes Wallnöfer
> This change consolidates the code to generate type signature modifiers into > `Signatures.TypeSignature`. > > Although this mostly consists of moving the code from `ClassWriterImpl` and > `Utils` to `Signatures`, I also avoided the need to split the modifiers > string when processing preview

Re: RFR: JDK-8266748: Move modifiers code to Signatures.java [v2]

2021-06-07 Thread Hannes Wallnöfer
On Thu, 3 Jun 2021 17:22:26 GMT, Jonathan Gibbons wrote: > Minor changes suggestion, to access items from the configuration where > possible. > > As a followup, it would be good to look at the remaining uses of > `HtmlDocletWriter` in `Signatures`. There is at least a theme of "methods to > c

Re: RFR: JDK-8259806: Clean up terminology on the "All Classes" page

2021-06-07 Thread Hannes Wallnoefer
Yes, the move is from „All Classes“ to „All Classes and Interfaces“. This is also the new terminology used in the combined tabbed table in package pages, regardless of release. Hannes > Am 05.06.2021 um 21:16 schrieb Jonathan Gibbons : > > Up until recently, we used > > Types (now Classes a

Re: RFR: JDK-8263468: New page for "recent" new API [v3]

2021-06-07 Thread Hannes Wallnöfer
> This adds a new kind of summary list for new API added in specific releases, > and adds information to the deprecated API list about elements that were > deprecated in the given releases. > > The changes to the code are relatively minor thanks to the existing > infrastructure for summary list

Re: RFR: JDK-8263468: New page for "recent" new API [v2]

2021-06-07 Thread Jonathan Gibbons
On Fri, 28 May 2021 08:19:33 GMT, Hannes Wallnöfer wrote: >> This adds a new kind of summary list for new API added in specific releases, >> and adds information to the deprecated API list about elements that were >> deprecated in the given releases. >> >> The changes to the code are relativel

Re: RFR: JDK-8263468: New page for "recent" new API [v3]

2021-06-07 Thread Jonathan Gibbons
On Mon, 7 Jun 2021 15:00:43 GMT, Hannes Wallnöfer wrote: >> This adds a new kind of summary list for new API added in specific releases, >> and adds information to the deprecated API list about elements that were >> deprecated in the given releases. >> >> The changes to the code are relatively

Re: RFR: JDK-8263468: New page for "recent" new API [v3]

2021-06-07 Thread Jonathan Gibbons
On Mon, 7 Jun 2021 15:46:45 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into JDK-8263468 >> - JDK-8263468: automate build integration

Re: RFR: 8268299: jvms tag produces incorrect URL

2021-06-07 Thread Jonathan Gibbons
On Sun, 6 Jun 2021 22:03:46 GMT, Joe Darcy wrote: > The @jls and @jvms taglet share most of their functionality. A JLS URL > looks like > > https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1 > > and a JVMS URL looks like > > > https://docs.oracle.com/javase/s

Integrated: 8268299: jvms tag produces incorrect URL

2021-06-07 Thread Joe Darcy
On Sun, 6 Jun 2021 22:03:46 GMT, Joe Darcy wrote: > The @jls and @jvms taglet share most of their functionality. A JLS URL > looks like > > https://docs.oracle.com/javase/specs/jls/se16/html/**jls**-8.html#jls-8.1 > > and a JVMS URL looks like > > > https://docs.oracle.com/javase/s

Re: RFR: JDK-8263468: New page for "recent" new API [v4]

2021-06-07 Thread Hannes Wallnöfer
> This adds a new kind of summary list for new API added in specific releases, > and adds information to the deprecated API list about elements that were > deprecated in the given releases. > > The changes to the code are relatively minor thanks to the existing > infrastructure for summary list

Re: RFR: JDK-8263468: New page for "recent" new API [v2]

2021-06-07 Thread Hannes Wallnöfer
On Mon, 7 Jun 2021 14:52:57 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8263468: automate build integration > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/h

Re: RFR: JDK-8263468: New page for "recent" new API [v3]

2021-06-07 Thread Hannes Wallnöfer
On Mon, 7 Jun 2021 15:27:21 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 16 commits: >> >> - Merge branch 'master' into JDK-8263468 >> - JDK-8263468: automate build integration

Re: RFR: JDK-8263468: New page for "recent" new API [v2]

2021-06-07 Thread Hannes Wallnöfer
On Mon, 7 Jun 2021 14:53:55 GMT, Jonathan Gibbons wrote: >> Hannes Wallnöfer has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8263468: automate build integration > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/h

Re: RFR: JDK-8267187: Remove deprecated constructor for Log [v2]

2021-06-07 Thread Jonathan Gibbons
> In the course of other work, I came across this deprecated constructor in Log > which just existed for a public entry point in javadoc which has already been > removed. > > There is one remaining use in javadoc, which can be changed to use an > alternate non-deprecated constructor. Jonathan

Re: RFR: JDK-8267187: Remove deprecated constructor for Log [v2]

2021-06-07 Thread Jonathan Gibbons
On Tue, 8 Jun 2021 01:09:36 GMT, Jonathan Gibbons wrote: >> In the course of other work, I came across this deprecated constructor in >> Log which just existed for a public entry point in javadoc which has already >> been removed. >> >> There is one remaining use in javadoc, which can be chang

Withdrawn: JDK-8267187: Remove deprecated constructor for Log

2021-06-07 Thread Jonathan Gibbons
On Fri, 14 May 2021 20:49:35 GMT, Jonathan Gibbons wrote: > In the course of other work, I came across this deprecated constructor in Log > which just existed for a public entry point in javadoc which has already been > removed. > > There is one remaining use in javadoc, which can be changed t

RFR: JDK-8268352: Rename javadoc Messager class to JavadocLog

2021-06-07 Thread Jonathan Gibbons
Please review a simple cleanup, to rename the javadoc Messager class to the more explicit, less-confusing name of JavadocLog, since it is the javadoc subtype of the javac Log class. The new name is in line with other javadoc subtypes of javac classes. The change only affects the javadoc.tool pa