> Could you please review the 8248001 bug fixes?
>
> The problem is that javadoc generates invalid HTML pages whose ftp:// links
> are broken. The fix changes not to use protocol names directly, but to use
> regular expression.
Masanori Yano has updated the pull request incrementally with one a
On Tue, 28 Sep 2021 08:23:30 GMT, Masanori Yano wrote:
>> Could you please review the 8248001 bug fixes?
>>
>> The problem is that javadoc generates invalid HTML pages whose ftp:// links
>> are broken. The fix changes not to use protocol names directly, but to use
>> regular expression.
>
> Ma
> This is an initial PR for expanded lint warnings done under two bugs:
>
> 8202056: Expand serial warning to check for bad overloads of serial-related
> methods and ineffectual fields
> 8160675: Issue lint warning for non-serializable non-transient instance
> fields in serializable type
>
> to
> This is an initial PR for expanded lint warnings done under two bugs:
>
> 8202056: Expand serial warning to check for bad overloads of serial-related
> methods and ineffectual fields
> 8160675: Issue lint warning for non-serializable non-transient instance
> fields in serializable type
>
> to
Please review a moderately simple improvement for `JavadocTester` and a related
new test.
A new `OutputChecker` class is introduced that mostly supersedes the existing
methods to check the output generated by javadoc and the standard doclet. A
self-imposed restriction is that no existing tests
On Tue, 28 Sep 2021 23:34:21 GMT, Jonathan Gibbons wrote:
> Please review a moderately simple improvement for `JavadocTester` and a
> related new test.
>
> A new `OutputChecker` class is introduced that mostly supersedes the existing
> methods to check the output generated by javadoc and the s
On Thu, 23 Sep 2021 01:44:27 GMT, Jonathan Gibbons wrote:
> Please review a moderately simple update to convert JavadocTester to just use
> NIO, instead of a mix of File and NIO.
>
> The original code used java.io.File. At some point (JDK 9-ish) new code was
> added that used NIO, resulting in
On Mon, 27 Sep 2021 15:49:25 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address preliminary review comments
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DCTree.java line 177
On Mon, 27 Sep 2021 18:00:07 GMT, Pavel Rappo wrote:
> > Apart from fixing generally bad behavior, there is one other tiny
> > behavioral change. For an empty DocCommentTree the ending position is now
> > the same at the starting position, and not NOPOS.
>
> I suppose we don't need to reflect
On Mon, 27 Sep 2021 15:48:17 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address preliminary review comments
>
> src/jdk.compiler/share/classes/com/sun/tools/javac/tree/DCTree.java line 161
> Please review a moderately simple improvement for `JavadocTester` and a
> related new test.
>
> A new `OutputChecker` class is introduced that mostly supersedes the existing
> methods to check the output generated by javadoc and the standard doclet. A
> self-imposed restriction is that no exi
11 matches
Mail list logo
