Re: RFR: JDK-8282559: Allow multiple search terms in javadoc search [v2]

2022-04-13 Thread Hannes Wallnöfer
> Please review the first of two PRs to enhance JavaDoc search. > > This one focuses on the existing search script, to which it adds the feature > to search for multiple terms. It also improves the implementation of > case-sensitive search as well as rating of matches and provides some general

RFR: JDK-8248863: Add search landing page to API documentation

2022-04-13 Thread Hannes Wallnöfer
This is the second of two PRs to enhance JavaDoc search, it is based on the first one (#8185). It adds a standalone search page (search.html) along with its own script file (search-page.js). This PR is very similar to the last prototype I uploaded and demoed, the changes are mostly tweaks to th

RFR: 8283864: Clean up DocFinder and friends

2022-04-13 Thread Pavel Rappo
A clean-up to facilitate more clean-up in the future. - Commit messages: - Remove extra list wrapping - Fix DocFinder.Output.toString comment - Clarify internal comment (2) - Clarify internal comment - Cast to ExecutableElement once - Remove an outdated note - Clean up what was

Re: RFR: JDK-8248863: Add search landing page to API documentation

2022-04-13 Thread liach
On Wed, 13 Apr 2022 16:01:17 GMT, Hannes Wallnöfer wrote: > This is the second of two PRs to enhance JavaDoc search, it is based on the > first one (#8185). > > It adds a standalone search page (search.html) along with its own script file > (search-page.js). This PR is very similar to the last

Re: RFR: 8283864: Clean up DocFinder and friends

2022-04-13 Thread Jonathan Gibbons
On Wed, 13 Apr 2022 18:02:14 GMT, Pavel Rappo wrote: > A clean-up to facilitate more clean-up in the future. Nice cleanup. There is one suggestion for a minor change, to eliminate an unnecessary `utils` parameter from `DocFinder.Input.copy` src/jdk.javadoc/share/classes/jdk/javadoc/internal/d

Re: RFR: JDK-8248863: Add search landing page to API documentation

2022-04-13 Thread Jonathan Gibbons
On Wed, 13 Apr 2022 16:01:17 GMT, Hannes Wallnöfer wrote: > This is the second of two PRs to enhance JavaDoc search, it is based on the > first one (#8185). > > It adds a standalone search page (search.html) along with its own script file > (search-page.js). This PR is very similar to the last

Re: RFR: JDK-8282559: Allow multiple search terms in javadoc search [v2]

2022-04-13 Thread Jonathan Gibbons
On Wed, 13 Apr 2022 14:11:13 GMT, Hannes Wallnöfer wrote: >> Please review the first of two PRs to enhance JavaDoc search. >> >> This one focuses on the existing search script, to which it adds the feature >> to search for multiple terms. It also improves the implementation of >> case-sensiti