On Fri, 29 Apr 2022 00:29:50 GMT, Jonathan Gibbons wrote:
> Please review some localized cleanup for the doclint Checker class, primarily
> focused on upgrading to the use of "enhanced `switch`"
>
> The output of one test was changed because of some improvements in one switch
> statement to el
On Thu, 28 Apr 2022 02:05:47 GMT, Jonathan Gibbons wrote:
> Please review the code and tests to add support for a new `@spec url title`
> tag to javadoc. Note, this does not include any changes to API doc comments
> to use the new tag in JDK API documentation; that will come later.
This is ni
On Thu, 24 Mar 2022 17:30:22 GMT, Vikey Chen wrote:
>> From the test doc of openjdk
>> https://openjdk.java.net/groups/build/doc/testing.html
>>> If your locale is non-US, some tests are likely to fail. To work around
>>> this you can set the locale to US. On Unix platforms simply setting
>>>
> The only taglet that along with its own tag needs to know the immediately
> enclosing tag is `InheritDocTaglet`:
>
> @return {@inheritDoc}
> @throws NullPointerException {@inheritDoc}
> @param p {@inheritDoc}
>
> However, the immediately enclosing tag is unconditionally passed to a
As described in the JBS issue, the observed problem is a side-effect of a
related but different issue, which is that record classes are not treated the
same was as enum classes when it comes to generating the class hierarchy in
`ClassTree`. Because record classes are not treated specially/differ
On Tue, 3 May 2022 11:31:09 GMT, Pavel Rappo wrote:
>> Please review some localized cleanup for the doclint Checker class,
>> primarily focused on upgrading to the use of "enhanced `switch`"
>>
>> The output of one test was changed because of some improvements in one
>> switch statement to eli
On Tue, 3 May 2022 11:03:02 GMT, Pavel Rappo wrote:
>> Please review some localized cleanup for the doclint Checker class,
>> primarily focused on upgrading to the use of "enhanced `switch`"
>>
>> The output of one test was changed because of some improvements in one
>> switch statement to eli
> Please review some localized cleanup for the doclint Checker class, primarily
> focused on upgrading to the use of "enhanced `switch`"
>
> The output of one test was changed because of some improvements in one switch
> statement to eliminate the use of fall-through semantics.
Jonathan Gibbons
On Tue, 3 May 2022 12:38:09 GMT, Pavel Rappo wrote:
>> Please review the code and tests to add support for a new `@spec url title`
>> tag to javadoc. Note, this does not include any changes to API doc comments
>> to use the new tag in JDK API documentation; that will come later.
>
> src/jdk.co
On Tue, 3 May 2022 12:40:42 GMT, Pavel Rappo wrote:
>> Please review the code and tests to add support for a new `@spec url title`
>> tag to javadoc. Note, this does not include any changes to API doc comments
>> to use the new tag in JDK API documentation; that will come later.
>
> src/jdk.co
On Tue, 3 May 2022 12:42:41 GMT, Pavel Rappo wrote:
>> Please review the code and tests to add support for a new `@spec url title`
>> tag to javadoc. Note, this does not include any changes to API doc comments
>> to use the new tag in JDK API documentation; that will come later.
>
> src/jdk.co
On Tue, 3 May 2022 21:53:21 GMT, Jonathan Gibbons wrote:
>> Please review some localized cleanup for the doclint Checker class,
>> primarily focused on upgrading to the use of "enhanced `switch`"
>>
>> The output of one test was changed because of some improvements in one
>> switch statement t
On Tue, 3 May 2022 13:23:41 GMT, Pavel Rappo wrote:
>> Please review the code and tests to add support for a new `@spec url title`
>> tag to javadoc. Note, this does not include any changes to API doc comments
>> to use the new tag in JDK API documentation; that will come later.
>
> src/jdk.ja
On Tue, 3 May 2022 21:53:21 GMT, Jonathan Gibbons wrote:
>> Please review some localized cleanup for the doclint Checker class,
>> primarily focused on upgrading to the use of "enhanced `switch`"
>>
>> The output of one test was changed because of some improvements in one
>> switch statement t
On Tue, 3 May 2022 22:16:25 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address review feedback
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line
> 866:
>
>
On Tue, 3 May 2022 22:30:51 GMT, Jonathan Gibbons wrote:
> Yes, but RECORD is handled in a different case, along with METHOD and
> CONSTRUCTOR, because it can have "plain" `@param` as well as type-parameter
> `@param`. In contrast, a class or interface can only have type-parameter
> `@param` a
On Tue, 3 May 2022 22:06:29 GMT, Pavel Rappo wrote:
>> Jonathan Gibbons has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> address review feedback
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line
> 217:
>
>
> Please review some localized cleanup for the doclint Checker class, primarily
> focused on upgrading to the use of "enhanced `switch`"
>
> The output of one test was changed because of some improvements in one switch
> statement to eliminate the use of fall-through semantics.
Jonathan Gibbons
18 matches
Mail list logo
