On Tue, 3 May 2022 13:23:41 GMT, Pavel Rappo <[email protected]> wrote:
>> Please review the code and tests to add support for a new `@spec url title`
>> tag to javadoc. Note, this does not include any changes to API doc comments
>> to use the new tag in JDK API documentation; that will come later.
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/toolkit/util/DocFinder.java
> line 277:
>
>> 275:
>> 276: private static boolean isNonEmpty(List<? extends DocTree> list) {
>> 277: return list != null && !list.isEmpty();
>
> `output.inlineTags` should never be null. Separately, can this readability
> change be done in a separate PR? I do have one suitable PR in the works,
> which can include it.
I'll back out these lines as long as the tests still pass.
> test/langtools/jdk/javadoc/doclet/testConditionalPages/TestConditionalPages.java
> line 2:
>
>> 1: /*
>> 2: * Copyright (c) 2020, 2022, Oracle and/or its affiliates. All rights
>> reserved.
>
> Consider adding 6251738 to `@bug`.
Mmmm, OK
-------------
PR: https://git.openjdk.java.net/jdk/pull/8439
