Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v5]

2023-03-31 Thread Naoto Sato
On Fri, 17 Mar 2023 22:27:48 GMT, Justin Lu wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is adjusted to support reading in t

Re: RFR: 8301991: Convert l10n properties resource bundles to UTF-8 native [v5]

2023-03-31 Thread Justin Lu
On Fri, 17 Mar 2023 22:27:48 GMT, Justin Lu wrote: >> This PR converts Unicode sequences to UTF-8 native in .properties file. >> (Excluding the Unicode space and tab sequence). The conversion was done >> using native2ascii. >> >> In addition, the build logic is adjusted to support reading in t

Re: RFR: JDK-8303123: Add line break opportunity to single type parameters

2023-03-31 Thread Jonathan Gibbons
On Tue, 21 Mar 2023 14:11:56 GMT, Hannes Wallnöfer wrote: > Please review a simple change to add a `` (line break opportunity) tag > before type parameters in some type links. This is only used in the first > column of member summary tables as this is the only place where we have type > names

Re: RFR: JDK-8299718: JavaDoc: Buttons to copy specific documentation URL are not accessible

2023-03-31 Thread Jonathan Gibbons
On Fri, 24 Mar 2023 15:29:30 GMT, Hannes Wallnöfer wrote: > Please review a change to address accessibility issues with the > copy-to-clipboard buttons in JavaDoc-generated documentation. The most > important change is to make these button work for keyboard users, which means > buttons must ex

Re: [External] : Re: Snippet specification feedback

2023-03-31 Thread Tagir Valeev
Hello! Thank you for the detailed answer, now things are much more clear. > > In fact, the current implementation looks somewhat inconsistent, but > it's unclear whether it's correct or not, as we have no specification. For > example, consider the external snippet: > > > > class Test { > > // @

Re: [External] : Re: Snippet specification feedback

2023-03-31 Thread Pavel Rappo
> On 30 Mar 2023, at 12:40, Tagir Valeev wrote: > > Hello, Pavel! > > Thank you for the detailed answer. > > > 1. Attribute value syntax. The spec says "An attribute value may be an > > identifier, unsigned integer, or enclosed in either single or double quote > > characters; no escape char