Please review this patch that fixes placement of type annotations on array
types in Javadoc output. This oversight seems to have existed since JDK 8 but
was never noticed or reported.
-
Commit messages:
- Fix whitespace
- Make sure varargs work too
- Fix bugs, add tests, fix wron
> Please review a patch to add support for Markdown syntax in documentation
> comments, as described in the associated JEP.
>
> Notable features:
>
> * support for `///` documentation comments in `JavaTokenizer`
> * new module `jdk.internal.md` -- a private copy of the `commonmark-java`
> libra
On Mon, 11 Mar 2024 13:57:23 GMT, Chen Liang wrote:
>> Please review this patch that fixes the issue where type annotations on
>> primitive types are not linked.
>>
>> Tested with file
>> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>>
>> import java.lang.annotation.*;
>>
>
> Please review a patch to add support for Markdown syntax in documentation
> comments, as described in the associated JEP.
>
> Notable features:
>
> * support for `///` documentation comments in `JavaTokenizer`
> * new module `jdk.internal.md` -- a private copy of the `commonmark-java`
> libra
On Mon, 11 Mar 2024 13:37:54 GMT, Hannes Wallnöfer wrote:
> Please review a change to improve the user experience and implementation for
> the checkbox-based interface to selectively display content on API summary
> pages:
>
> - Add a checkbox to toggle (select/unselect) all checkboxes in the
On Mon, 11 Mar 2024 13:57:23 GMT, Chen Liang wrote:
>> Please review this patch that fixes the issue where type annotations on
>> primitive types are not linked.
>>
>> Tested with file
>> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>>
>> import java.lang.annotation.*;
>>
>
On Mon, 11 Mar 2024 13:31:06 GMT, Chen Liang wrote:
>> Please review this patch that fixes the issue where type annotations on
>> primitive types are not linked.
>>
>> Tested with file
>> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>>
>> import java.lang.annotation.*;
>>
>
On Mon, 11 Mar 2024 13:45:19 GMT, Guoxiong Li wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed unused methods
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlLinkFactory.java
>
On Mon, 11 Mar 2024 13:53:57 GMT, Chen Liang wrote:
>> Please review this patch that fixes the issue where type annotations on
>> primitive types are not linked.
>>
>> Tested with file
>> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>>
>> import java.lang.annotation.*;
>>
>
> Please review this patch that fixes the issue where type annotations on
> primitive types are not linked.
>
> Tested with file
> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>
> import java.lang.annotation.*;
>
> public class ArrayAnno {
> @Retention(RetentionPolicy.R
On Mon, 11 Mar 2024 13:31:06 GMT, Chen Liang wrote:
>> Please review this patch that fixes the issue where type annotations on
>> primitive types are not linked.
>>
>> Tested with file
>> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>>
>> import java.lang.annotation.*;
>>
>
Please review a change to improve the user experience and implementation for
the checkbox-based interface to selectively display content on API summary
pages:
- Add a checkbox to toggle (select/unselect) all checkboxes in the page.
- Remove the `Table.setAlwaysShowDefaultTab(boolean)` setter a
On Mon, 11 Mar 2024 06:36:49 GMT, Guoxiong Li wrote:
>> Chen Liang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Removed unused methods
>
> test/langtools/jdk/javadoc/doclet/testTypeAnnotations/typeannos/MethodReturnType.java
> line 5
> Please review this patch that fixes the issue where type annotations on
> primitive types are not linked.
>
> Tested with file
> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>
> import java.lang.annotation.*;
>
> public class ArrayAnno {
> @Retention(RetentionPolicy.R
On Mon, 11 Mar 2024 13:13:07 GMT, Chen Liang wrote:
> The 2-D array case is broken: currently source code `@A int @B [] @C []` is
> compiled to `@A int @C [] @B []` in both class file and javadoc output, so I
> don't want to add a buggy case that needs to be updated if this annotation
> placem
On Mon, 11 Mar 2024 06:35:27 GMT, Guoxiong Li wrote:
>> Please review this patch that fixes the issue where type annotations on
>> primitive types are not linked.
>>
>> Tested with file
>> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>>
>> import java.lang.annotation.*;
>>
On Sun, 10 Mar 2024 20:19:44 GMT, Chen Liang wrote:
> Please review this patch that fixes the issue where type annotations on
> primitive types are not linked.
>
> Tested with file
> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java
>
> import java.lang.annotation.*;
>
> public
17 matches
Mail list logo