RFR: 8327824: Type annotation placed on incorrect array nesting levels

2024-03-11 Thread Chen Liang
Please review this patch that fixes placement of type annotations on array types in Javadoc output. This oversight seems to have existed since JDK 8 but was never noticed or reported. - Commit messages: - Fix whitespace - Make sure varargs work too - Fix bugs, add tests, fix wron

Re: RFR: JDK-8298405: Implement JEP 467: Markdown Documentation Comments [v49]

2024-03-11 Thread Jonathan Gibbons
> Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.internal.md` -- a private copy of the `commonmark-java` > libra

Re: RFR: 8325433: Type annotations on primitive types are not linked [v3]

2024-03-11 Thread Pavel Rappo
On Mon, 11 Mar 2024 13:57:23 GMT, Chen Liang wrote: >> Please review this patch that fixes the issue where type annotations on >> primitive types are not linked. >> >> Tested with file >> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java >> >> import java.lang.annotation.*; >> >

Re: RFR: JDK-8298405: Implement JEP 467: Markdown Documentation Comments [v48]

2024-03-11 Thread Jonathan Gibbons
> Please review a patch to add support for Markdown syntax in documentation > comments, as described in the associated JEP. > > Notable features: > > * support for `///` documentation comments in `JavaTokenizer` > * new module `jdk.internal.md` -- a private copy of the `commonmark-java` > libra

Re: RFR: JDK-8325874: Improve checkbox-based interface in summary pages

2024-03-11 Thread Pavel Rappo
On Mon, 11 Mar 2024 13:37:54 GMT, Hannes Wallnöfer wrote: > Please review a change to improve the user experience and implementation for > the checkbox-based interface to selectively display content on API summary > pages: > > - Add a checkbox to toggle (select/unselect) all checkboxes in the

Re: RFR: 8325433: Type annotations on primitive types are not linked [v3]

2024-03-11 Thread Pavel Rappo
On Mon, 11 Mar 2024 13:57:23 GMT, Chen Liang wrote: >> Please review this patch that fixes the issue where type annotations on >> primitive types are not linked. >> >> Tested with file >> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java >> >> import java.lang.annotation.*; >> >

Re: RFR: 8325433: Type annotations on primitive types are not linked [v2]

2024-03-11 Thread Chen Liang
On Mon, 11 Mar 2024 13:31:06 GMT, Chen Liang wrote: >> Please review this patch that fixes the issue where type annotations on >> primitive types are not linked. >> >> Tested with file >> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java >> >> import java.lang.annotation.*; >> >

Re: RFR: 8325433: Type annotations on primitive types are not linked [v2]

2024-03-11 Thread Chen Liang
On Mon, 11 Mar 2024 13:45:19 GMT, Guoxiong Li wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed unused methods > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlLinkFactory.java >

Re: RFR: 8325433: Type annotations on primitive types are not linked [v3]

2024-03-11 Thread Guoxiong Li
On Mon, 11 Mar 2024 13:53:57 GMT, Chen Liang wrote: >> Please review this patch that fixes the issue where type annotations on >> primitive types are not linked. >> >> Tested with file >> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java >> >> import java.lang.annotation.*; >> >

Re: RFR: 8325433: Type annotations on primitive types are not linked [v3]

2024-03-11 Thread Chen Liang
> Please review this patch that fixes the issue where type annotations on > primitive types are not linked. > > Tested with file > https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java > > import java.lang.annotation.*; > > public class ArrayAnno { > @Retention(RetentionPolicy.R

Re: RFR: 8325433: Type annotations on primitive types are not linked [v2]

2024-03-11 Thread Guoxiong Li
On Mon, 11 Mar 2024 13:31:06 GMT, Chen Liang wrote: >> Please review this patch that fixes the issue where type annotations on >> primitive types are not linked. >> >> Tested with file >> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java >> >> import java.lang.annotation.*; >> >

RFR: JDK-8325874: Improve checkbox-based interface in summary pages

2024-03-11 Thread Hannes Wallnöfer
Please review a change to improve the user experience and implementation for the checkbox-based interface to selectively display content on API summary pages: - Add a checkbox to toggle (select/unselect) all checkboxes in the page. - Remove the `Table.setAlwaysShowDefaultTab(boolean)` setter a

Re: RFR: 8325433: Type annotations on primitive types are not linked [v2]

2024-03-11 Thread Chen Liang
On Mon, 11 Mar 2024 06:36:49 GMT, Guoxiong Li wrote: >> Chen Liang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Removed unused methods > > test/langtools/jdk/javadoc/doclet/testTypeAnnotations/typeannos/MethodReturnType.java > line 5

Re: RFR: 8325433: Type annotations on primitive types are not linked [v2]

2024-03-11 Thread Chen Liang
> Please review this patch that fixes the issue where type annotations on > primitive types are not linked. > > Tested with file > https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java > > import java.lang.annotation.*; > > public class ArrayAnno { > @Retention(RetentionPolicy.R

Re: RFR: 8325433: Type annotations on primitive types are not linked

2024-03-11 Thread Guoxiong Li
On Mon, 11 Mar 2024 13:13:07 GMT, Chen Liang wrote: > The 2-D array case is broken: currently source code `@A int @B [] @C []` is > compiled to `@A int @C [] @B []` in both class file and javadoc output, so I > don't want to add a buggy case that needs to be updated if this annotation > placem

Re: RFR: 8325433: Type annotations on primitive types are not linked

2024-03-11 Thread Chen Liang
On Mon, 11 Mar 2024 06:35:27 GMT, Guoxiong Li wrote: >> Please review this patch that fixes the issue where type annotations on >> primitive types are not linked. >> >> Tested with file >> https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java >> >> import java.lang.annotation.*; >>

Re: RFR: 8325433: Type annotations on primitive types are not linked

2024-03-11 Thread Chen Liang
On Sun, 10 Mar 2024 20:19:44 GMT, Chen Liang wrote: > Please review this patch that fixes the issue where type annotations on > primitive types are not linked. > > Tested with file > https://cr.openjdk.org/~liach/8325433-arrayanno/ArrayAnno.java > > import java.lang.annotation.*; > > public