In this PR I added an `@since` tag to SNIPPET_PATH and isBlockTag() as they
were added in later versions
- SNIPPET_PATH was added in JDK 18
[here](https://github.com/openjdk/jdk/commit/0fc47e99d20a1ee886df878f1302769bdd913aab#diff-8f73114f8b0d0d5229231541d5583382c8e8d33147e285f3d90ed8801ce9228bR
On Thu, 4 Apr 2024 21:52:20 GMT, Pavel Rappo wrote:
>> If you use `forMember` on an `ExecutableElement` whose enclosing element is
>> an annotation type interface, you know there cannot be any type parameters.
>
> Right, but some accommodation/special-casing for annotations will be there
> anyw
On Thu, 4 Apr 2024 21:31:03 GMT, Jonathan Gibbons wrote:
>> True, type parameters are not an issue for annotation interface methods,
>> which [are not allowed to have any parameters][], type or otherwise.
>> However, the code that prints annotations for method signatures does not
>> know that
On Thu, 4 Apr 2024 21:20:19 GMT, Pavel Rappo wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlIds.java
>> line 567:
>>
>>> 565: var methods =
>>> vmt.getVisibleMembers(VisibleMemberTable.Kind.METHODS);
>>> 566: // for whatever reason annotat
On Thu, 4 Apr 2024 18:52:42 GMT, Jonathan Gibbons wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Respond to feedback
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/ConstructorWriter.jav
On Thu, 4 Apr 2024 12:28:23 GMT, Pavel Rappo wrote:
>> Creating a link to a constructor or a method or comparing constructors or
>> methods __does not__ factor in type parameters. When constructors or methods
>> are overloaded and differ only in type parameters -- a situation which is
>> absen
On Thu, 4 Apr 2024 14:53:09 GMT, Pavel Rappo wrote:
>> That's actually a sign of relief that the same elements will have the same
>> id with the same input source code
>
> Reading your reply, I think that one of us is likely confused. Your question
> to which I replied "no" was this:
>
>> Will
On Thu, 4 Apr 2024 13:53:57 GMT, Chen Liang wrote:
>> The answer to your latter question is no. The id that will be assigned to
>> that public method do depend on whether the private overload positioned
>> before it is documented. You cannot do much about it with the current design
>> of `Visi
On Thu, 4 Apr 2024 12:28:13 GMT, Pavel Rappo wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlIds.java
>> line 571:
>>
>>> 569: var list = Stream.concat(Stream.concat(ctors.stream(),
>>> methods.stream()), otherMethods.stream())
>>> 570:
On Thu, 4 Apr 2024 11:41:37 GMT, Pavel Rappo wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclets/formats/html/HtmlIds.java
>> line 562:
>>
>>> 560: && e.getKind() != ElementKind.METHOD)
>>> 561: throw new
>>> IllegalArgumentException(String.valueOf(
On Wed, 3 Apr 2024 23:29:44 GMT, Chen Liang wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits since
> Creating a link to a constructor or a method or comparing constructors or
> methods __does not__ factor in type parameters. When constructors or methods
> are overloaded and differ only in type parameters -- a situation which is
> absent in JDK API, but present elsewhere -- that causes signifi
On Wed, 3 Apr 2024 23:19:29 GMT, Chen Liang wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits since
On Wed, 3 Apr 2024 23:15:43 GMT, Chen Liang wrote:
>> Pavel Rappo has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains 11 additional
>> commits since
14 matches
Mail list logo
