On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert updated translation
>
> Did not look at each for translation accuracy (did some for Japanese), but
> looks good o
On Mon, 10 Jun 2024 20:46:46 GMT, Naoto Sato wrote:
>> Damon Nguyen has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Revert updated translation
>
> Did not look at each for translation accuracy (did some for Japanese), but
> looks good o
On Mon, 10 Jun 2024 20:37:41 GMT, Damon Nguyen wrote:
>> src/java.desktop/share/classes/sun/print/resources/serviceui_zh_CN.properties
>> line 32:
>>
>>> 30: border.jobattributes=作业属性
>>> 31: border.media=介质
>>> 32: border.output=出纸
>>
>> What triggered this ? Just someone noticing it and deci
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The tra
On Tue, 11 Jun 2024 19:28:27 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The tra
> This issue is responsible for updating the translations of all the
> localize(able) resources in the JDK. Primarily, the changes between JDK 22
> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>
> The translation tool adjusted some definitions, which causes some ch
On Tue, 11 Jun 2024 06:00:19 GMT, Christian Stein wrote:
>> "Ausgabefächer" is the best German translation here.
>
> The reason for going with "Bereich (area)" instead of "Fach (compartment)" is
> that an area is more general compared to a compartment. At least in German:
> every "Fach" is a "B
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The tra
On Tue, 11 Jun 2024 17:15:49 GMT, Naoto Sato wrote:
>> Yeah, I believe you're right. Noted as something else to file against the
>> translation tool.
>
> Just out of curiosity, do we know why `\t` was attached in the first place? I
> don't think it is with the original English properties.
I ca
On Mon, 10 Jun 2024 19:45:14 GMT, Damon Nguyen wrote:
>> src/java.xml/share/classes/com/sun/org/apache/xerces/internal/impl/msg/XMLMessages_de.properties
>> line 278:
>>
>>> 276: UndeclaredElementInContentSpec = Contentmodell des Elements
>>> "{0}" verweist auf das nicht deklarierte El
On Tue, 11 Jun 2024 13:35:31 GMT, Chen Liang wrote:
>> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line
>> 556:
>>
>>> 554: }
>>> 555:
>>> 556: private final EnumSet GLOBAL_ATTRS = EnumSet.of(
>>
>> I get it, you cannot make it static because it's used in a
On Tue, 11 Jun 2024 12:45:10 GMT, Pavel Rappo wrote:
>> Nizar Benalla has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Remove classpath exception
>
> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/HtmlTag.java line
> 556:
>
On Tue, 11 Jun 2024 13:24:48 GMT, Nizar Benalla wrote:
>> Can I please get a review for this change, that aims to add support for
>> Global HTML tags.
>> Here is the
>> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html)
>> to the generated docs.
>> Thanks in
> Can I please get a review for this change, that aims to add support for
> Global HTML tags.
> Here is the
> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html)
> to the generated docs.
> Thanks in advance.
Nizar Benalla has updated the pull request incrementa
On Tue, 11 Jun 2024 11:37:27 GMT, Nizar Benalla wrote:
> Can I please get a review for this change, that aims to add support for
> Global HTML tags.
> Here is the
> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html)
> to the generated docs.
> Thanks in advanc
On Tue, 11 Jun 2024 12:37:46 GMT, Pavel Rappo wrote:
> Either what Chen has suggested or re-sort the complete list alphabetically as
> it was prior to this change.
I will go with Chen's suggestions, will fix in a bit.
I might move STYLE down as it's also a global tag
-
PR Review
On Tue, 11 Jun 2024 11:51:05 GMT, Chen Liang wrote:
>> Can I please get a review for this change, that aims to add support for
>> Global HTML tags.
>> Here is the
>> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html)
>> to the generated docs.
>> Thanks in adv
On Tue, 11 Jun 2024 11:37:27 GMT, Nizar Benalla wrote:
> Can I please get a review for this change, that aims to add support for
> Global HTML tags.
> Here is the
> [link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html)
> to the generated docs.
> Thanks in advanc
Can I please get a review for this change, that aims to add support for Global
HTML tags.
Here is the
[link](https://cr.openjdk.org/~nbenalla/javadocGlobalAttrs/pkg1/package-summary.html)
to the generated docs.
Thanks in advance.
-
Commit messages:
- Allow global variables
Change
On Mon, 10 Jun 2024 21:58:29 GMT, Damon Nguyen wrote:
>> This issue is responsible for updating the translations of all the
>> localize(able) resources in the JDK. Primarily, the changes between JDK 22
>> RDP 1 and the integration of the JDK 23 RDP 1 L10n drop will be translated.
>>
>> The tra
20 matches
Mail list logo
