Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v6]

2024-11-12 Thread Sean Mullan
On Fri, 1 Nov 2024 19:40:03 GMT, Alexey Ivanov wrote: >> Sean Mullan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 200 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411 >> - Modify three RMI t

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v11]

2024-11-12 Thread Sean Mullan
On Fri, 8 Nov 2024 18:31:13 GMT, Harshitha Onkar wrote: >> It has a value… when it's mentioned with `@see`, the link is present in the >> *See Also* section, as you can see in the the specification of >> [`MouseInfo.getPointerInfo()`](https://docs.oracle.com/en/java/javase/21/docs/api/java.desk

Integrated: 8338411: Implement JEP 486: Permanently Disable the Security Manager

2024-11-12 Thread Sean Mullan
On Mon, 14 Oct 2024 13:52:24 GMT, Sean Mullan wrote: > This is the implementation of JEP 486: Permanently Disable the Security > Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The > [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the > main change

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v11]

2024-11-12 Thread Alexey Ivanov
On Tue, 12 Nov 2024 14:44:55 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v11]

2024-11-12 Thread Sean Coffey
On Tue, 12 Nov 2024 14:44:55 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v11]

2024-11-12 Thread Lance Andersen
On Tue, 12 Nov 2024 14:44:55 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v11]

2024-11-12 Thread Alexey Ivanov
On Tue, 12 Nov 2024 15:02:12 GMT, Sean Mullan wrote: >> I can add it back if it is more convenient and readable to have the `@see` >> tag. > > This can be taken care of later after integration. Agreed! - PR Review Comment: https://git.openjdk.org/jdk/pull/21498#discussion_r1838282

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v11]

2024-11-12 Thread Roger Riggs
On Tue, 12 Nov 2024 14:44:55 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v3]

2024-11-12 Thread Sean Mullan
On Thu, 24 Oct 2024 17:03:25 GMT, Alexey Ivanov wrote: >> Sean Mullan has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 150 commits: >> >> - Merge remote-tracking branch 'jdk-sandbox/jep486' into JDK-8338411 >> - Merge >> - Updat

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v11]

2024-11-12 Thread Roger Riggs
On Tue, 12 Nov 2024 14:44:55 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v11]

2024-11-12 Thread Kevin Walls
On Tue, 12 Nov 2024 14:44:55 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v11]

2024-11-12 Thread Sean Mullan
> This is the implementation of JEP 486: Permanently Disable the Security > Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The > [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the > main changes in the JEP and also includes an apidiff of the specif

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v10]

2024-11-12 Thread Roger Riggs
On Tue, 12 Nov 2024 13:01:33 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v10]

2024-11-12 Thread Kevin Walls
On Tue, 12 Nov 2024 13:01:33 GMT, Sean Mullan wrote: >> This is the implementation of JEP 486: Permanently Disable the Security >> Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The >> [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the >> main ch

Withdrawn: 8279931: Generate warning for wrong @param tag order

2024-11-12 Thread Hannes Wallnöfer
On Fri, 25 Oct 2024 12:23:09 GMT, Hannes Wallnöfer wrote: > Please review a change to add a DocLint warning for JavaDoc `@param` tags > that don't match the order of parameters in the documented element. The > warning is part of the the DocLint "reference" group. > > The code to check order o

Re: RFR: 8279931: Generate warning for wrong @param tag order

2024-11-12 Thread Hannes Wallnöfer
On Fri, 25 Oct 2024 12:23:09 GMT, Hannes Wallnöfer wrote: > Please review a change to add a DocLint warning for JavaDoc `@param` tags > that don't match the order of parameters in the documented element. The > warning is part of the the DocLint "reference" group. > > The code to check order o

Re: RFR: 8338411: Implement JEP 486: Permanently Disable the Security Manager [v10]

2024-11-12 Thread Sean Mullan
> This is the implementation of JEP 486: Permanently Disable the Security > Manager. See [JEP 486](https://openjdk.org/jeps/486) for more details. The > [CSR](https://bugs.openjdk.org/browse/JDK-8338412) describes in detail the > main changes in the JEP and also includes an apidiff of the specif

Re: RFR: 8343752: The javadoc should contain a note about usages of requires transitive java.base; [v4]

2024-11-12 Thread Hannes Wallnöfer
On Mon, 11 Nov 2024 07:25:38 GMT, Jan Lahoda wrote: >> When https://github.com/openjdk/jdk/pull/21431 is integrated, there will be >> a new preview language feature: `requires transitive java.base;`. It would >> be good to show a warning box in the javadoc about the use of the feature. >> This

Integrated: 8202617: javadoc generates broken links to undocumented (e.g. private) members

2024-11-12 Thread Nizar Benalla
On Thu, 31 Oct 2024 11:48:27 GMT, Nizar Benalla wrote: > Please review this patch to prevent links to private and package-private > members to be generated. > The bug happens when you link to private/package-private members, and javadoc > used to generated links to them (assuming they were inhe

Re: RFR: 8202617: javadoc generates broken links to undocumented (e.g. private) members [v4]

2024-11-12 Thread Nizar Benalla
On Fri, 8 Nov 2024 13:52:28 GMT, Nizar Benalla wrote: >> Please review this patch to prevent links to private and package-private >> members to be generated. >> The bug happens when you link to private/package-private members, and >> javadoc used to generated links to them (assuming they were i

Integrated: 8340565: Create separate index page for terms defined by the index tag

2024-11-12 Thread Hannes Wallnöfer
On Wed, 9 Oct 2024 17:49:23 GMT, Hannes Wallnöfer wrote: > This change adds a conditional `search-tags.html` page to list all search > tags defined by the `{@index ... }` tag. Since search tags work very similar > to the `{@systemProperty ...}` tag and are internally represented by the same >

Integrated: 8341904: Search tag in inherited doc comment creates additional index item

2024-11-12 Thread Hannes Wallnöfer
On Tue, 29 Oct 2024 14:51:53 GMT, Hannes Wallnöfer wrote: > Please review a change to avoid generation of index items for comments > inherited from overridden methods. This affects `{@index}`, > `{@systemProperty}`, and `@spec` tags in both implicitly and explicitly doc > comments. > > The c